|Summary:||ASTERISK-06055: [test-this-branch] added support for "meetme list <confno> concise" to easily script parsing|
|Reporter:||Moises Silva (moy)||Labels:|
|Date Opened:||2006-01-11 18:04:55.000-0600||Date Closed:||2006-05-09 21:58:23|
|Environment:||Attachments:||( 0) asterisk-svn-25716-meetme-listconcise.patch|
|Description:||this patch adds support for the new command "meetme list <confno> concise", it works like the current "show channels concise", it gives output that is easily parsed from scripts to display the current memebers of the conference|
****** ADDITIONAL INFORMATION ******
actually im uploading 2 patches, one apply to latest SVN and the other apply to 1.2.1 release
|Comments:||By: Moises Silva (moy) 2006-01-11 18:09:26.000-0600|
sorry for the SVN revision, complete SVN revision is: SVN-trunk-r7991M
i have tested the patch for 1.2.1 only, but the other one should work too. I could not test it because it said:
loader.c:325 __load_resource: /usr/lib/asterisk/modules/app_meetme.so: undefined symbol: ast_read_noaudio
but that is not related to my patch, tough -_-
By: Jason Parker (jparker) 2006-01-11 18:12:27.000-0600
You'll need to have a disclaimer on file before anybody can really look at these patches. Send one in, and post back here when you're done.
By: Matt O'Gorman (mogorman) 2006-01-11 23:18:09.000-0600
http://www.digium.com/index.php?menu=bugguidelines has info on disclaimer
By: Moises Silva (moy) 2006-01-12 07:54:43.000-0600
sorry, indeed i read that, but i supposed (obviously wrong) that such disclaimer was for "real" changes where more than a few lines were required. I will send it ASAP
Thanks for your time
By: Matt O'Gorman (mogorman) 2006-01-12 08:50:41.000-0600
By: Tilghman Lesher (tilghman) 2006-03-01 16:11:38.000-0600
Please reopen when you have a disclaimer on file
By: Moises Silva (moy) 2006-03-20 09:54:46.000-0600
How, that was a lot more time than i expected. But finally I have sign/fax the disclaimer 2 minutes ago. Anything else i have to do? the patch still apply in 1.2.5
By: Moises Silva (moy) 2006-03-20 13:53:11.000-0600
added updated version tested with SVN 13620
By: Olle Johansson (oej) 2006-04-05 11:05:45
Added to test-this-branch
By: BJ Weschke (bweschke) 2006-05-08 09:24:46
moy: this patch no longer applies cleanly against app_meetme.c in /trunk. If you want to redo it, we can try to get it in again.
Additionally, here's a couple more things to consider:
* The delimiter used should probably be | to keep consistent with every else we're implementing strings returned with delimiters.
* With Mark's implementation of the AJAM http connector now available in /trunk that allows you to get at this data in an AJAX compliant method, how necessary is a patch like this anymore? I'm not saying it's not, just interested in your take on it.
By: Serge Vecher (serge-v) 2006-05-08 17:45:55
1. as per coding guidelines, single line if ... else constructs don't need curly brackets.
2. what's the deal with asterisk-svn-24742-transfer.patch? Looks like it belongs in a different bug.
By: Moises Silva (moy) 2006-05-08 18:42:09
vechers: im very sorry about that. Is fixed now. Regarding to the transfer patch, yes, i dont know how it got there :( ...... please delete it to avoid confusing other people
By: Moises Silva (moy) 2006-05-08 18:50:07
about the first point:
I have used the same delimiter as in 'show channels concise'. What to do? keep using "!" for "concise" commands??
about the second point:
I have read about AJAM, and I think is "cool", but im not sure that is something that Asterisk should be handling. In the other hand, not every application using AMI needs AJAX. In my case, we have build a PHP proxy daemon that connects to the manager interface. Other PHP daemon connects to the proxy and read events and send normal actions and MAGI (read about magi patch) actions to route the calls. So, we definitly have nothing to do with AJAX or the web based approach.
Thanks a lot for your comments :)
By: BJ Weschke (bweschke) 2006-05-09 21:58:22
moy: thanks for pointing out show channels concise to me. Given there's precedence, I've committed this to /trunk. Thanks!