Summary:	ASTERISK-06054: app_voicemail realtime uses a SQL92 reserved word (delete)
Reporter:	Lance Kimes (lkimes)	Labels:
Date Opened:	2006-01-11 16:10:20.000-0600	Date Closed:	2006-01-11 23:16:40.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) voicemail.svn7843.patch
Description:	app_voicemail realtime uses a SQL92 reserved word (delete) as a column name.  These are reserved from use by the SQL92 spec and almost every SQL database server will refuse to allow you to use them, delete among them. This makes the option unuseable with ARA. The option delete, for deleting voicemail after sending it in email, needs to be changed to something like deletesent. I've made the necessary changes so that the option is now deletesent.  When reading the voicemail.conf it still provides for backward compatibility with delete so either will still work. However, when using this option with ARA, deletesent will be required. The delete option should be consider deprecated from this point. Whether delete should be kept for backward compatibility, I defer to others. Whether the option should now be deletesent, deletesentmail or something else, I again defer to others. But it has to change or it become useless in ARA and we need to use it.  Patch to be posted later today.
Comments:	By: Lance Kimes (lkimes) 2006-01-11 16:15:38.000-0600 Also noticed one other bug in deleting voicemail after sending notification.  They weren't actually deleted or more specifically, they were stored again after they were deleted.  I code 2 lines of code to have the voicemail stored(to disk or ODBC) *before* notification was sent.  This way the message can be deleted after notification was sent and not have it re-saved immediately after being deleted. By: Jason Parker (jparker) 2006-01-11 16:19:23.000-0600 Are you able to submit patches for these issues? By: Tilghman Lesher (tilghman) 2006-01-11 23:16:12.000-0600 We do not change option names in the middle of a release cycle; however, I have added the equivalent 'deletevoicemail' which can be used in Realtime. Committed to 1.2; merged to trunk.