| Summary: | ASTERISK-06022: [patch] ast_strlen_zero janitor project - NULL check found in func_md5.c | ||
| Reporter: | Matthew Roth (matthew roth) | Labels: | |
| Date Opened: | 2006-01-09 11:19:07.000-0600 | Date Closed: | 2008-01-15 16:13:39.000-0600 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) func_md5-janitor_project_ast_strlen_zero-1.0.patch | |
| Description: | This patch corrects funcs/func_md5.c as per the ast_strlen_zero janitor project. The function builtin_function_checkmd5 was testing a char * for NULL prior to calling ast_strlen_zero on it. | ||
| Comments: | By: Russell Bryant (russell) 2006-01-09 11:28:01.000-0600 Added to the trunk, thanks! By: Digium Subversion (svnbot) 2008-01-15 16:13:04.000-0600 Repository: asterisk Revision: 7901 U trunk/funcs/func_md5.c ------------------------------------------------------------------------ r7901 | russell | 2008-01-15 16:13:03 -0600 (Tue, 15 Jan 2008) | 2 lines remove unnecessary check before ast_strlen_zero (issue ASTERISK-6022) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7901 By: Digium Subversion (svnbot) 2008-01-15 16:13:32.000-0600 Repository: asterisk Revision: 7935 _U team/oej/aum-trunk/ _U team/oej/aum-trunk/apps/ U team/oej/aum-trunk/apps/app_voicemail.c U team/oej/aum-trunk/asterisk.c _U team/oej/aum-trunk/cdr/ _U team/oej/aum-trunk/channels/ U team/oej/aum-trunk/channels/chan_iax2.c U team/oej/aum-trunk/channels/chan_sip.c _U team/oej/aum-trunk/codecs/ _U team/oej/aum-trunk/codecs/ilbc/ _U team/oej/aum-trunk/codecs/lpc10/ A team/oej/aum-trunk/contrib/init.d/rc.suse.asterisk _U team/oej/aum-trunk/db1-ast/ U team/oej/aum-trunk/doc/README.variables _U team/oej/aum-trunk/editline/ U team/oej/aum-trunk/file.c _U team/oej/aum-trunk/formats/ _U team/oej/aum-trunk/funcs/ U team/oej/aum-trunk/funcs/Makefile A team/oej/aum-trunk/funcs/func_base64.c U team/oej/aum-trunk/funcs/func_md5.c A team/oej/aum-trunk/funcs/func_rand.c U team/oej/aum-trunk/include/asterisk/utils.h _U team/oej/aum-trunk/pbx/ U team/oej/aum-trunk/pbx/pbx_spool.c U team/oej/aum-trunk/pbx.c _U team/oej/aum-trunk/res/ U team/oej/aum-trunk/say.c _U team/oej/aum-trunk/stdtime/ U team/oej/aum-trunk/utils.c ------------------------------------------------------------------------ r7935 | oej | 2008-01-15 16:13:32 -0600 (Tue, 15 Jan 2008) | 95 lines Merged revisions 7887,7897,7901-7902,7907,7909,7911-7913,7916,7918-7921,7929 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7887 | oej | 2006-01-09 16:20:53 +0100 (Mon, 09 Jan 2006) | 3 lines -Move declaration of callevents variable out of the block of function declarations. -Do not set it to a default value, it's set later on before loading configuration. ................ r7897 | kpfleming | 2006-01-09 19:03:18 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7863 ................ r7901 | russell | 2006-01-09 19:29:03 +0100 (Mon, 09 Jan 2006) | 2 lines remove unnecessary check before ast_strlen_zero (issue ASTERISK-6022) ................ r7902 | kpfleming | 2006-01-09 19:34:09 +0100 (Mon, 09 Jan 2006) | 2 lines restore proper svn:ignore properties that were somehow lost... ................ r7907 | tilghman | 2006-01-09 20:33:47 +0100 (Mon, 09 Jan 2006) | 3 lines Merged revisions 7904 via svnmerge from /branches/1.2 ................ r7909 | tilghman | 2006-01-09 21:12:07 +0100 (Mon, 09 Jan 2006) | 3 lines Merged revisions 7908 via svnmerge from /branches/1.2 ................ r7911 | tilghman | 2006-01-09 22:22:36 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6099 - cleanup of parse_variable_name and pbx_retrieve_variable ................ r7912 | oej | 2006-01-09 22:30:46 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6112: file.c list macro conversion (drumkilla) ................ r7913 | mogorman | 2006-01-09 22:50:20 +0100 (Mon, 09 Jan 2006) | 4 lines Changed say.c aliased zh to the tw say.c output. Done in relation to bug 6135. ................ r7916 | russell | 2006-01-09 23:09:15 +0100 (Mon, 09 Jan 2006) | 3 lines block rev 7915 from being merged into the trunk, since the patch is not compatible ................ r7918 | kpfleming | 2006-01-10 00:06:28 +0100 (Tue, 10 Jan 2006) | 10 lines Merged revisions 7917 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7917 | kpfleming | 2006-01-09 16:48:48 -0600 (Mon, 09 Jan 2006) | 2 lines re-initialize _all_ sequence numbers when transfer completes ........ ................ r7919 | tilghman | 2006-01-10 00:20:50 +0100 (Tue, 10 Jan 2006) | 2 lines Bug 6106 - SuSE startup script ................ r7920 | tilghman | 2006-01-10 01:55:45 +0100 (Tue, 10 Jan 2006) | 2 lines Bug 5961 - new RAND() function ................ r7921 | mogorman | 2006-01-10 02:52:34 +0100 (Tue, 10 Jan 2006) | 3 lines committing 5924 with minor white space changes and adding it to the Makefile for functions. ................ r7929 | tilghman | 2006-01-10 04:23:38 +0100 (Tue, 10 Jan 2006) | 2 lines Fix indentation ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7935 By: Digium Subversion (svnbot) 2008-01-15 16:13:34.000-0600 Repository: asterisk Revision: 7937 _U team/oej/sipregister/ _U team/oej/sipregister/apps/ U team/oej/sipregister/apps/app_voicemail.c U team/oej/sipregister/asterisk.c _U team/oej/sipregister/cdr/ _U team/oej/sipregister/channels/ U team/oej/sipregister/channels/chan_iax2.c _U team/oej/sipregister/codecs/ _U team/oej/sipregister/codecs/ilbc/ _U team/oej/sipregister/codecs/lpc10/ A team/oej/sipregister/contrib/init.d/rc.suse.asterisk _U team/oej/sipregister/db1-ast/ U team/oej/sipregister/doc/README.variables _U team/oej/sipregister/editline/ U team/oej/sipregister/file.c _U team/oej/sipregister/formats/ _U team/oej/sipregister/funcs/ U team/oej/sipregister/funcs/Makefile A team/oej/sipregister/funcs/func_base64.c U team/oej/sipregister/funcs/func_md5.c A team/oej/sipregister/funcs/func_rand.c U team/oej/sipregister/include/asterisk/utils.h _U team/oej/sipregister/pbx/ U team/oej/sipregister/pbx/pbx_spool.c U team/oej/sipregister/pbx.c _U team/oej/sipregister/res/ U team/oej/sipregister/say.c _U team/oej/sipregister/stdtime/ U team/oej/sipregister/utils.c ------------------------------------------------------------------------ r7937 | oej | 2008-01-15 16:13:34 -0600 (Tue, 15 Jan 2008) | 94 lines Merged revisions 7897,7901-7902,7907,7909,7911-7913,7916,7918-7921,7929,7936 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7897 | kpfleming | 2006-01-09 19:03:18 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7863 ................ r7901 | russell | 2006-01-09 19:29:03 +0100 (Mon, 09 Jan 2006) | 2 lines remove unnecessary check before ast_strlen_zero (issue ASTERISK-6022) ................ r7902 | kpfleming | 2006-01-09 19:34:09 +0100 (Mon, 09 Jan 2006) | 2 lines restore proper svn:ignore properties that were somehow lost... ................ r7907 | tilghman | 2006-01-09 20:33:47 +0100 (Mon, 09 Jan 2006) | 3 lines Merged revisions 7904 via svnmerge from /branches/1.2 ................ r7909 | tilghman | 2006-01-09 21:12:07 +0100 (Mon, 09 Jan 2006) | 3 lines Merged revisions 7908 via svnmerge from /branches/1.2 ................ r7911 | tilghman | 2006-01-09 22:22:36 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6099 - cleanup of parse_variable_name and pbx_retrieve_variable ................ r7912 | oej | 2006-01-09 22:30:46 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6112: file.c list macro conversion (drumkilla) ................ r7913 | mogorman | 2006-01-09 22:50:20 +0100 (Mon, 09 Jan 2006) | 4 lines Changed say.c aliased zh to the tw say.c output. Done in relation to bug 6135. ................ r7916 | russell | 2006-01-09 23:09:15 +0100 (Mon, 09 Jan 2006) | 3 lines block rev 7915 from being merged into the trunk, since the patch is not compatible ................ r7918 | kpfleming | 2006-01-10 00:06:28 +0100 (Tue, 10 Jan 2006) | 10 lines Merged revisions 7917 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7917 | kpfleming | 2006-01-09 16:48:48 -0600 (Mon, 09 Jan 2006) | 2 lines re-initialize _all_ sequence numbers when transfer completes ........ ................ r7919 | tilghman | 2006-01-10 00:20:50 +0100 (Tue, 10 Jan 2006) | 2 lines Bug 6106 - SuSE startup script ................ r7920 | tilghman | 2006-01-10 01:55:45 +0100 (Tue, 10 Jan 2006) | 2 lines Bug 5961 - new RAND() function ................ r7921 | mogorman | 2006-01-10 02:52:34 +0100 (Tue, 10 Jan 2006) | 3 lines committing 5924 with minor white space changes and adding it to the Makefile for functions. ................ r7929 | tilghman | 2006-01-10 04:23:38 +0100 (Tue, 10 Jan 2006) | 2 lines Fix indentation ................ r7936 | oej | 2006-01-10 09:33:52 +0100 (Tue, 10 Jan 2006) | 2 lines Declare missing randomlock ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7937 By: Digium Subversion (svnbot) 2008-01-15 16:13:39.000-0600 Repository: asterisk Revision: 7941 _U team/oej/multiparking/ _U team/oej/multiparking/apps/ U team/oej/multiparking/apps/app_voicemail.c U team/oej/multiparking/asterisk.c _U team/oej/multiparking/cdr/ _U team/oej/multiparking/channels/ U team/oej/multiparking/channels/chan_iax2.c U team/oej/multiparking/channels/chan_sip.c _U team/oej/multiparking/codecs/ _U team/oej/multiparking/codecs/ilbc/ _U team/oej/multiparking/codecs/lpc10/ A team/oej/multiparking/contrib/init.d/rc.suse.asterisk _U team/oej/multiparking/db1-ast/ U team/oej/multiparking/doc/README.variables _U team/oej/multiparking/editline/ U team/oej/multiparking/file.c _U team/oej/multiparking/formats/ _U team/oej/multiparking/funcs/ U team/oej/multiparking/funcs/Makefile A team/oej/multiparking/funcs/func_base64.c U team/oej/multiparking/funcs/func_md5.c A team/oej/multiparking/funcs/func_rand.c U team/oej/multiparking/include/asterisk/utils.h _U team/oej/multiparking/pbx/ U team/oej/multiparking/pbx/pbx_spool.c U team/oej/multiparking/pbx.c _U team/oej/multiparking/res/ U team/oej/multiparking/res/res_features.c U team/oej/multiparking/say.c _U team/oej/multiparking/stdtime/ U team/oej/multiparking/utils.c ------------------------------------------------------------------------ r7941 | oej | 2008-01-15 16:13:39 -0600 (Tue, 15 Jan 2008) | 105 lines Merged revisions 7875,7887,7897,7901-7902,7907,7909,7911-7913,7916,7918-7921,7929,7936 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7875 | oej | 2006-01-09 10:07:58 +0100 (Mon, 09 Jan 2006) | 2 lines Doxygen update ................ r7887 | oej | 2006-01-09 16:20:53 +0100 (Mon, 09 Jan 2006) | 3 lines -Move declaration of callevents variable out of the block of function declarations. -Do not set it to a default value, it's set later on before loading configuration. ................ r7897 | kpfleming | 2006-01-09 19:03:18 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7863 ................ r7901 | russell | 2006-01-09 19:29:03 +0100 (Mon, 09 Jan 2006) | 2 lines remove unnecessary check before ast_strlen_zero (issue ASTERISK-6022) ................ r7902 | kpfleming | 2006-01-09 19:34:09 +0100 (Mon, 09 Jan 2006) | 2 lines restore proper svn:ignore properties that were somehow lost... ................ r7907 | tilghman | 2006-01-09 20:33:47 +0100 (Mon, 09 Jan 2006) | 3 lines Merged revisions 7904 via svnmerge from /branches/1.2 ................ r7909 | tilghman | 2006-01-09 21:12:07 +0100 (Mon, 09 Jan 2006) | 3 lines Merged revisions 7908 via svnmerge from /branches/1.2 ................ r7911 | tilghman | 2006-01-09 22:22:36 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6099 - cleanup of parse_variable_name and pbx_retrieve_variable ................ r7912 | oej | 2006-01-09 22:30:46 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6112: file.c list macro conversion (drumkilla) ................ r7913 | mogorman | 2006-01-09 22:50:20 +0100 (Mon, 09 Jan 2006) | 4 lines Changed say.c aliased zh to the tw say.c output. Done in relation to bug 6135. ................ r7916 | russell | 2006-01-09 23:09:15 +0100 (Mon, 09 Jan 2006) | 3 lines block rev 7915 from being merged into the trunk, since the patch is not compatible ................ r7918 | kpfleming | 2006-01-10 00:06:28 +0100 (Tue, 10 Jan 2006) | 10 lines Merged revisions 7917 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7917 | kpfleming | 2006-01-09 16:48:48 -0600 (Mon, 09 Jan 2006) | 2 lines re-initialize _all_ sequence numbers when transfer completes ........ ................ r7919 | tilghman | 2006-01-10 00:20:50 +0100 (Tue, 10 Jan 2006) | 2 lines Bug 6106 - SuSE startup script ................ r7920 | tilghman | 2006-01-10 01:55:45 +0100 (Tue, 10 Jan 2006) | 2 lines Bug 5961 - new RAND() function ................ r7921 | mogorman | 2006-01-10 02:52:34 +0100 (Tue, 10 Jan 2006) | 3 lines committing 5924 with minor white space changes and adding it to the Makefile for functions. ................ r7929 | tilghman | 2006-01-10 04:23:38 +0100 (Tue, 10 Jan 2006) | 2 lines Fix indentation ................ r7936 | oej | 2006-01-10 09:33:52 +0100 (Tue, 10 Jan 2006) | 2 lines Declare missing randomlock ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7941 | ||