Summary: | ASTERISK-05997: [patch] fix broken create_addr_from_peer (segfault) | ||
Reporter: | deti (deti) | Labels: | |
Date Opened: | 2006-01-06 11:07:11.000-0600 | Date Closed: | 2008-01-15 16:12:25.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) chan_sip-fix-create_addr_from_peer-only.patch | |
Description: | create_addr_from_peer no longer works if callid needs to be modified. strncpy(callhost + 1, peer->fromdomain, sizeof(r->callid) - (callhost - r->callid) - 2) fails because of new AST_DECLARE_STRING_FIELDS macros where sizeof(r->callid) returns 4. Fix: copy old callid without hostpart to local string, then call ast_string_field_build to create new callid. (FYI: Patch attached also contains fix for RPID handling, already reported as Bug ASTERISK-5987) | ||
Comments: | By: Jason Parker (jparker) 2006-01-06 11:21:37.000-0600 Please make a seperate patch for the create_addr_from_peer fix. If one gets committed, the other will fail, which means it may take longer to get this fixed. By: deti (deti) 2006-01-06 11:32:31.000-0600 pls delete old patch. New one only contains specified fix. By: Jason Parker (jparker) 2006-01-06 11:35:10.000-0600 Deleted, thanks. By: Mark Spencer (markster) 2006-01-07 14:30:01.000-0600 Fixed in SVN head, although i used a different strategy for getting there. Thanks! By: Digium Subversion (svnbot) 2008-01-15 16:12:25.000-0600 Repository: asterisk Revision: 7861 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r7861 | markster | 2008-01-15 16:12:25 -0600 (Tue, 15 Jan 2008) | 2 lines Handle swapout of "fromdomain" in callid properly (bug ASTERISK-5997) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7861 |