ASTERISK-05984: [patch] uninitialized variables and misplaced checks in format_pcm[

[Home]

Summary: ASTERISK-05984: [patch] uninitialized variables and misplaced checks in format_pcm[_alaw].c

Reporter: Luigi Rizzo (rizzo) Labels:

Date Opened: 2006-01-05 04:38:11.000-0600 Date Closed: 2008-01-15 16:20:54.000-0600

Priority: Minor Regression? No

Status: Closed/Complete Components: Core/General

Versions: Frequency of
Occurrence

Related
Issues:

Environment: Attachments: ( 0) formats.diff

Description: the attached patch fixes a problem with a potentially uninitialized
variable in pcm_seek(), puts the checks for negative or too large
offset in proper places (with warnings), and reduces a trivial
switch() to an "if" statement.

Comments: By: Matthew Fredrickson (mattf) 2006-01-20 14:36:57.000-0600

Put in trunk
By: Digium Subversion (svnbot) 2008-01-15 16:19:54.000-0600

Repository: asterisk
Revision: 8357

U trunk/formats/format_pcm.c
U trunk/formats/format_pcm_alaw.c

------------------------------------------------------------------------
r8357 | mattf | 2008-01-15 16:19:54 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix for formats so they give better output on failure conditions. (ASTERISK-5984)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8357
By: Digium Subversion (svnbot) 2008-01-15 16:19:56.000-0600

Repository: asterisk
Revision: 8358

_U team/oej/astum/
U team/oej/astum/apps/app_meetme.c
U team/oej/astum/apps/app_milliwatt.c
U team/oej/astum/apps/app_queue.c
U team/oej/astum/apps/app_random.c
U team/oej/astum/apps/app_sms.c
U team/oej/astum/apps/app_voicemail.c
U team/oej/astum/ast_expr2.fl
U team/oej/astum/ast_expr2.y
U team/oej/astum/asterisk.c
U team/oej/astum/channels/chan_agent.c
U team/oej/astum/channels/chan_alsa.c
U team/oej/astum/channels/chan_iax2.c
U team/oej/astum/channels/chan_local.c
U team/oej/astum/channels/chan_oss.c
U team/oej/astum/channels/chan_sip.c
U team/oej/astum/channels/chan_zap.c
U team/oej/astum/channels/iax2-provision.c
U team/oej/astum/channels/iax2-provision.h
U team/oej/astum/cli.c
U team/oej/astum/config.c
U team/oej/astum/configs/alsa.conf.sample
U team/oej/astum/configs/sip.conf.sample
U team/oej/astum/configs/zapata.conf.sample
U team/oej/astum/devicestate.c
A team/oej/astum/doc/README.callingpres
U team/oej/astum/enum.c
U team/oej/astum/formats/format_pcm.c
U team/oej/astum/formats/format_pcm_alaw.c
U team/oej/astum/include/asterisk/channel.h
U team/oej/astum/include/asterisk/cli.h
U team/oej/astum/include/asterisk/module.h
U team/oej/astum/include/asterisk/utils.h
U team/oej/astum/loader.c
U team/oej/astum/logger.c
U team/oej/astum/manager.c
U team/oej/astum/pbx/pbx_config.c
U team/oej/astum/pbx/pbx_dundi.c
U team/oej/astum/pbx.c
U team/oej/astum/res/res_clioriginate.c
U team/oej/astum/res/res_features.c
U team/oej/astum/udptl.c

------------------------------------------------------------------------
r8358 | oej | 2008-01-15 16:19:55 -0600 (Tue, 15 Jan 2008) | 162 lines

Merged revisions 8195,8203,8233,8243,8270,8278,8282,8299-8300,8313,8315,8323-8324,8336,8338,8345-8346,8348,8356-8357 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8195 | mogorman | 2006-01-18 22:12:14 +0100 (Wed, 18 Jan 2006) | 11 lines

Merged revisions 8194 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8194 | mogorman | 2006-01-18 15:02:06 -0600 (Wed, 18 Jan 2006) | 3 lines

Solves issue with the login proccess in meetme
patch from 6136

........

................
r8203 | russell | 2006-01-18 23:17:31 +0100 (Wed, 18 Jan 2006) | 2 lines

constify arguments in more places where strings should not be modified (issue ASTERISK-6126)

................
r8233 | russell | 2006-01-19 05:21:12 +0100 (Thu, 19 Jan 2006) | 11 lines

Merged revisions 8232 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8232 | russell | 2006-01-18 23:17:45 -0500 (Wed, 18 Jan 2006) | 3 lines

fix a seg fault due to assuming that space gets allocatted on the stack in the
same order that we declare the variables (issue ASTERISK-6130)

........

................
r8243 | russell | 2006-01-19 05:58:43 +0100 (Thu, 19 Jan 2006) | 11 lines

Merged revisions 8242 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8242 | russell | 2006-01-18 23:56:48 -0500 (Wed, 18 Jan 2006) | 3 lines

fix Message-Account header to use the ip address if the fromdomain
isn't set (issue ASTERISK-6118)

........

................
r8270 | tilghman | 2006-01-19 19:58:45 +0100 (Thu, 19 Jan 2006) | 2 lines

Deprecate the use of Random in 1.3, 1.4

................
r8278 | tilghman | 2006-01-19 20:18:51 +0100 (Thu, 19 Jan 2006) | 3 lines

Merged revisions 8276 via svnmerge from
/branches/1.2

................
r8282 | oej | 2006-01-19 20:41:06 +0100 (Thu, 19 Jan 2006) | 2 lines

Enable "musicclass" setting for sip peers

................
r8299 | oej | 2006-01-19 23:09:18 +0100 (Thu, 19 Jan 2006) | 2 lines

Doxygen fixes

................
r8300 | oej | 2006-01-19 23:41:55 +0100 (Thu, 19 Jan 2006) | 3 lines

Add support for "musicclass" instead of "musiconhold" to make chan_zap compatible
with other channels.

................
r8313 | oej | 2006-01-20 01:08:36 +0100 (Fri, 20 Jan 2006) | 2 lines

Doxygen updates

................
r8315 | oej | 2006-01-20 01:18:42 +0100 (Fri, 20 Jan 2006) | 2 lines

More doxygen updates

................
r8323 | mogorman | 2006-01-20 02:07:46 +0100 (Fri, 20 Jan 2006) | 11 lines

Merged revisions 8320 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8320 | mogorman | 2006-01-19 19:00:46 -0600 (Thu, 19 Jan 2006) | 3 lines

solved problem with delayreject and iax trunking
bug 4291

........

................
r8324 | russell | 2006-01-20 02:25:12 +0100 (Fri, 20 Jan 2006) | 2 lines

fix version reporting (issue ASTERISK-6132)

................
r8336 | oej | 2006-01-20 15:32:30 +0100 (Fri, 20 Jan 2006) | 4 lines

- Add DOC file about caller ID presentation values
- Add callingpres to sip.conf
- Add reference to README.callingpres from zapata.conf

................
r8338 | kpfleming | 2006-01-20 18:27:51 +0100 (Fri, 20 Jan 2006) | 2 lines

eliminate compiler warnings from recent const-ification

................
r8345 | mattf | 2006-01-20 19:17:46 +0100 (Fri, 20 Jan 2006) | 2 lines

Update config. Apprently default doesn't always work now.

................
r8346 | mattf | 2006-01-20 19:18:40 +0100 (Fri, 20 Jan 2006) | 2 lines

Change chan_alsa to default open the first sound card device

................
r8348 | russell | 2006-01-20 19:40:24 +0100 (Fri, 20 Jan 2006) | 10 lines

Merged revisions 8347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8347 | russell | 2006-01-20 13:34:42 -0500 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue ASTERISK-6142)

........

................
r8356 | russell | 2006-01-20 20:24:42 +0100 (Fri, 20 Jan 2006) | 11 lines

- move ast_strdupa from channel.h to utils.h
- attempt to log an error message if the __builtin_alloca inside of ast_strdupa
fails.
- document the fact that it is known and intended behavior for ast_strdupa to
cause Asterisk to crash if the alloca fails
- use __builtin_expect when checking for allocation failure in all of the
allocation wrappers

New Janitor Project! Anywhere that we check for a successful allocation after
a call to ast_strdupa is unnecessary and should be removed.

................
r8357 | mattf | 2006-01-20 22:36:33 +0100 (Fri, 20 Jan 2006) | 2 lines

Fix for formats so they give better output on failure conditions. (ASTERISK-5984)

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8358
By: Digium Subversion (svnbot) 2008-01-15 16:20:34.000-0600

Repository: asterisk
Revision: 8397

_U team/russell/make_output/
U team/russell/make_output/apps/app_queue.c
U team/russell/make_output/callerid.c
U team/russell/make_output/codecs/codec_a_mu.c
U team/russell/make_output/codecs/codec_adpcm.c
U team/russell/make_output/codecs/codec_alaw.c
U team/russell/make_output/codecs/codec_g723_1.c
U team/russell/make_output/codecs/codec_g726.c
U team/russell/make_output/codecs/codec_gsm.c
U team/russell/make_output/codecs/codec_ilbc.c
U team/russell/make_output/codecs/codec_lpc10.c
U team/russell/make_output/codecs/codec_speex.c
U team/russell/make_output/codecs/codec_ulaw.c
U team/russell/make_output/codecs/gsm/Makefile
U team/russell/make_output/configs/alsa.conf.sample
U team/russell/make_output/configs/sip.conf.sample
U team/russell/make_output/configs/zapata.conf.sample
A team/russell/make_output/doc/README.callingpres
U team/russell/make_output/formats/format_pcm.c
U team/russell/make_output/formats/format_pcm_alaw.c
U team/russell/make_output/include/asterisk/channel.h
U team/russell/make_output/include/asterisk/utils.h
U team/russell/make_output/pbx.c
U team/russell/make_output/res/res_agi.c

------------------------------------------------------------------------
r8397 | russell | 2008-01-15 16:20:34 -0600 (Tue, 15 Jan 2008) | 131 lines

Merged revisions 8336,8338,8345-8346,8348,8356-8357,8359-8362,8368,8370-8372,8378-8381,8387,8393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8336 | oej | 2006-01-20 09:32:30 -0500 (Fri, 20 Jan 2006) | 4 lines

- Add DOC file about caller ID presentation values
- Add callingpres to sip.conf
- Add reference to README.callingpres from zapata.conf

................
r8338 | kpfleming | 2006-01-20 12:27:51 -0500 (Fri, 20 Jan 2006) | 2 lines

eliminate compiler warnings from recent const-ification

................
r8345 | mattf | 2006-01-20 13:17:46 -0500 (Fri, 20 Jan 2006) | 2 lines

Update config. Apprently default doesn't always work now.

................
r8346 | mattf | 2006-01-20 13:18:40 -0500 (Fri, 20 Jan 2006) | 2 lines

Change chan_alsa to default open the first sound card device

................
r8348 | russell | 2006-01-20 13:40:24 -0500 (Fri, 20 Jan 2006) | 10 lines

Merged revisions 8347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8347 | russell | 2006-01-20 13:34:42 -0500 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue ASTERISK-6142)

........

................
r8356 | russell | 2006-01-20 14:24:42 -0500 (Fri, 20 Jan 2006) | 11 lines

- move ast_strdupa from channel.h to utils.h
- attempt to log an error message if the __builtin_alloca inside of ast_strdupa
fails.
- document the fact that it is known and intended behavior for ast_strdupa to
cause Asterisk to crash if the alloca fails
- use __builtin_expect when checking for allocation failure in all of the
allocation wrappers

New Janitor Project! Anywhere that we check for a successful allocation after
a call to ast_strdupa is unnecessary and should be removed.

................
r8357 | mattf | 2006-01-20 16:36:33 -0500 (Fri, 20 Jan 2006) | 2 lines

Fix for formats so they give better output on failure conditions. (ASTERISK-5984)

................
r8359 | mattf | 2006-01-20 18:19:49 -0500 (Fri, 20 Jan 2006) | 2 lines

Fix comments in sip.conf (ASTERISK-5977)

................
r8360 | russell | 2006-01-20 18:23:00 -0500 (Fri, 20 Jan 2006) | 2 lines

formatting and doxygen fixes (issue ASTERISK-6140)

................
r8361 | mattf | 2006-01-20 18:28:37 -0500 (Fri, 20 Jan 2006) | 2 lines

fix for codec_gsm on ia64 (ASTERISK-6134)

................
r8362 | russell | 2006-01-20 19:42:25 -0500 (Fri, 20 Jan 2006) | 2 lines

remove some useless checks after calls to ast_strdupa

................
r8368 | russell | 2006-01-20 22:09:01 -0500 (Fri, 20 Jan 2006) | 2 lines

remove optimization where its benefits are negligible

................
r8370 | tilghman | 2006-01-21 00:05:45 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 6096 - callerid_parse cleanup

................
r8371 | tilghman | 2006-01-21 00:15:56 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 5515 - Devicestate and API documentation update

................
r8372 | tilghman | 2006-01-21 00:22:18 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 4872 - Make Asterisk paths available to AGIs via environmental variables

................
r8378 | russell | 2006-01-21 03:01:24 -0500 (Sat, 21 Jan 2006) | 2 lines

remove some useless checks of the result of ast_strdupa

................
r8379 | russell | 2006-01-21 03:13:12 -0500 (Sat, 21 Jan 2006) | 2 lines

remove lots of useless checks of the result of ast_strdupa

................
r8380 | russell | 2006-01-21 03:23:57 -0500 (Sat, 21 Jan 2006) | 2 lines

remove useless checks of the result of ast_strdupa

................
r8381 | russell | 2006-01-21 03:45:39 -0500 (Sat, 21 Jan 2006) | 2 lines

conversions to use allocation wrappers (issue ASTERISK-6117)

................
r8387 | russell | 2006-01-21 12:50:04 -0500 (Sat, 21 Jan 2006) | 3 lines

revert my pass through the tree to remove checks of the result of ast_strdupa
(revisions 8378 through 8381)

................
r8393 | russell | 2006-01-21 13:11:40 -0500 (Sat, 21 Jan 2006) | 3 lines

don't do the memcpy inside of ast_strdupa if we know that __builtin_alloca
was not successful

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8397
By: Digium Subversion (svnbot) 2008-01-15 16:20:37.000-0600

Repository: asterisk
Revision: 8399

_U team/russell/autoconf_and_menuselect/
U team/russell/autoconf_and_menuselect/apps/app_queue.c
U team/russell/autoconf_and_menuselect/callerid.c
U team/russell/autoconf_and_menuselect/codecs/codec_a_mu.c
U team/russell/autoconf_and_menuselect/codecs/codec_adpcm.c
U team/russell/autoconf_and_menuselect/codecs/codec_alaw.c
U team/russell/autoconf_and_menuselect/codecs/codec_g723_1.c
U team/russell/autoconf_and_menuselect/codecs/codec_g726.c
U team/russell/autoconf_and_menuselect/codecs/codec_gsm.c
U team/russell/autoconf_and_menuselect/codecs/codec_ilbc.c
U team/russell/autoconf_and_menuselect/codecs/codec_lpc10.c
U team/russell/autoconf_and_menuselect/codecs/codec_speex.c
U team/russell/autoconf_and_menuselect/codecs/codec_ulaw.c
U team/russell/autoconf_and_menuselect/codecs/gsm/Makefile
U team/russell/autoconf_and_menuselect/configs/alsa.conf.sample
U team/russell/autoconf_and_menuselect/configs/sip.conf.sample
U team/russell/autoconf_and_menuselect/configs/zapata.conf.sample
A team/russell/autoconf_and_menuselect/doc/README.callingpres
U team/russell/autoconf_and_menuselect/formats/format_pcm.c
U team/russell/autoconf_and_menuselect/formats/format_pcm_alaw.c
U team/russell/autoconf_and_menuselect/include/asterisk/channel.h
U team/russell/autoconf_and_menuselect/include/asterisk/utils.h
U team/russell/autoconf_and_menuselect/pbx.c
U team/russell/autoconf_and_menuselect/res/res_agi.c

------------------------------------------------------------------------
r8399 | russell | 2008-01-15 16:20:37 -0600 (Tue, 15 Jan 2008) | 131 lines

Merged revisions 8336,8338,8345-8346,8348,8356-8357,8359-8362,8368,8370-8372,8378-8381,8387,8393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8336 | oej | 2006-01-20 09:32:30 -0500 (Fri, 20 Jan 2006) | 4 lines

- Add DOC file about caller ID presentation values
- Add callingpres to sip.conf
- Add reference to README.callingpres from zapata.conf

................
r8338 | kpfleming | 2006-01-20 12:27:51 -0500 (Fri, 20 Jan 2006) | 2 lines

eliminate compiler warnings from recent const-ification

................
r8345 | mattf | 2006-01-20 13:17:46 -0500 (Fri, 20 Jan 2006) | 2 lines

Update config. Apprently default doesn't always work now.

................
r8346 | mattf | 2006-01-20 13:18:40 -0500 (Fri, 20 Jan 2006) | 2 lines

Change chan_alsa to default open the first sound card device

................
r8348 | russell | 2006-01-20 13:40:24 -0500 (Fri, 20 Jan 2006) | 10 lines

Merged revisions 8347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8347 | russell | 2006-01-20 13:34:42 -0500 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue ASTERISK-6142)

........

................
r8356 | russell | 2006-01-20 14:24:42 -0500 (Fri, 20 Jan 2006) | 11 lines

- move ast_strdupa from channel.h to utils.h
- attempt to log an error message if the __builtin_alloca inside of ast_strdupa
fails.
- document the fact that it is known and intended behavior for ast_strdupa to
cause Asterisk to crash if the alloca fails
- use __builtin_expect when checking for allocation failure in all of the
allocation wrappers

New Janitor Project! Anywhere that we check for a successful allocation after
a call to ast_strdupa is unnecessary and should be removed.

................
r8357 | mattf | 2006-01-20 16:36:33 -0500 (Fri, 20 Jan 2006) | 2 lines

Fix for formats so they give better output on failure conditions. (ASTERISK-5984)

................
r8359 | mattf | 2006-01-20 18:19:49 -0500 (Fri, 20 Jan 2006) | 2 lines

Fix comments in sip.conf (ASTERISK-5977)

................
r8360 | russell | 2006-01-20 18:23:00 -0500 (Fri, 20 Jan 2006) | 2 lines

formatting and doxygen fixes (issue ASTERISK-6140)

................
r8361 | mattf | 2006-01-20 18:28:37 -0500 (Fri, 20 Jan 2006) | 2 lines

fix for codec_gsm on ia64 (ASTERISK-6134)

................
r8362 | russell | 2006-01-20 19:42:25 -0500 (Fri, 20 Jan 2006) | 2 lines

remove some useless checks after calls to ast_strdupa

................
r8368 | russell | 2006-01-20 22:09:01 -0500 (Fri, 20 Jan 2006) | 2 lines

remove optimization where its benefits are negligible

................
r8370 | tilghman | 2006-01-21 00:05:45 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 6096 - callerid_parse cleanup

................
r8371 | tilghman | 2006-01-21 00:15:56 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 5515 - Devicestate and API documentation update

................
r8372 | tilghman | 2006-01-21 00:22:18 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 4872 - Make Asterisk paths available to AGIs via environmental variables

................
r8378 | russell | 2006-01-21 03:01:24 -0500 (Sat, 21 Jan 2006) | 2 lines

remove some useless checks of the result of ast_strdupa

................
r8379 | russell | 2006-01-21 03:13:12 -0500 (Sat, 21 Jan 2006) | 2 lines

remove lots of useless checks of the result of ast_strdupa

................
r8380 | russell | 2006-01-21 03:23:57 -0500 (Sat, 21 Jan 2006) | 2 lines

remove useless checks of the result of ast_strdupa

................
r8381 | russell | 2006-01-21 03:45:39 -0500 (Sat, 21 Jan 2006) | 2 lines

conversions to use allocation wrappers (issue ASTERISK-6117)

................
r8387 | russell | 2006-01-21 12:50:04 -0500 (Sat, 21 Jan 2006) | 3 lines

revert my pass through the tree to remove checks of the result of ast_strdupa
(revisions 8378 through 8381)

................
r8393 | russell | 2006-01-21 13:11:40 -0500 (Sat, 21 Jan 2006) | 3 lines

don't do the memcpy inside of ast_strdupa if we know that __builtin_alloca
was not successful

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8399
By: Digium Subversion (svnbot) 2008-01-15 16:20:54.000-0600

Repository: asterisk
Revision: 8416

_U team/murf/AEL2/
U team/murf/AEL2/apps/Makefile
U team/murf/AEL2/apps/app_authenticate.c
U team/murf/AEL2/apps/app_chanspy.c
U team/murf/AEL2/apps/app_curl.c
U team/murf/AEL2/apps/app_db.c
U team/murf/AEL2/apps/app_dial.c
U team/murf/AEL2/apps/app_dictate.c
U team/murf/AEL2/apps/app_directory.c
U team/murf/AEL2/apps/app_disa.c
U team/murf/AEL2/apps/app_exec.c
U team/murf/AEL2/apps/app_externalivr.c
U team/murf/AEL2/apps/app_festival.c
U team/murf/AEL2/apps/app_hasnewvoicemail.c
U team/murf/AEL2/apps/app_image.c
U team/murf/AEL2/apps/app_macro.c
U team/murf/AEL2/apps/app_meetme.c
U team/murf/AEL2/apps/app_mixmonitor.c
U team/murf/AEL2/apps/app_osplookup.c
U team/murf/AEL2/apps/app_page.c
U team/murf/AEL2/apps/app_playback.c
U team/murf/AEL2/apps/app_privacy.c
U team/murf/AEL2/apps/app_queue.c
U team/murf/AEL2/apps/app_random.c
U team/murf/AEL2/apps/app_read.c
U team/murf/AEL2/apps/app_readfile.c
U team/murf/AEL2/apps/app_record.c
U team/murf/AEL2/apps/app_sayunixtime.c
U team/murf/AEL2/apps/app_senddtmf.c
U team/murf/AEL2/apps/app_sendtext.c
U team/murf/AEL2/apps/app_setcallerid.c
U team/murf/AEL2/apps/app_skel.c
U team/murf/AEL2/apps/app_sql_postgres.c
U team/murf/AEL2/apps/app_stack.c
U team/murf/AEL2/apps/app_talkdetect.c
U team/murf/AEL2/apps/app_transfer.c
U team/murf/AEL2/apps/app_url.c
U team/murf/AEL2/apps/app_userevent.c
U team/murf/AEL2/apps/app_verbose.c
U team/murf/AEL2/apps/app_voicemail.c
U team/murf/AEL2/apps/app_while.c
U team/murf/AEL2/apps/app_zapras.c
U team/murf/AEL2/callerid.c
U team/murf/AEL2/channel.c
U team/murf/AEL2/channels/chan_agent.c
U team/murf/AEL2/channels/chan_iax2.c
U team/murf/AEL2/channels/chan_sip.c
U team/murf/AEL2/codecs/codec_a_mu.c
U team/murf/AEL2/codecs/codec_adpcm.c
U team/murf/AEL2/codecs/codec_alaw.c
U team/murf/AEL2/codecs/codec_g723_1.c
U team/murf/AEL2/codecs/codec_g726.c
U team/murf/AEL2/codecs/codec_gsm.c
U team/murf/AEL2/codecs/codec_ilbc.c
U team/murf/AEL2/codecs/codec_lpc10.c
U team/murf/AEL2/codecs/codec_speex.c
U team/murf/AEL2/codecs/codec_ulaw.c
U team/murf/AEL2/codecs/gsm/Makefile
U team/murf/AEL2/configs/alsa.conf.sample
U team/murf/AEL2/configs/sip.conf.sample
U team/murf/AEL2/configs/zapata.conf.sample
A team/murf/AEL2/doc/README.callingpres
U team/murf/AEL2/formats/format_pcm.c
U team/murf/AEL2/formats/format_pcm_alaw.c
U team/murf/AEL2/funcs/func_cdr.c
U team/murf/AEL2/funcs/func_cut.c
U team/murf/AEL2/funcs/func_logic.c
U team/murf/AEL2/funcs/func_math.c
U team/murf/AEL2/funcs/func_md5.c
U team/murf/AEL2/funcs/func_odbc.c
U team/murf/AEL2/funcs/func_rand.c
U team/murf/AEL2/funcs/func_strings.c
U team/murf/AEL2/include/asterisk/channel.h
U team/murf/AEL2/include/asterisk/utils.h
U team/murf/AEL2/pbx.c
U team/murf/AEL2/res/res_agi.c
U team/murf/AEL2/res/res_crypto.c
U team/murf/AEL2/res/res_features.c
U team/murf/AEL2/res/res_indications.c
U team/murf/AEL2/res/res_monitor.c
U team/murf/AEL2/res/res_musiconhold.c
U team/murf/AEL2/res/res_osp.c

------------------------------------------------------------------------
r8416 | murf | 2008-01-15 16:20:54 -0600 (Tue, 15 Jan 2008) | 186 lines

Merged revisions 8336,8338,8345-8346,8348,8356-8357,8359-8362,8368,8370-8372,8378-8381,8387,8393,8401-8404,8407-8411,8413 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8336 | oej | 2006-01-20 07:32:30 -0700 (Fri, 20 Jan 2006) | 4 lines

- Add DOC file about caller ID presentation values
- Add callingpres to sip.conf
- Add reference to README.callingpres from zapata.conf

................
r8338 | kpfleming | 2006-01-20 10:27:51 -0700 (Fri, 20 Jan 2006) | 2 lines

eliminate compiler warnings from recent const-ification

................
r8345 | mattf | 2006-01-20 11:17:46 -0700 (Fri, 20 Jan 2006) | 2 lines

Update config. Apprently default doesn't always work now.

................
r8346 | mattf | 2006-01-20 11:18:40 -0700 (Fri, 20 Jan 2006) | 2 lines

Change chan_alsa to default open the first sound card device

................
r8348 | russell | 2006-01-20 11:40:24 -0700 (Fri, 20 Jan 2006) | 10 lines

Merged revisions 8347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8347 | russell | 2006-01-20 13:34:42 -0500 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue ASTERISK-6142)

........

................
r8356 | russell | 2006-01-20 12:24:42 -0700 (Fri, 20 Jan 2006) | 11 lines

- move ast_strdupa from channel.h to utils.h
- attempt to log an error message if the __builtin_alloca inside of ast_strdupa
fails.
- document the fact that it is known and intended behavior for ast_strdupa to
cause Asterisk to crash if the alloca fails
- use __builtin_expect when checking for allocation failure in all of the
allocation wrappers

New Janitor Project! Anywhere that we check for a successful allocation after
a call to ast_strdupa is unnecessary and should be removed.

................
r8357 | mattf | 2006-01-20 14:36:33 -0700 (Fri, 20 Jan 2006) | 2 lines

Fix for formats so they give better output on failure conditions. (ASTERISK-5984)

................
r8359 | mattf | 2006-01-20 16:19:49 -0700 (Fri, 20 Jan 2006) | 2 lines

Fix comments in sip.conf (ASTERISK-5977)

................
r8360 | russell | 2006-01-20 16:23:00 -0700 (Fri, 20 Jan 2006) | 2 lines

formatting and doxygen fixes (issue ASTERISK-6140)

................
r8361 | mattf | 2006-01-20 16:28:37 -0700 (Fri, 20 Jan 2006) | 2 lines

fix for codec_gsm on ia64 (ASTERISK-6134)

................
r8362 | russell | 2006-01-20 17:42:25 -0700 (Fri, 20 Jan 2006) | 2 lines

remove some useless checks after calls to ast_strdupa

................
r8368 | russell | 2006-01-20 20:09:01 -0700 (Fri, 20 Jan 2006) | 2 lines

remove optimization where its benefits are negligible

................
r8370 | tilghman | 2006-01-20 22:05:45 -0700 (Fri, 20 Jan 2006) | 2 lines

Bug 6096 - callerid_parse cleanup

................
r8371 | tilghman | 2006-01-20 22:15:56 -0700 (Fri, 20 Jan 2006) | 2 lines

Bug 5515 - Devicestate and API documentation update

................
r8372 | tilghman | 2006-01-20 22:22:18 -0700 (Fri, 20 Jan 2006) | 2 lines

Bug 4872 - Make Asterisk paths available to AGIs via environmental variables

................
r8378 | russell | 2006-01-21 01:01:24 -0700 (Sat, 21 Jan 2006) | 2 lines

remove some useless checks of the result of ast_strdupa

................
r8379 | russell | 2006-01-21 01:13:12 -0700 (Sat, 21 Jan 2006) | 2 lines

remove lots of useless checks of the result of ast_strdupa

................
r8380 | russell | 2006-01-21 01:23:57 -0700 (Sat, 21 Jan 2006) | 2 lines

remove useless checks of the result of ast_strdupa

................
r8381 | russell | 2006-01-21 01:45:39 -0700 (Sat, 21 Jan 2006) | 2 lines

conversions to use allocation wrappers (issue ASTERISK-6117)

................
r8387 | russell | 2006-01-21 10:50:04 -0700 (Sat, 21 Jan 2006) | 3 lines

revert my pass through the tree to remove checks of the result of ast_strdupa
(revisions 8378 through 8381)

................
r8393 | russell | 2006-01-21 11:11:40 -0700 (Sat, 21 Jan 2006) | 3 lines

don't do the memcpy inside of ast_strdupa if we know that __builtin_alloca
was not successful

................
r8401 | russell | 2006-01-21 13:20:06 -0700 (Sat, 21 Jan 2006) | 3 lines

finish reverting my pass through the tree to remove checks of the result of
ast_strdupa, this one is revision 8362

................
r8402 | tilghman | 2006-01-21 13:32:17 -0700 (Sat, 21 Jan 2006) | 2 lines

Bug 5936 - Cannot AddQueueMember on realtime queue, if queue not yet loaded (different fix than 1.2)

................
r8403 | russell | 2006-01-21 13:57:06 -0700 (Sat, 21 Jan 2006) | 2 lines

on this pass, only remove duplicate log messages

................
r8404 | russell | 2006-01-21 13:58:57 -0700 (Sat, 21 Jan 2006) | 1 line

................
r8407 | russell | 2006-01-21 14:29:06 -0700 (Sat, 21 Jan 2006) | 2 lines

clean up formatting to conform to coding guidelines and fix some typos (issue ASTERISK-6101)

................
r8408 | russell | 2006-01-21 14:50:09 -0700 (Sat, 21 Jan 2006) | 5 lines

- conversion to allocation wrappers
- get rid of some compiler warnings due to usused variables and const-ification
- remove some unnecessary uses of malloc/strncpy/free and replace with ast_strdupa
(based on the patch from issue ASTERISK-6115)

................
r8409 | russell | 2006-01-21 14:57:01 -0700 (Sat, 21 Jan 2006) | 2 lines

oops, don't build app_sql_postgres by default ...

................
r8410 | russell | 2006-01-21 15:09:06 -0700 (Sat, 21 Jan 2006) | 5 lines

- conversions to allocation wrappers
- replace malloc/memset with ast_calloc
- replace malloc/ast_copy_string with ast_strdup
(based on patch from issue ASTERISK-6139)

................
r8411 | russell | 2006-01-21 16:05:19 -0700 (Sat, 21 Jan 2006) | 2 lines

const-ify some fields in the ast_exten and ast_include structures (issue ASTERISK-6110)

................
r8413 | russell | 2006-01-21 16:17:52 -0700 (Sat, 21 Jan 2006) | 1 line

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8416