Summary: | ASTERISK-05979: [patch] zombie conference when hanging-up on PIN entry | ||
Reporter: | gkloepfer (gkloepfer) | Labels: | |
Date Opened: | 2006-01-04 12:29:43.000-0600 | Date Closed: | 2006-01-18 14:13:05.000-0600 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_meetme |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) getpin-bugfix | |
Description: | When creating a dynamic conference with PIN, if the admin hangs-up on the PIN entry, the conference is created anyway with a null PIN and holds-open the SIP channel. flanders*CLI> -- Recording Jan 4 12:29:03 WARNING[25278]: file.c:583 ast_readaudio_callback: Failed to write frame Jan 4 12:29:03 WARNING[25278]: file.c:583 ast_readaudio_callback: Failed to write frame flanders*CLI> meetme Conf Num Parties Marked Activity Creation 1234 0001 N/A 00:00:03 Dynamic * Total number of MeetMe users: 1 flanders*CLI> meetme list 1234 User #: 01 3771 Gil Kloepfer Channel: SIP/3771-c1b0 (Admin) (unmonitored) 1 users in that conference. The channel is never closed and the conference never goes away. ****** ADDITIONAL INFORMATION ****** The dialplan entry looks like the following: '658' => 1. Answer() [pbx_config] 2. MeetMe(1234|aDiMs) [pbx_config] 3. Hangup() [pbx_config] To reproduce, dial extension "658" and hang-up when asked for the PIN. The bugfix attached checks the previously unchecked error condition from ast_app_getdata() and returns a null ("unfound") conference if ast_app_getdata() returns an error (typically because of a channel error). | ||
Comments: | By: Matt O'Gorman (mogorman) 2006-01-18 10:07:26.000-0600 gkloepfer I was unable to replicate this on the current svn trunk and the latest 1.2 branch is this still a problem for you? By: gkloepfer (gkloepfer) 2006-01-18 11:59:48.000-0600 mogorman: please confirm that you have tried the diaplan code defined in the "additional information" with the same MeetMe options and that hanging-up when being asked for the PIN on a SIP phone *does not* leave that MeetMe admin user as shown above. Since I'm not running the latest 1.2 branch yet, it will require compiling that version and testing. I absolutely don't mind doing that as long as you're sure you are not experiencing the same problem. The error return condition in the patch I include is still not checked in rev. 8045 of app_meetme.c, so the same condition should exist in the lates SVN as was in the earlier rev. Thanks! By: gkloepfer (gkloepfer) 2006-01-18 12:14:43.000-0600 mogorman: Confirmed, it is still broken as of trunk/8191 (I decided to test it anyway). Here is more information: Phone: Polycom IP601 sip.conf info: [5460] type=friend secret=notreallysecret host=dynamic canreinvite=no callerid=Gil Kloepfer/Test <5460> context=OrigInternal-Staff extensions.conf info: exten => 658,1,Answer exten => 658,n,MeetMe(1234,aDiMs) exten => 658,n,Hangup relevant stuff from console trace: -- Executing Answer("SIP/5460-f1a9", "") in new stack -- Executing MeetMe("SIP/5460-f1a9", "1234|aDiMs") in new stack -- Playing 'conf-getpin' (language 'en') -- Created MeetMe conference 1023 for conference '1234' -- Recording Jan 18 13:10:25 WARNING[18345]: file.c:584 ast_readaudio_callback: Failed to write frame -- Playing 'vm-rec-name' (language 'en') Jan 18 13:10:25 WARNING[18345]: file.c:584 ast_readaudio_callback: Failed to write frame -- Playing 'conf-onlyperson' (language 'en') bart*CLI> meetme list 1234 User #: 01 5460 Gil Kloepfer/Test Channel: SIP/5460-f1a9 (Admin) (unmonitored) 1 users in that conference. By: Matt O'Gorman (mogorman) 2006-01-18 14:12:45.000-0600 commited into trunk and 1.2 8195 and 8194 |