| Summary: | ASTERISK-05968: fix pri intense debug messages | ||
| Reporter: | deti (deti) | Labels: | |
| Date Opened: | 2006-01-03 17:04:04.000-0600 | Date Closed: | 2008-01-15 16:11:27.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_zap |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) chan_zap-fix-pri-debug.patch | |
| Description: | This little patch fixes the missing carriage returns of a pri intense debug messages. ****** ADDITIONAL INFORMATION ****** Originally such messages look like this: Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8008 zt_pri_message: < [Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8008 zt_pri_message: 28Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8008 zt_pri_message: 05Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8008 zt_pri_message: 32Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8008 zt_pri_message: 37Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8008 zt_pri_message: 38Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8008 zt_pri_message: 36Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8008 zt_pri_message: 38Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8008 zt_pri_message: ] Jan 4 00:56:50 DEBUG[15919]: chan_zap.c:8004 zt_pri_message: < Display (len= 5) [ 27868 ] Now they look like that: < [28 05 32 37 38 36 38] < Display (len= 5) [ 27868 ] IMHO more readable... | ||
| Comments: | By: Clod Patry (junky) 2006-01-03 19:25:57.000-0600 Why not just add a \n at the end? you'll be flooded of verbose in that way or at least, make a condition with option_verbose. By: deti (deti) 2006-01-03 19:45:32.000-0600 You can't simply add a \n because the end of each line is reached after a couple of zt_pri_message calls originated in libpri's q931 code. IMHO conditionals do not make sense as you can select the debug level of pri messages by 'pri debug ...' or 'pri intense debug ...' - to switch off pri debugging simply call 'pri no debug ...' - or did I miss something? If anyone wants to have the problem fixed in another way - feel free to attach your patch :) By: Matthew Fredrickson (mattf) 2006-01-04 07:44:07.000-0600 This is probably right. I think I changed them a couple of months ago, not realizing the differences between LOG_DEBUG and ast_verbose in the way they output. By: Matthew Fredrickson (mattf) 2006-01-04 08:04:27.000-0600 Committed By: Digium Subversion (svnbot) 2008-01-15 16:11:23.000-0600 Repository: asterisk Revision: 7786 U trunk/channels/chan_zap.c ------------------------------------------------------------------------ r7786 | mattf | 2008-01-15 16:11:23 -0600 (Tue, 15 Jan 2008) | 2 lines Fixes for bug ASTERISK-5968 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7786 By: Digium Subversion (svnbot) 2008-01-15 16:11:25.000-0600 Repository: asterisk Revision: 7787 _U team/oej/multiparking/ U team/oej/multiparking/UPGRADE.txt U team/oej/multiparking/apps/app_chanspy.c U team/oej/multiparking/apps/app_disa.c U team/oej/multiparking/apps/app_mixmonitor.c U team/oej/multiparking/apps/app_privacy.c U team/oej/multiparking/apps/app_stack.c D team/oej/multiparking/ast_expr.y U team/oej/multiparking/ast_expr2.fl U team/oej/multiparking/ast_expr2f.c U team/oej/multiparking/autoservice.c U team/oej/multiparking/cdr.c U team/oej/multiparking/channel.c U team/oej/multiparking/channels/chan_iax2.c U team/oej/multiparking/channels/chan_sip.c U team/oej/multiparking/channels/chan_zap.c U team/oej/multiparking/configs/manager.conf.sample U team/oej/multiparking/configs/sip.conf.sample U team/oej/multiparking/contrib/scripts/managerproxy.pl A team/oej/multiparking/contrib/scripts/safe_asterisk_restart U team/oej/multiparking/file.c U team/oej/multiparking/funcs/func_moh.c U team/oej/multiparking/image.c U team/oej/multiparking/include/asterisk/chanspy.h U team/oej/multiparking/include/asterisk/image.h U team/oej/multiparking/include/asterisk/rtp.h U team/oej/multiparking/manager.c U team/oej/multiparking/pbx.c U team/oej/multiparking/res/res_osp.c U team/oej/multiparking/rtp.c ------------------------------------------------------------------------ r7787 | oej | 2008-01-15 16:11:24 -0600 (Tue, 15 Jan 2008) | 186 lines Merged revisions 7725,7728-7734,7737,7739,7741,7744-7745,7747-7748,7750-7751,7770,7774-7779,7783-7786 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7725 | russell | 2006-01-03 00:52:33 +0100 (Tue, 03 Jan 2006) | 2 lines initialize sip_auth list ................ r7728 | oej | 2006-01-03 09:40:55 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5960: Clean up list handling in image.c (drumkilla) ................ r7729 | oej | 2006-01-03 09:54:19 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5958: Use list macros in autoservice.c (drumkilla) ................ r7730 | oej | 2006-01-03 10:30:19 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5951: Fix unprotected list in RTP, implement AST_LIST macros, update doxygen docs ................ r7731 | oej | 2006-01-03 12:21:48 +0100 (Tue, 03 Jan 2006) | 2 lines Bug 5345; Add configuration option for minimum registration time. (folsson) ................ r7732 | oej | 2006-01-03 12:31:56 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5088: Add caller ID and CallerIDname to OriginateSuccess/Failure manager events (outtolunc) ................ r7733 | oej | 2006-01-03 12:58:10 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5913: Broken rport match in check_via(). (rizzo) ................ r7734 | oej | 2006-01-03 13:25:32 +0100 (Tue, 03 Jan 2006) | 2 lines Issue ASTERISK-5799: Implement printf-like append_history and implement AST_LIST for SIP history (rizzo) ................ r7737 | kpfleming | 2006-01-03 17:39:37 +0100 (Tue, 03 Jan 2006) | 10 lines Merged revisions 7736 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7736 | kpfleming | 2006-01-03 10:34:12 -0600 (Tue, 03 Jan 2006) | 2 lines don't leak memory for (most) expression evaluations ........ ................ r7739 | kpfleming | 2006-01-03 18:08:35 +0100 (Tue, 03 Jan 2006) | 3 lines fix breakage from rev 7730 (failure to unlock list in get_proto) minor cleanups and simpler usage of list macros ................ r7741 | kpfleming | 2006-01-03 18:25:39 +0100 (Tue, 03 Jan 2006) | 12 lines Merged revisions 7740 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7740 | kpfleming | 2006-01-03 11:24:56 -0600 (Tue, 03 Jan 2006) | 4 lines revert incorrect fix for bug ASTERISK-5890 from revision 7709 put in correct (simpler) fix add doxygen docs for channel spy 'state' values ........ ................ r7744 | tilghman | 2006-01-03 19:17:42 +0100 (Tue, 03 Jan 2006) | 3 lines Merged revisions 7743 via svnmerge from /branches/1.2 ................ r7745 | oej | 2006-01-03 20:12:50 +0100 (Tue, 03 Jan 2006) | 2 lines Don't check user call limits for outbound calls. ................ r7747 | kpfleming | 2006-01-03 21:23:23 +0100 (Tue, 03 Jan 2006) | 10 lines Merged revisions 7746 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7746 | kpfleming | 2006-01-03 14:22:18 -0600 (Tue, 03 Jan 2006) | 2 lines remove unused 'old' expression parser ........ ................ r7748 | kpfleming | 2006-01-03 21:33:28 +0100 (Tue, 03 Jan 2006) | 2 lines add script for simple 'no-brainer' restarts of safe_asterisk (issue ASTERISK-5004) ................ r7750 | kpfleming | 2006-01-03 23:07:12 +0100 (Tue, 03 Jan 2006) | 2 lines add optional timestamps to manager events (issue ASTERISK-5387, simplified) ................ r7751 | kpfleming | 2006-01-03 23:16:23 +0100 (Tue, 03 Jan 2006) | 2 lines update copyright headers for files changed this year ................ r7770 | bweschke | 2006-01-04 06:26:03 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ................ r7774 | russell | 2006-01-04 08:08:08 +0100 (Wed, 04 Jan 2006) | 10 lines Merged revisions 7773 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7773 | russell | 2006-01-04 02:06:50 -0500 (Wed, 04 Jan 2006) | 2 lines use a more correct way of determining the size of the destination buffer ........ ................ r7775 | oej | 2006-01-04 10:10:56 +0100 (Wed, 04 Jan 2006) | 6 lines - Remove "incominglimit" as a configuration option in sip.conf - Add documentation on call-limit, explaining that there's two counters for a type="friend". - Document the removval of "incominglimit" in UPGRADE.txt ................ r7776 | oej | 2006-01-04 10:22:45 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5970: Count in show channeltypes (junky) ................ r7777 | oej | 2006-01-04 11:16:53 +0100 (Wed, 04 Jan 2006) | 2 lines Missing ">" in XML. Thanks, fenlander, for reporting this on IRC. ................ r7778 | russell | 2006-01-04 13:11:11 +0100 (Wed, 04 Jan 2006) | 2 lines doxygen tweak ................ r7779 | oej | 2006-01-04 13:16:30 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5797: Add destination protocol information to res_osp (homesick) ................ r7783 | oej | 2006-01-04 14:07:34 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5673: Adding more SIP to ISDN Cause code conversions. Thanks mguesdon! ................ r7784 | oej | 2006-01-04 14:49:25 +0100 (Wed, 04 Jan 2006) | 2 lines Whitespace and formatting changes. /Housekeeping ................ r7785 | oej | 2006-01-04 14:56:11 +0100 (Wed, 04 Jan 2006) | 2 lines Small typo fix ................ r7786 | mattf | 2006-01-04 15:46:41 +0100 (Wed, 04 Jan 2006) | 2 lines Fixes for bug ASTERISK-5968 ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7787 By: Digium Subversion (svnbot) 2008-01-15 16:11:27.000-0600 Repository: asterisk Revision: 7788 _U team/oej/aum-trunk/ U team/oej/aum-trunk/apps/app_disa.c U team/oej/aum-trunk/channels/chan_sip.c U team/oej/aum-trunk/channels/chan_zap.c U team/oej/aum-trunk/contrib/scripts/managerproxy.pl ------------------------------------------------------------------------ r7788 | oej | 2008-01-15 16:11:26 -0600 (Tue, 15 Jan 2008) | 27 lines Staying up to date... Merged revisions 7783-7786 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r7783 | oej | 2006-01-04 14:07:34 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5673: Adding more SIP to ISDN Cause code conversions. Thanks mguesdon! ........ r7784 | oej | 2006-01-04 14:49:25 +0100 (Wed, 04 Jan 2006) | 2 lines Whitespace and formatting changes. /Housekeeping ........ r7785 | oej | 2006-01-04 14:56:11 +0100 (Wed, 04 Jan 2006) | 2 lines Small typo fix ........ r7786 | mattf | 2006-01-04 15:46:41 +0100 (Wed, 04 Jan 2006) | 2 lines Fixes for bug ASTERISK-5968 ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7788 | ||