[Home]

Summary:ASTERISK-05967: [patch] Add Abandon Queue Manager Event
Reporter:Tim Ringenbach at Asteria Solutions Group (tim_ringenbach)Labels:
Date Opened:2006-02-10 07:40:13.000-0600Date Closed:2008-01-15 17:21:51.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) abandon_event.diff
Description:This patch adds an asterisk manager abandon event. Currently this information is available through the queue log but not through the manager.
Comments:By: Olle Johansson (oej) 2006-02-13 03:44:40.000-0600

There's another change in this patch as well. Please explain!

-------
/* Musta gotten hung up */
- record_abandoned(qe);
+ /* Don't record this here, we record it somewhere else too */
+ /* record_abandoned(qe); */
res = -1;
By: BJ Weschke (bweschke) 2006-02-13 21:06:22.000-0600

oej: tim_ringenbach is right with the additional patch (but it is a diff issue). when inside of that block where this is now commented out, try_calling(..) is then going to return -1 which will, in effect, call record_abandoned(..) within queue_exec after the return of try_calling(..) is examined. With how it is now in /trunk, we are probably logging the abandoned call in this case twice.

tim_ringenbach: there's no need to comment out that behavior. we should probably remove it completely from the function.
By: Tim Ringenbach at Asteria Solutions Group (tim_ringenbach) 2006-02-14 14:55:49.000-0600

Oops, I forgot about that.
Yeah, I commented that out because I was getting duplicates. I commented it out because I was just new to the code and didn't feel comfortabling deleting things.
If you want I can delete it and supply a new patch.
By: Serge Vecher (serge-v) 2006-02-14 15:18:22.000-0600

tim_ringenbach: kpfleming has already committed this part of patch in question to trunk earlier http://lists.digium.com/pipermail/svn-commits/2006-February/010734.html
By: Olle Johansson (oej) 2006-03-09 14:49:21.000-0600

Added to test-this-branch :-)
By: Tilghman Lesher (tilghman) 2006-03-11 09:18:38.000-0600

Committed to trunk, revision 12501
By: Digium Subversion (svnbot) 2008-01-15 17:21:51.000-0600

Repository: asterisk
Revision: 12482

U   team/oej/test-this-branch/README.test-this-branch
U   team/oej/test-this-branch/apps/app_queue.c

------------------------------------------------------------------------
r12482 | oej | 2008-01-15 17:21:50 -0600 (Tue, 15 Jan 2008) | 2 lines

Issue ASTERISK-5967 - Abandon Queue manager event (tim_ringenbach)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=12482