Summary:ASTERISK-05964: [patch] Add StopMixMonitor() application and CLI completion to mixmonitor
Reporter:jcomellas (jcomellas)Labels:
Date Opened:2006-01-03 14:51:33.000-0600Date Closed:2008-01-15 16:50:00.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_mixmonitor_stopmixmonitor_2.patch
( 1) app_mixmonitor_stopmixmonitor.patch
Description:Added the StopMixMonitor() application to stop a MixMonitor that is running on a channel. The application does not receive any argument and it is equivalent to doing 'mixmonitor stop <channel_name>' from the CLI on the current channel.

The patch also adds command and channel name completion to the mixmonitor command.
Comments:By: Russell Bryant (russell) 2006-01-10 23:29:05.000-0600

1) It appears that you are using spaces instead of tabs

2) braces should not be placed on their own line, except for a function.
       if (foo) {
       if (foo)

3) In your completion function, you can store the result from strlen(word) so that it only has to be calculated a single time in that function.

Please review doc/CODING-GUIDELINES for more information on our standards for formatting, among other things.


By: jcomellas (jcomellas) 2006-01-12 16:21:49.000-0600

The 3 issues you named in your comment should be corrected by the patch file 'app_mixmonitor_stopmixmonitor_2.patch'. Please let me know if there is any other problem and I will correct it.

By: jcomellas (jcomellas) 2006-02-16 06:59:38.000-0600

Is there any chance that this patch will ever make it into Asterisk? It should be trivial to apply and all the changes that were requested have been completed over a month ago.

By: Russell Bryant (russell) 2006-02-16 10:38:36.000-0600

Added to the trunk in revision 10287 with some modifications.  Most notably, the modifications include taking the channel completion function that already existed in cli.c and making it available for use in other modules that want to complete from the channel list.


By: Digium Subversion (svnbot) 2008-01-15 16:50:00.000-0600

Repository: asterisk
Revision: 10287

U   trunk/apps/app_mixmonitor.c
U   trunk/cli.c
U   trunk/include/asterisk/cli.h

r10287 | russell | 2008-01-15 16:50:00 -0600 (Tue, 15 Jan 2008) | 4 lines

add StopMixMonitor application (issue ASTERISK-5964, with mods)
Rename and export ast_complete_channels for use by cli completion functions
that want to complete from the list of active channels