[Home]

Summary:ASTERISK-05957: [patch] Clean up source of chan_agent.c
Reporter:Olle Johansson (oej)Labels:
Date Opened:2006-01-02 14:20:14.000-0600Date Closed:2006-03-03 02:40:54.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_agent
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) agentcleanup.txt
Description:- Cleans up source code of chan_agent and adds doxygen docs
- Changes existing doxygen docs from javadoc formatting
Comments:By: Russell Bryant (russell) 2006-01-02 17:13:33.000-0600

Please review your changes to agent_sendhtml.  They are not correct.


By: Olle Johansson (oej) 2006-01-03 00:39:40.000-0600

Ok, will do. THanks for taking time to review this.
By: Olle Johansson (oej) 2006-01-03 01:32:48.000-0600

Updated version uploaded.
By: Peng Yong (ppyy) 2006-01-03 06:06:39.000-0600

patch to your patch, still in agent_sendhtml:

--- channels/chan_agent.c       2006-01-03 21:04:28.257124629 +0800
+++ /tmp/chan_agent.c   2006-01-03 21:04:13.052853844 +0800
@@ -567,11 +567,10 @@
static int agent_sendhtml(struct ast_channel *ast, int subclass, const char *data, int datalen)
{
       struct agent_pvt *p = ast->tech_pvt;
-       int res;
+       int res = -1;

       if (!p->chan)
-               return 0;
-
+               return res;
       ast_mutex_lock(&p->lock);
       res = ast_channel_sendhtml(p->chan, subclass, data, datalen);
       ast_mutex_unlock(&p->lock);
By: Olle Johansson (oej) 2006-02-02 01:30:48.000-0600

OEJ: Reminder to update this stuff.

/Bug marshal