Summary: | ASTERISK-05954: [patch] small locking bug and list macro conversion | ||
Reporter: | Russell Bryant (russell) | Labels: | |
Date Opened: | 2006-01-02 12:53:19.000-0600 | Date Closed: | 2008-01-15 16:16:24.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) file_list.patch | |
Description: | In the function file.c::ast_format_unregister, the lock for the format list is not unlocked in the event that format requested to be unregistered is not present in the list. Of course, this should never actually happen, but it's still a minor bug in the code. This patch fixes the above issue as well as converting the format list to use the linked list macros. | ||
Comments: | By: Olle Johansson (oej) 2006-01-09 14:31:11.000-0600 Committed to svn trunk, revision 7912. Thanks! By: Olle Johansson (oej) 2006-01-09 14:32:47.000-0600 Drumkilla: If the bug exists in 1.2, please submit a patch without the list macro conversion or, well, since it's you, a patch that you approve for 1.2 :-) Otherwise, please close this issue. By: Russell Bryant (russell) 2006-01-09 15:07:31.000-0600 The locking bug has been fixed in the 1.2 branch - rev 7915 :) By: Digium Subversion (svnbot) 2008-01-15 16:13:14.000-0600 Repository: asterisk Revision: 7915 U branches/1.2/file.c ------------------------------------------------------------------------ r7915 | russell | 2008-01-15 16:13:14 -0600 (Tue, 15 Jan 2008) | 2 lines add missing unlock (issue ASTERISK-5954) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7915 By: Digium Subversion (svnbot) 2008-01-15 16:13:36.000-0600 Repository: asterisk Revision: 7938 _U team/oej/managerstuff/ U team/oej/managerstuff/apps/app_voicemail.c U team/oej/managerstuff/channels/chan_iax2.c U team/oej/managerstuff/channels/chan_sip.c A team/oej/managerstuff/channels/misdn/mISDN.patch A team/oej/managerstuff/channels/misdn/mISDNuser.patch U team/oej/managerstuff/doc/README.variables U team/oej/managerstuff/file.c U team/oej/managerstuff/pbx/pbx_spool.c ------------------------------------------------------------------------ r7938 | oej | 2008-01-15 16:13:35 -0600 (Tue, 15 Jan 2008) | 155 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812,7870-7871,7898-7900,7904,7908,7915,7917 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Thu, 15 Dec 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sat, 17 Dec 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Tue, 20 Dec 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Tue, 20 Dec 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Wed, 21 Dec 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Wed, 21 Dec 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Thu, 22 Dec 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fri, 23 Dec 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mon, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Tue, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Wed, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Thu, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mon, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mon, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7904 | tilghman | 2006-01-09 19:37:50 +0100 (Mon, 09 Jan 2006) | 2 lines Update variable documentation to match the code ........ r7908 | tilghman | 2006-01-09 21:08:24 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6157 - Memory leak ........ r7915 | russell | 2006-01-09 23:07:26 +0100 (Mon, 09 Jan 2006) | 2 lines add missing unlock (issue ASTERISK-5954) ........ r7917 | kpfleming | 2006-01-09 23:48:48 +0100 (Mon, 09 Jan 2006) | 2 lines re-initialize _all_ sequence numbers when transfer completes ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7938 By: Digium Subversion (svnbot) 2008-01-15 16:16:13.000-0600 Repository: asterisk Revision: 8109 _U team/oej/metermaids/ U team/oej/metermaids/app.c U team/oej/metermaids/apps/app_dial.c U team/oej/metermaids/apps/app_voicemail.c U team/oej/metermaids/channel.c U team/oej/metermaids/channels/chan_agent.c U team/oej/metermaids/channels/chan_iax2.c U team/oej/metermaids/channels/chan_sip.c U team/oej/metermaids/configs/voicemail.conf.sample U team/oej/metermaids/doc/README.cdr U team/oej/metermaids/file.c U team/oej/metermaids/funcs/func_strings.c U team/oej/metermaids/pbx.c U team/oej/metermaids/translate.c ------------------------------------------------------------------------ r8109 | oej | 2008-01-15 16:16:13 -0600 (Tue, 15 Jan 2008) | 82 lines Merged revisions 7915,7917,7939,7955,7957,7960,7963,7965,7970,7972,7976,7986,7999,8047,8074 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7915 | russell | 2006-01-09 23:07:26 +0100 (Mon, 09 Jan 2006) | 2 lines add missing unlock (issue ASTERISK-5954) ........ r7917 | kpfleming | 2006-01-09 23:48:48 +0100 (Mon, 09 Jan 2006) | 2 lines re-initialize _all_ sequence numbers when transfer completes ........ r7939 | oej | 2006-01-10 09:48:14 +0100 (Tue, 10 Jan 2006) | 3 lines - Adding reference to README.tds - Reformatting table ........ r7955 | tilghman | 2006-01-11 02:30:10 +0100 (Wed, 11 Jan 2006) | 2 lines Bug 6192 - behave correctly when mailbox is specified as argument ........ r7957 | russell | 2006-01-11 04:12:44 +0100 (Wed, 11 Jan 2006) | 2 lines fix a little typo ........ r7960 | russell | 2006-01-11 05:19:21 +0100 (Wed, 11 Jan 2006) | 2 lines fix locking error - lock instead of unlock ........ r7963 | mogorman | 2006-01-11 05:38:07 +0100 (Wed, 11 Jan 2006) | 2 lines Minor typo refrenced in 6191 ........ r7965 | russell | 2006-01-11 05:53:24 +0100 (Wed, 11 Jan 2006) | 2 lines lock list of translators *before* recalculating the translation matrix ........ r7970 | russell | 2006-01-11 06:26:21 +0100 (Wed, 11 Jan 2006) | 3 lines don't override an error condition that occurred when acting on the primary channel when stopping the autoservice on the peer channel. (from issue ASTERISK-5929) ........ r7972 | russell | 2006-01-11 06:46:39 +0100 (Wed, 11 Jan 2006) | 2 lines fix mem leak on module unload (issue ASTERISK-6033) ........ r7976 | russell | 2006-01-11 08:18:16 +0100 (Wed, 11 Jan 2006) | 2 lines fix temp greetings with ODBC storage (issue ASTERISK-5920) ........ r7986 | russell | 2006-01-11 20:08:53 +0100 (Wed, 11 Jan 2006) | 2 lines move variable to correct scope (issue ASTERISK-6040) ........ r7999 | tilghman | 2006-01-12 07:14:22 +0100 (Thu, 12 Jan 2006) | 2 lines Bug 6211 - Add option deletevoicemail as equivalent to option delete for Realtime ........ r8047 | russell | 2006-01-13 07:07:39 +0100 (Fri, 13 Jan 2006) | 2 lines fix spelling errors (issue ASTERISK-6069) ........ r8074 | tilghman | 2006-01-14 20:06:44 +0100 (Sat, 14 Jan 2006) | 2 lines Bug 6238 - Fix segfault when delimiter not specified ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8109 By: Digium Subversion (svnbot) 2008-01-15 16:16:24.000-0600 Repository: asterisk Revision: 8119 _U team/oej/moduletest/ U team/oej/moduletest/app.c U team/oej/moduletest/apps/app_dial.c U team/oej/moduletest/apps/app_voicemail.c U team/oej/moduletest/asterisk.c U team/oej/moduletest/channel.c U team/oej/moduletest/channels/chan_agent.c U team/oej/moduletest/channels/chan_iax2.c U team/oej/moduletest/channels/chan_sip.c U team/oej/moduletest/configs/voicemail.conf.sample U team/oej/moduletest/db.c U team/oej/moduletest/doc/README.cdr U team/oej/moduletest/doc/README.variables U team/oej/moduletest/file.c U team/oej/moduletest/funcs/func_strings.c U team/oej/moduletest/pbx/pbx_spool.c U team/oej/moduletest/pbx.c U team/oej/moduletest/translate.c ------------------------------------------------------------------------ r8119 | oej | 2008-01-15 16:16:24 -0600 (Tue, 15 Jan 2008) | 112 lines Merged revisions 7898-7900,7904,7908,7915,7917,7939,7955,7957,7960,7963,7965,7970,7972,7976,7986,7999,8047,8074,8112 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mon, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7904 | tilghman | 2006-01-09 19:37:50 +0100 (Mon, 09 Jan 2006) | 2 lines Update variable documentation to match the code ........ r7908 | tilghman | 2006-01-09 21:08:24 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6157 - Memory leak ........ r7915 | russell | 2006-01-09 23:07:26 +0100 (Mon, 09 Jan 2006) | 2 lines add missing unlock (issue ASTERISK-5954) ........ r7917 | kpfleming | 2006-01-09 23:48:48 +0100 (Mon, 09 Jan 2006) | 2 lines re-initialize _all_ sequence numbers when transfer completes ........ r7939 | oej | 2006-01-10 09:48:14 +0100 (Tue, 10 Jan 2006) | 3 lines - Adding reference to README.tds - Reformatting table ........ r7955 | tilghman | 2006-01-11 02:30:10 +0100 (Wed, 11 Jan 2006) | 2 lines Bug 6192 - behave correctly when mailbox is specified as argument ........ r7957 | russell | 2006-01-11 04:12:44 +0100 (Wed, 11 Jan 2006) | 2 lines fix a little typo ........ r7960 | russell | 2006-01-11 05:19:21 +0100 (Wed, 11 Jan 2006) | 2 lines fix locking error - lock instead of unlock ........ r7963 | mogorman | 2006-01-11 05:38:07 +0100 (Wed, 11 Jan 2006) | 2 lines Minor typo refrenced in 6191 ........ r7965 | russell | 2006-01-11 05:53:24 +0100 (Wed, 11 Jan 2006) | 2 lines lock list of translators *before* recalculating the translation matrix ........ r7970 | russell | 2006-01-11 06:26:21 +0100 (Wed, 11 Jan 2006) | 3 lines don't override an error condition that occurred when acting on the primary channel when stopping the autoservice on the peer channel. (from issue ASTERISK-5929) ........ r7972 | russell | 2006-01-11 06:46:39 +0100 (Wed, 11 Jan 2006) | 2 lines fix mem leak on module unload (issue ASTERISK-6033) ........ r7976 | russell | 2006-01-11 08:18:16 +0100 (Wed, 11 Jan 2006) | 2 lines fix temp greetings with ODBC storage (issue ASTERISK-5920) ........ r7986 | russell | 2006-01-11 20:08:53 +0100 (Wed, 11 Jan 2006) | 2 lines move variable to correct scope (issue ASTERISK-6040) ........ r7999 | tilghman | 2006-01-12 07:14:22 +0100 (Thu, 12 Jan 2006) | 2 lines Bug 6211 - Add option deletevoicemail as equivalent to option delete for Realtime ........ r8047 | russell | 2006-01-13 07:07:39 +0100 (Fri, 13 Jan 2006) | 2 lines fix spelling errors (issue ASTERISK-6069) ........ r8074 | tilghman | 2006-01-14 20:06:44 +0100 (Sat, 14 Jan 2006) | 2 lines Bug 6238 - Fix segfault when delimiter not specified ........ r8112 | kpfleming | 2006-01-17 00:51:37 +0100 (Tue, 17 Jan 2006) | 2 lines do rlimit check _after_ reading config file, in case 'dumpcore' is specified there ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8119 |