Summary:ASTERISK-05943: [patch] cleanup of pbx.c time parsing code
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2006-01-01 11:55:14.000-0600Date Closed:2008-01-15 16:14:47.000-0600
Versions:Frequency of
Environment:Attachments:( 0) pbx-time.diff
Description:the attached patch implements a significant simplification of the time
interval parsing code, mostly using a single function to replace
the 3 copies of the same code that maps a range into a bitmask,
and replacing confusing code sequences involving the FIND_NEXT
macro with the equivalent call to strsep().

Comments:By: Olle Johansson (oej) 2006-01-03 02:40:13.000-0600

Please format comments that explains functions in doxygen format. Thanks!

By: Luigi Rizzo (rizzo) 2006-01-05 12:12:24.000-0600

i am sorry i am not familiar enough with doxygen, i would just
add some \tags copied from other comments without really understanding
what they exactly do.

I am sure someone (russel ?) can easily clean up those 3 comments once
the patch is in. After all, there were no comments before, there are
no doxygen comments after, so there is no regression in the documentation :)

By: Olle Johansson (oej) 2006-01-06 02:20:58.000-0600

rizzo, as you are becoming more and more active, it's time to learn how to add doxygen yourself. There's a good manual out there and it's easy. Please do not rely on others cleaning up, there's so much to do for us all!


By: Mark Spencer (markster) 2006-01-12 10:27:34.000-0600

Added to SVN trunk with the comment fixes requested by oej, ASTERISK-7804

By: Digium Subversion (svnbot) 2008-01-15 16:14:47.000-0600

Repository: asterisk
Revision: 8016

U   trunk/pbx.c

r8016 | markster | 2008-01-15 16:14:47 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge rizzo's range optimizations (bug ASTERISK-5943)