| Summary: | ASTERISK-05938: [patch] ast_callerid_parse cleanup | ||
| Reporter: | Luigi Rizzo (rizzo) | Labels: | |
| Date Opened: | 2005-12-31 06:36:15.000-0600 | Date Closed: | 2006-01-20 22:06:09.000-0600 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) callerid.diff | |
| Description: | the attached patch cleans up the formatting of ast_callerid_parse(), replaces inline code with ast_trim_blanks() and ast_skip_blanks() (for consistency), removes an unreachable 'return -1', remove unnecessary escapes in character constants, and points out the inconsistency of the original behaviour when space is present in quotes. The original behaviour is preserved, however I'd rather have it fixed, to make interaction with non-conforming input more robust (since the original code does that already, at least partially). | ||
| Comments: | By: Olle Johansson (oej) 2006-01-04 12:51:22.000-0600 There's some bad formatting in there - one line while statements. Also "XXX note" is not a valid doxygen command. Use \note instead :-) This is one function that really could benefit from the test framework... By: Olle Johansson (oej) 2006-01-04 12:53:14.000-0600 Sorry, tired. In fact, you *remove* those lines. Moving to fast amongst the pile of open reports. By: Luigi Rizzo (rizzo) 2006-01-04 12:57:41.000-0600 no problem... but note, XXX is meant to be a developer marker for unresolved issues which is supposed to go away once the issue is fixed, not as something that has to end up in documentation. By: Tilghman Lesher (tilghman) 2006-01-20 22:06:09.000-0600 Committed to trunk. | ||