Summary:	ASTERISK-05934: [patch][post 1.4] use PHONE_DIALTONE ioctl instead of writing the dialtone in the select
Reporter:	Yoann WALTHER (ywalther)	Labels:
Date Opened:	2005-12-30 06:15:16.000-0600	Date Closed:	2006-08-08 12:03:09
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_phone
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_phone.diff ( 1) phone_changes.patch
Description:	There is in the linux telephony API an ioctl PHONE_DIALTONE, which is the correct implementation to play the tone. I am currently writing a driver for a non-quicknet card, using this API, and with my card, the timeout in select never goes to zero, so there was no write done. I attach a patch which implements the new functionnality. I tested it on my board, and it works. But I do not have any quicknet card, so I cannot reproduce it with it.
Comments:	By: Clod Patry (junky) 2006-01-01 15:56:33.000-0600 Thanks. By: Matt O'Gorman (mogorman) 2006-01-12 15:31:26.000-0600 can anyone else verify that this is good clean patch?  I have no phonejack hw. By: Russell Bryant (russell) 2006-01-12 17:45:36.000-0600 We'll have to find someone with a quicknet card to make sure this still works correctly before we can merge it. By: Yoann WALTHER (ywalther) 2006-01-24 08:04:19.000-0600 I've taken a look to the ixj kernel module sources, and I noticed that this Ioctl works for all cards, excepted the ISA Phonejack. So I suppose that that was the reason of asterisk being writing the dialtone by itself. What should be done is using this ioctl ever, and add a specific mode for this ISA card (if it is still used ??) where Asterisk would be writing the tone. Anyway, for my card the only way it works is by using the ioctl Dialtone, because the select timeval never goes to zero, so no write is being done. By: Serge Vecher (serge-v) 2006-05-12 14:47:19 ywalther: any progress on testing here? By: Yoann WALTHER (ywalther) 2006-05-12 16:13:24 We still need to find someone with a quicknet card. In my society we use asterisk with my patch for our voip board to work. But we do not have any quicknet card to test it. (does it still exists ??) By: Joshua C. Colp (jcolp) 2006-05-22 12:03:47 Since we have found nobody that can test this, I'm just going to suspend the bug. By: Yoann WALTHER (ywalther) 2006-07-13 11:10:56 Ok... If you can not test it for Quicknet cards, is it possible to add a new mode, for Sigma Designs cards ? We're gonna release our VoIP solution very soon, and it would be great that this patch would be commited. There is already a mode FXS and DIALTONE, we could maybe add a mode SIGMA, similar to the DIALTONE mode, but with this patch enabled. By the way, you will be able to say that you support our board, which I found interesting. By: Serge Vecher (serge-v) 2006-07-13 11:14:44 ywalther: can you please get a disclaimer on file and confirm with a note when done? By: Yoann WALTHER (ywalther) 2006-07-17 05:01:05 phone_changes.patch is a patch from today's SVN revision. I added a mode SIGMA, to avoid testing on a quicknet card, as nobody has found one. I'll now get a disclaimer on file By: Yoann WALTHER (ywalther) 2006-07-18 11:15:02 Hi, I did send the disclaimer per fax yesterday. Did you received it ? By: Joshua C. Colp (jcolp) 2006-08-08 12:03:08 Put into trunk as of revision 39349 with minor mods and documentation. Thanks!