[Home]

Summary:ASTERISK-05922: Enter and Exit tones sound really bad
Reporter:dea (dea)Labels:
Date Opened:2005-12-28 18:40:34.000-0600Date Closed:2009-01-20 14:46:15.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The enter and exit tones sound like blowing through four layers
of cellophane.

Normal conversation, at least on a small conference sounds fine.
Comments:By: dea (dea) 2005-12-28 19:03:48.000-0600

OK, so this is related to the issue with codec payloads greater than
20ms.

Comparing app_meetme.c from 1.2.0 I see that we're now back to using
careful_write with a flag to not block on enter/exit sounds.

This small change near line 448 returns the quality to the enter/exit sounds.
       if (data) {
-                data2 = alloca(len * 2);
-                for (x=0;x<len;x++)
-                        data2[x] = AST_MULAW(data[x]);
-                careful_write(conf->fd, (unsigned char *)data2, len << 1, 1);
+                careful_write(conf->fd, data, len, 1);
       }

I'll admit to not knowing what AST_MULAW() does, and the code doesn't
make it clear.  It looks like a conversion routine, but the enter/exit
sounds are already in ULAW (according to enter.h), so a conversion does not
make sense.

Disclaimer on file.


By: Niles Ingalls (atheos) 2005-12-31 22:02:37.000-0600

I'm having the exact same issue since upgrading to SVN, and I just now upgraded to 7690M.
By: Antonio (asvaranda) 2006-01-18 08:23:48.000-0600

I have also the same problem, it is only related to the entry and leaving sounds, everything else seems fine.
By: Matt O'Gorman (mogorman) 2006-01-30 14:17:09.000-0600

commited into trunk 8938