Summary:	ASTERISK-05913: broken rport match in chan_sip.c::check_via()
Reporter:	Luigi Rizzo (rizzo)	Labels:
Date Opened:	2005-12-28 08:27:33.000-0600	Date Closed:	2008-01-15 16:15:25.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	chan_sip.c::check_via() near the end tries to locate ";rport", however this is bound to fail because everything after the firat ; has been trimmed off the 'via' string. Not sure how fundamental is this functionality. There are multiple ways to fix the bug, one is to replace the line      c = strstr(via, ";rport"); with      c = strstr( get_header(req, "Via"), ";rport"); But a better one would be to store a pointer to the previous result of get_header() so we don't have to run it twice.
Comments:	By: Olle Johansson (oej) 2006-01-03 04:58:42.000-0600 Fixed in svn trunk revision 7733. Thank you! By: Digium Subversion (svnbot) 2008-01-15 16:10:36.000-0600 Repository: asterisk Revision: 7733 U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r7733 | oej | 2008-01-15 16:10:36 -0600 (Tue, 15 Jan 2008) | 2 lines Bug ASTERISK-5913: Broken rport match in check_via(). (rizzo) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7733 By: Digium Subversion (svnbot) 2008-01-15 16:10:41.000-0600 Repository: asterisk Revision: 7738 U   branches/1.2/channels/chan_sip.c ------------------------------------------------------------------------ r7738 | kpfleming | 2008-01-15 16:10:40 -0600 (Tue, 15 Jan 2008) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7738 By: Digium Subversion (svnbot) 2008-01-15 16:11:19.000-0600 Repository: asterisk Revision: 7781 _U  team/oej/aum-trunk/ U   team/oej/aum-trunk/UPGRADE.txt U   team/oej/aum-trunk/apps/app_chanspy.c U   team/oej/aum-trunk/apps/app_mixmonitor.c U   team/oej/aum-trunk/apps/app_privacy.c U   team/oej/aum-trunk/apps/app_stack.c D   team/oej/aum-trunk/ast_expr.y U   team/oej/aum-trunk/ast_expr2.fl U   team/oej/aum-trunk/ast_expr2f.c U   team/oej/aum-trunk/autoservice.c U   team/oej/aum-trunk/cdr.c U   team/oej/aum-trunk/channel.c U   team/oej/aum-trunk/channels/chan_iax2.c U   team/oej/aum-trunk/channels/chan_sip.c U   team/oej/aum-trunk/configs/manager.conf.sample U   team/oej/aum-trunk/configs/sip.conf.sample A   team/oej/aum-trunk/contrib/scripts/safe_asterisk_restart U   team/oej/aum-trunk/file.c U   team/oej/aum-trunk/funcs/func_moh.c U   team/oej/aum-trunk/image.c U   team/oej/aum-trunk/include/asterisk/chanspy.h U   team/oej/aum-trunk/include/asterisk/image.h U   team/oej/aum-trunk/include/asterisk/rtp.h U   team/oej/aum-trunk/manager.c U   team/oej/aum-trunk/pbx.c U   team/oej/aum-trunk/res/Makefile U   team/oej/aum-trunk/res/res_osp.c U   team/oej/aum-trunk/rtp.c ------------------------------------------------------------------------ r7781 | oej | 2008-01-15 16:11:18 -0600 (Tue, 15 Jan 2008) | 171 lines Merged revisions 7720,7725,7728-7734,7737,7739,7741,7744-7745,7747-7748,7750-7751,7770,7774-7779 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7720 | russell | 2006-01-02 19:54:34 +0100 (Mon, 02 Jan 2006) | 2 lines doxygen updates ................ r7725 | russell | 2006-01-03 00:52:33 +0100 (Tue, 03 Jan 2006) | 2 lines initialize sip_auth list ................ r7728 | oej | 2006-01-03 09:40:55 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5960: Clean up list handling in image.c (drumkilla) ................ r7729 | oej | 2006-01-03 09:54:19 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5958: Use list macros in autoservice.c (drumkilla) ................ r7730 | oej | 2006-01-03 10:30:19 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5951: Fix unprotected list in RTP, implement AST_LIST macros, update doxygen docs ................ r7731 | oej | 2006-01-03 12:21:48 +0100 (Tue, 03 Jan 2006) | 2 lines Bug 5345; Add configuration option for minimum registration time. (folsson) ................ r7732 | oej | 2006-01-03 12:31:56 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5088: Add caller ID and CallerIDname to OriginateSuccess/Failure manager events (outtolunc) ................ r7733 | oej | 2006-01-03 12:58:10 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5913: Broken rport match in check_via(). (rizzo) ................ r7734 | oej | 2006-01-03 13:25:32 +0100 (Tue, 03 Jan 2006) | 2 lines Issue ASTERISK-5799: Implement printf-like append_history and implement AST_LIST for SIP history (rizzo) ................ r7737 | kpfleming | 2006-01-03 17:39:37 +0100 (Tue, 03 Jan 2006) | 10 lines Merged revisions 7736 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7736 | kpfleming | 2006-01-03 10:34:12 -0600 (Tue, 03 Jan 2006) | 2 lines don't leak memory for (most) expression evaluations ........ ................ r7739 | kpfleming | 2006-01-03 18:08:35 +0100 (Tue, 03 Jan 2006) | 3 lines fix breakage from rev 7730 (failure to unlock list in get_proto) minor cleanups and simpler usage of list macros ................ r7741 | kpfleming | 2006-01-03 18:25:39 +0100 (Tue, 03 Jan 2006) | 12 lines Merged revisions 7740 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7740 | kpfleming | 2006-01-03 11:24:56 -0600 (Tue, 03 Jan 2006) | 4 lines revert incorrect fix for bug ASTERISK-5890 from revision 7709 put in correct (simpler) fix add doxygen docs for channel spy 'state' values ........ ................ r7744 | tilghman | 2006-01-03 19:17:42 +0100 (Tue, 03 Jan 2006) | 3 lines Merged revisions 7743 via svnmerge from /branches/1.2 ................ r7745 | oej | 2006-01-03 20:12:50 +0100 (Tue, 03 Jan 2006) | 2 lines Don't check user call limits for outbound calls. ................ r7747 | kpfleming | 2006-01-03 21:23:23 +0100 (Tue, 03 Jan 2006) | 10 lines Merged revisions 7746 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7746 | kpfleming | 2006-01-03 14:22:18 -0600 (Tue, 03 Jan 2006) | 2 lines remove unused 'old' expression parser ........ ................ r7748 | kpfleming | 2006-01-03 21:33:28 +0100 (Tue, 03 Jan 2006) | 2 lines add script for simple 'no-brainer' restarts of safe_asterisk (issue ASTERISK-5004) ................ r7750 | kpfleming | 2006-01-03 23:07:12 +0100 (Tue, 03 Jan 2006) | 2 lines add optional timestamps to manager events (issue ASTERISK-5387, simplified) ................ r7751 | kpfleming | 2006-01-03 23:16:23 +0100 (Tue, 03 Jan 2006) | 2 lines update copyright headers for files changed this year ................ r7770 | bweschke | 2006-01-04 06:26:03 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ................ r7774 | russell | 2006-01-04 08:08:08 +0100 (Wed, 04 Jan 2006) | 10 lines Merged revisions 7773 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7773 | russell | 2006-01-04 02:06:50 -0500 (Wed, 04 Jan 2006) | 2 lines use a more correct way of determining the size of the destination buffer ........ ................ r7775 | oej | 2006-01-04 10:10:56 +0100 (Wed, 04 Jan 2006) | 6 lines - Remove "incominglimit" as a configuration option in sip.conf - Add documentation on call-limit, explaining that there's two counters  for a type="friend". - Document the removval of "incominglimit" in UPGRADE.txt ................ r7776 | oej | 2006-01-04 10:22:45 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5970: Count in show channeltypes (junky) ................ r7777 | oej | 2006-01-04 11:16:53 +0100 (Wed, 04 Jan 2006) | 2 lines Missing ">" in XML. Thanks, fenlander, for reporting this on IRC. ................ r7778 | russell | 2006-01-04 13:11:11 +0100 (Wed, 04 Jan 2006) | 2 lines doxygen tweak ................ r7779 | oej | 2006-01-04 13:16:30 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5797: Add destination protocol information to res_osp (homesick) ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7781 By: Digium Subversion (svnbot) 2008-01-15 16:11:25.000-0600 Repository: asterisk Revision: 7787 _U  team/oej/multiparking/ U   team/oej/multiparking/UPGRADE.txt U   team/oej/multiparking/apps/app_chanspy.c U   team/oej/multiparking/apps/app_disa.c U   team/oej/multiparking/apps/app_mixmonitor.c U   team/oej/multiparking/apps/app_privacy.c U   team/oej/multiparking/apps/app_stack.c D   team/oej/multiparking/ast_expr.y U   team/oej/multiparking/ast_expr2.fl U   team/oej/multiparking/ast_expr2f.c U   team/oej/multiparking/autoservice.c U   team/oej/multiparking/cdr.c U   team/oej/multiparking/channel.c U   team/oej/multiparking/channels/chan_iax2.c U   team/oej/multiparking/channels/chan_sip.c U   team/oej/multiparking/channels/chan_zap.c U   team/oej/multiparking/configs/manager.conf.sample U   team/oej/multiparking/configs/sip.conf.sample U   team/oej/multiparking/contrib/scripts/managerproxy.pl A   team/oej/multiparking/contrib/scripts/safe_asterisk_restart U   team/oej/multiparking/file.c U   team/oej/multiparking/funcs/func_moh.c U   team/oej/multiparking/image.c U   team/oej/multiparking/include/asterisk/chanspy.h U   team/oej/multiparking/include/asterisk/image.h U   team/oej/multiparking/include/asterisk/rtp.h U   team/oej/multiparking/manager.c U   team/oej/multiparking/pbx.c U   team/oej/multiparking/res/res_osp.c U   team/oej/multiparking/rtp.c ------------------------------------------------------------------------ r7787 | oej | 2008-01-15 16:11:24 -0600 (Tue, 15 Jan 2008) | 186 lines Merged revisions 7725,7728-7734,7737,7739,7741,7744-7745,7747-7748,7750-7751,7770,7774-7779,7783-7786 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7725 | russell | 2006-01-03 00:52:33 +0100 (Tue, 03 Jan 2006) | 2 lines initialize sip_auth list ................ r7728 | oej | 2006-01-03 09:40:55 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5960: Clean up list handling in image.c (drumkilla) ................ r7729 | oej | 2006-01-03 09:54:19 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5958: Use list macros in autoservice.c (drumkilla) ................ r7730 | oej | 2006-01-03 10:30:19 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5951: Fix unprotected list in RTP, implement AST_LIST macros, update doxygen docs ................ r7731 | oej | 2006-01-03 12:21:48 +0100 (Tue, 03 Jan 2006) | 2 lines Bug 5345; Add configuration option for minimum registration time. (folsson) ................ r7732 | oej | 2006-01-03 12:31:56 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5088: Add caller ID and CallerIDname to OriginateSuccess/Failure manager events (outtolunc) ................ r7733 | oej | 2006-01-03 12:58:10 +0100 (Tue, 03 Jan 2006) | 2 lines Bug ASTERISK-5913: Broken rport match in check_via(). (rizzo) ................ r7734 | oej | 2006-01-03 13:25:32 +0100 (Tue, 03 Jan 2006) | 2 lines Issue ASTERISK-5799: Implement printf-like append_history and implement AST_LIST for SIP history (rizzo) ................ r7737 | kpfleming | 2006-01-03 17:39:37 +0100 (Tue, 03 Jan 2006) | 10 lines Merged revisions 7736 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7736 | kpfleming | 2006-01-03 10:34:12 -0600 (Tue, 03 Jan 2006) | 2 lines don't leak memory for (most) expression evaluations ........ ................ r7739 | kpfleming | 2006-01-03 18:08:35 +0100 (Tue, 03 Jan 2006) | 3 lines fix breakage from rev 7730 (failure to unlock list in get_proto) minor cleanups and simpler usage of list macros ................ r7741 | kpfleming | 2006-01-03 18:25:39 +0100 (Tue, 03 Jan 2006) | 12 lines Merged revisions 7740 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7740 | kpfleming | 2006-01-03 11:24:56 -0600 (Tue, 03 Jan 2006) | 4 lines revert incorrect fix for bug ASTERISK-5890 from revision 7709 put in correct (simpler) fix add doxygen docs for channel spy 'state' values ........ ................ r7744 | tilghman | 2006-01-03 19:17:42 +0100 (Tue, 03 Jan 2006) | 3 lines Merged revisions 7743 via svnmerge from /branches/1.2 ................ r7745 | oej | 2006-01-03 20:12:50 +0100 (Tue, 03 Jan 2006) | 2 lines Don't check user call limits for outbound calls. ................ r7747 | kpfleming | 2006-01-03 21:23:23 +0100 (Tue, 03 Jan 2006) | 10 lines Merged revisions 7746 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7746 | kpfleming | 2006-01-03 14:22:18 -0600 (Tue, 03 Jan 2006) | 2 lines remove unused 'old' expression parser ........ ................ r7748 | kpfleming | 2006-01-03 21:33:28 +0100 (Tue, 03 Jan 2006) | 2 lines add script for simple 'no-brainer' restarts of safe_asterisk (issue ASTERISK-5004) ................ r7750 | kpfleming | 2006-01-03 23:07:12 +0100 (Tue, 03 Jan 2006) | 2 lines add optional timestamps to manager events (issue ASTERISK-5387, simplified) ................ r7751 | kpfleming | 2006-01-03 23:16:23 +0100 (Tue, 03 Jan 2006) | 2 lines update copyright headers for files changed this year ................ r7770 | bweschke | 2006-01-04 06:26:03 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ................ r7774 | russell | 2006-01-04 08:08:08 +0100 (Wed, 04 Jan 2006) | 10 lines Merged revisions 7773 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7773 | russell | 2006-01-04 02:06:50 -0500 (Wed, 04 Jan 2006) | 2 lines use a more correct way of determining the size of the destination buffer ........ ................ r7775 | oej | 2006-01-04 10:10:56 +0100 (Wed, 04 Jan 2006) | 6 lines - Remove "incominglimit" as a configuration option in sip.conf - Add documentation on call-limit, explaining that there's two counters  for a type="friend". - Document the removval of "incominglimit" in UPGRADE.txt ................ r7776 | oej | 2006-01-04 10:22:45 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5970: Count in show channeltypes (junky) ................ r7777 | oej | 2006-01-04 11:16:53 +0100 (Wed, 04 Jan 2006) | 2 lines Missing ">" in XML. Thanks, fenlander, for reporting this on IRC. ................ r7778 | russell | 2006-01-04 13:11:11 +0100 (Wed, 04 Jan 2006) | 2 lines doxygen tweak ................ r7779 | oej | 2006-01-04 13:16:30 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5797: Add destination protocol information to res_osp (homesick) ................ r7783 | oej | 2006-01-04 14:07:34 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5673: Adding more SIP to ISDN Cause code conversions. Thanks mguesdon! ................ r7784 | oej | 2006-01-04 14:49:25 +0100 (Wed, 04 Jan 2006) | 2 lines Whitespace and formatting changes. /Housekeeping ................ r7785 | oej | 2006-01-04 14:56:11 +0100 (Wed, 04 Jan 2006) | 2 lines Small typo fix ................ r7786 | mattf | 2006-01-04 15:46:41 +0100 (Wed, 04 Jan 2006) | 2 lines Fixes for bug ASTERISK-5968 ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7787 By: Digium Subversion (svnbot) 2008-01-15 16:12:42.000-0600 Repository: asterisk Revision: 7880 _U  team/oej/moduletest/ U   team/oej/moduletest/apps/app_chanspy.c U   team/oej/moduletest/apps/app_mixmonitor.c U   team/oej/moduletest/apps/app_privacy.c U   team/oej/moduletest/apps/app_stack.c U   team/oej/moduletest/apps/app_voicemail.c D   team/oej/moduletest/ast_expr.y U   team/oej/moduletest/ast_expr2.fl U   team/oej/moduletest/ast_expr2f.c U   team/oej/moduletest/channel.c U   team/oej/moduletest/channels/chan_agent.c U   team/oej/moduletest/channels/chan_iax2.c U   team/oej/moduletest/channels/chan_sip.c U   team/oej/moduletest/formats/format_pcm.c U   team/oej/moduletest/formats/format_pcm_alaw.c U   team/oej/moduletest/funcs/func_moh.c U   team/oej/moduletest/include/asterisk/chanspy.h U   team/oej/moduletest/include/asterisk/strings.h U   team/oej/moduletest/manager.c U   team/oej/moduletest/pbx/pbx_config.c U   team/oej/moduletest/pbx/pbx_spool.c U   team/oej/moduletest/res/res_features.c ------------------------------------------------------------------------ r7880 | oej | 2008-01-15 16:12:41 -0600 (Tue, 15 Jan 2008) | 150 lines Merged revisions 7677,7706,7709,7736,7738,7740,7743,7746,7771,7773,7792,7795,7799-7800,7803,7805,7807,7809,7812,7819,7823,7825,7827,7829,7831,7848,7870-7871 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7677 | tilghman | 2005-12-30 15:54:19 +0100 (Fri, 30 Dec 2005) | 2 lines Bug 6091 - Fix race condition around uniqueid ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mon, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7709 | tilghman | 2006-01-02 08:31:54 +0100 (Mon, 02 Jan 2006) | 2 lines Bug 6084 - MixMonitor after a 'cli stop monitor' deadlocks ........ r7736 | kpfleming | 2006-01-03 17:34:12 +0100 (Tue, 03 Jan 2006) | 2 lines don't leak memory for (most) expression evaluations ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Tue, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7740 | kpfleming | 2006-01-03 18:24:56 +0100 (Tue, 03 Jan 2006) | 4 lines revert incorrect fix for bug ASTERISK-5890 from revision 7709 put in correct (simpler) fix add doxygen docs for channel spy 'state' values ........ r7743 | tilghman | 2006-01-03 19:15:12 +0100 (Tue, 03 Jan 2006) | 2 lines Bug 6121 - typo in application description ........ r7746 | kpfleming | 2006-01-03 21:22:18 +0100 (Tue, 03 Jan 2006) | 2 lines remove unused 'old' expression parser ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7773 | russell | 2006-01-04 08:06:50 +0100 (Wed, 04 Jan 2006) | 2 lines use a more correct way of determining the size of the destination buffer ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Wed, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7795 | oej | 2006-01-04 22:46:40 +0100 (Wed, 04 Jan 2006) | 2 lines Issue ASTERISK-5824: Removing extra CR+LF in manager events - needs port to trunk ........ r7799 | kpfleming | 2006-01-05 00:02:38 +0100 (Thu, 05 Jan 2006) | 2 lines make monitoring more tolerant of peers that deliver frames in bursts ........ r7800 | kpfleming | 2006-01-05 00:27:57 +0100 (Thu, 05 Jan 2006) | 2 lines ensure that ulaw/alaw sound files are filled with silence when extended (not zeroes) ........ r7803 | kpfleming | 2006-01-05 00:45:34 +0100 (Thu, 05 Jan 2006) | 2 lines return properly after extending file ........ r7805 | kpfleming | 2006-01-05 00:51:03 +0100 (Thu, 05 Jan 2006) | 2 lines use proper fwrite() parameters and return value ........ r7807 | kpfleming | 2006-01-05 01:18:46 +0100 (Thu, 05 Jan 2006) | 2 lines doh... fseek() has no useful return value ........ r7809 | kpfleming | 2006-01-05 01:58:29 +0100 (Thu, 05 Jan 2006) | 2 lines send device state updates for auto-logoff of agents as well ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Thu, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ r7819 | kpfleming | 2006-01-05 21:52:38 +0100 (Thu, 05 Jan 2006) | 2 lines ensure that variable is initialized ........ r7823 | tilghman | 2006-01-06 00:07:08 +0100 (Fri, 06 Jan 2006) | 2 lines Bug 6081 - fix for memory leak, formatting fixes ........ r7825 | kpfleming | 2006-01-06 00:49:50 +0100 (Fri, 06 Jan 2006) | 3 lines eliminate rounding errors that caused call time limits to be inaccurate (issue ASTERISK-5758) round 'time left' reported during call limit warnings up to sound more accurate ........ r7827 | tilghman | 2006-01-06 00:53:07 +0100 (Fri, 06 Jan 2006) | 2 lines Bug 6076 - Fix documentation of ast_trim_blank return value ........ r7829 | kpfleming | 2006-01-06 01:21:00 +0100 (Fri, 06 Jan 2006) | 2 lines update agent persistence when an agent gets logged off by autologoff ........ r7831 | tilghman | 2006-01-06 01:34:40 +0100 (Fri, 06 Jan 2006) | 2 lines Dumb error messages - "Context 'context' already included in 'in' context" ........ r7848 | tilghman | 2006-01-07 08:27:18 +0100 (Sat, 07 Jan 2006) | 2 lines Bug 6156 - catch all threading errors, not just simple failure ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mon, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7880 By: Digium Subversion (svnbot) 2008-01-15 16:13:30.000-0600 Repository: asterisk Revision: 7934 _U  team/oej/metermaids/ U   team/oej/metermaids/apps/app_voicemail.c U   team/oej/metermaids/channels/Makefile U   team/oej/metermaids/channels/chan_sip.c A   team/oej/metermaids/channels/misdn/mISDN.patch A   team/oej/metermaids/channels/misdn/mISDNuser.patch U   team/oej/metermaids/doc/README.variables U   team/oej/metermaids/pbx/pbx_spool.c U   team/oej/metermaids/res/res_agi.c ------------------------------------------------------------------------ r7934 | oej | 2008-01-15 16:13:29 -0600 (Tue, 15 Jan 2008) | 145 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812,7870-7871,7898-7900,7904,7908 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Thu, 15 Dec 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sat, 17 Dec 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Tue, 20 Dec 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Tue, 20 Dec 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Wed, 21 Dec 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Wed, 21 Dec 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Thu, 22 Dec 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fri, 23 Dec 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mon, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Tue, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Wed, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Thu, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mon, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mon, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7904 | tilghman | 2006-01-09 19:37:50 +0100 (Mon, 09 Jan 2006) | 2 lines Update variable documentation to match the code ........ r7908 | tilghman | 2006-01-09 21:08:24 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6157 - Memory leak ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7934 By: Digium Subversion (svnbot) 2008-01-15 16:13:36.000-0600 Repository: asterisk Revision: 7938 _U  team/oej/managerstuff/ U   team/oej/managerstuff/apps/app_voicemail.c U   team/oej/managerstuff/channels/chan_iax2.c U   team/oej/managerstuff/channels/chan_sip.c A   team/oej/managerstuff/channels/misdn/mISDN.patch A   team/oej/managerstuff/channels/misdn/mISDNuser.patch U   team/oej/managerstuff/doc/README.variables U   team/oej/managerstuff/file.c U   team/oej/managerstuff/pbx/pbx_spool.c ------------------------------------------------------------------------ r7938 | oej | 2008-01-15 16:13:35 -0600 (Tue, 15 Jan 2008) | 155 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812,7870-7871,7898-7900,7904,7908,7915,7917 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Thu, 15 Dec 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sat, 17 Dec 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Tue, 20 Dec 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Tue, 20 Dec 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Wed, 21 Dec 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Wed, 21 Dec 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Thu, 22 Dec 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fri, 23 Dec 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mon, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Tue, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Wed, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Thu, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mon, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mon, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7904 | tilghman | 2006-01-09 19:37:50 +0100 (Mon, 09 Jan 2006) | 2 lines Update variable documentation to match the code ........ r7908 | tilghman | 2006-01-09 21:08:24 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6157 - Memory leak ........ r7915 | russell | 2006-01-09 23:07:26 +0100 (Mon, 09 Jan 2006) | 2 lines add missing unlock (issue ASTERISK-5954) ........ r7917 | kpfleming | 2006-01-09 23:48:48 +0100 (Mon, 09 Jan 2006) | 2 lines re-initialize _all_ sequence numbers when transfer completes ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7938 By: Digium Subversion (svnbot) 2008-01-15 16:15:23.000-0600 Repository: asterisk Revision: 8054 _U  team/crichter/0.3.0/ ------------------------------------------------------------------------ r8054 | crichter | 2008-01-15 16:15:22 -0600 (Tue, 15 Jan 2008) | 110 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Do, 15 Dez 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sa, 17 Dez 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Di, 20 Dez 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Di, 20 Dez 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Mi, 21 Dez 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Mi, 21 Dez 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Do, 22 Dez 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fr, 23 Dez 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Di, 27 Dez 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Di, 27 Dez 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mo, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Di, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Mi, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Mi, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Do, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8054 By: Digium Subversion (svnbot) 2008-01-15 16:15:25.000-0600 Repository: asterisk Revision: 8055 _U  team/crichter/frame-data/ U   team/crichter/frame-data/apps/app_voicemail.c U   team/crichter/frame-data/channel.c U   team/crichter/frame-data/channels/chan_agent.c U   team/crichter/frame-data/configs/voicemail.conf.sample ------------------------------------------------------------------------ r8055 | crichter | 2008-01-15 16:15:24 -0600 (Tue, 15 Jan 2008) | 246 lines Merged revisions 8053-8054 via svnmerge from https://origsvn.digium.com/svn/asterisk/team/crichter/0.3.0 ................ r8053 | crichter | 2006-01-13 12:03:35 +0100 (Fr, 13 Jan 2006) | 125 lines Merged revisions 7870-7871,7898-7900,7963,7973-7975,7977-8051 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mo, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mo, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mo, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mo, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mo, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7963 | mogorman | 2006-01-11 05:38:07 +0100 (Mi, 11 Jan 2006) | 2 lines Minor typo refrenced in 6191 ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ r7986 | russell | 2006-01-11 20:08:53 +0100 (Mi, 11 Jan 2006) | 2 lines move variable to correct scope (issue ASTERISK-6040) ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ r7999 | tilghman | 2006-01-12 07:14:22 +0100 (Do, 12 Jan 2006) | 2 lines Bug 6211 - Add option deletevoicemail as equivalent to option delete for Realtime ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ r8047 | russell | 2006-01-13 07:07:39 +0100 (Fr, 13 Jan 2006) | 2 lines fix spelling errors (issue ASTERISK-6069) ........ ........ ........ ........ ........ ................ r8054 | crichter | 2006-01-13 14:00:07 +0100 (Fr, 13 Jan 2006) | 110 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Do, 15 Dez 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sa, 17 Dez 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Di, 20 Dez 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Di, 20 Dez 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Mi, 21 Dez 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Mi, 21 Dez 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Do, 22 Dez 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fr, 23 Dez 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Di, 27 Dez 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Di, 27 Dez 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mo, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Di, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Mi, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Mi, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Do, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8055