Summary:	ASTERISK-05904: [patch] file format conversion CLI command
Reporter:	redice li (redice li)	Labels:
Date Opened:	2005-12-26 00:57:42.000-0600	Date Closed:	2008-01-15 17:44:38.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) res_convert.c
Description:	An audio convsion module for asterisk. The module is well tested before register here, see http://www.voip-info.org/wiki/view/Asterisk+audio+convert+module for more information.
Comments:	By: Russell Bryant (russell) 2005-12-26 07:17:06.000-0600 Can you just upload the source file?  I imagine it is probably a single file.  That will make it easier for us to review the code. By: Russell Bryant (russell) 2005-12-26 07:18:44.000-0600 You will also need to file a disclaimer with Digium for us to consider merging your code into Asterisk. By: redice li (redice li) 2005-12-30 18:34:58.000-0600 Yes, I'd like to disclaimer on file. But I can't change the bugs status to set it YES? By: Olle Johansson (oej) 2006-01-03 04:06:25.000-0600 "I'd like to disclaimer on file" - does that mean that you have a disclaimer on file? Sorry for asking, but I need to make sure that we understand correctly. By: Olle Johansson (oej) 2006-01-03 04:09:13.000-0600 -"Sample audio conversion module by redice" needs to change to "Sample audio conversion module" We have no attributes to programmers in the UI. - Please clarify the copyright - either to yourself or to Digium with you mentioned as an author. - Check the formatting so that it confirms to the coding guidelines. By: redice li (redice li) 2006-01-03 19:13:33.000-0600 Yes, I have a disclaimer on file (and sorry for my poor english). By: Olle Johansson (oej) 2006-01-26 02:22:04.000-0600 Still have some formatting issues: if (fs_out) ast_closestream(fs_out); if (fs_in) ast_closestream(fs_in); And some places where you lack spaces. Check the guidelines :-) Adding some doxygen comments that explains each function does not hurt, really. By: Russell Bryant (russell) 2006-02-09 20:32:53.000-0600 I have uploaded a new patch with various changes ... 1) new implementation of split_ext() 2) Use the STANDARD_USECOUNT macros for usecount handling 3) Minor changes to log messages 4) Remove some unneeded headers Probably some more, too ... My initial testing did not find any problems.  However, I have one concern.  We are not guaranteed that there is a translation path between two formats.  For example, what happens if someone tried to do "convert somefile.h264 somefile.gsm" ? By: Kevin P. Fleming (kpfleming) 2006-02-14 18:11:28.000-0600 This method will be prone to failure in that case... you need to create a translation path yourself and feed the frames through it, so you can know for sure that the path was creatable. By: Russell Bryant (russell) 2006-03-14 13:51:42.000-0600 I have added this command in the trunk in revision 12962 with additional modifications to be more robust in handling the case where a translation path could not be created or some other error occurred while trying to write the new file. By: Digium Subversion (svnbot) 2008-01-15 17:29:16.000-0600 Repository: asterisk Revision: 12962 A   trunk/res/res_convert.c ------------------------------------------------------------------------ r12962 | russell | 2008-01-15 17:29:15 -0600 (Tue, 15 Jan 2008) | 3 lines add a CLI command that allows conversion of files to other formats using the Asterisk file format and codec translation modules (issue ASTERISK-5904) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=12962 By: Digium Subversion (svnbot) 2008-01-15 17:44:38.000-0600 Repository: asterisk Revision: 14027 U   trunk/configs/features.conf.sample ------------------------------------------------------------------------ r14027 | russell | 2008-01-15 17:44:38 -0600 (Tue, 15 Jan 2008) | 3 lines add a CLI command that allows converting files to other formats using the Asterisk file format and codec translator modules (issue ASTERISK-5904) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=14027