[Home]

Summary:ASTERISK-05877: Make func_enum to use default zone suffixes from enum.conf
Reporter:deti (deti)Labels:
Date Opened:2005-12-20 14:53:46.000-0600Date Closed:2008-01-15 16:46:32.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Functions/func_enum
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) func_enum.c-nodefault.diff
( 1) README.enum.diff
Description:func_enum uses by default the e164.arpa zone if no zone is given by parameter. This is not consistent with other asterisk related enum documentation and makes the enum function less flexible. This patch removes the default from func_enum and makes use of the search defaults from enum.conf - now it's possible to search multiple zones with only one enum function call.
Comments:By: Olle Johansson (oej) 2005-12-21 02:42:17.000-0600

You are breaking backwards compatibility and not changing the docs.
By: deti (deti) 2005-12-21 03:11:03.000-0600

IMHO it makes sense keeping the enum.conf file - as it is easier to match against multiple zones (like e164.(arpa|org|info)). Attached you can find an adapted README.enum file.
Though it breaks backward compatibility in documentation the default in enum.conf is to search just for e164.arpa. This in turn keeps the specified behavior of the function.
If my patch does not get accepted this way I would propose a new parameter for the enum function to use the defaults from enum.conf
By: Matt O'Gorman (mogorman) 2006-01-13 00:43:54.000-0600

yay or nay, i dont think we should break the compatibilty as is and move to close bug.
By: deti (deti) 2006-01-13 00:48:21.000-0600

Well things should not become more complicated than with app_enum. In the current state enum lookups on several domains are painful but I don't want to force things.
By: xrobau (xrobau) 2006-01-28 17:04:54.000-0600

I've recently written a macro that does multiple enum services lookups. It's on http://www.voip-info.org/wiki/view/RFC+Compliant+ENUM+Macro
By: Kevin P. Fleming (kpfleming) 2006-02-14 14:57:53.000-0600

Committed to trunk, with udpate to UPGRADE.txt. I think it makes more sense to rely on the documented defaults in the config file rather than something hardcoded in the function.
By: Digium Subversion (svnbot) 2008-01-15 16:46:32.000-0600

Repository: asterisk
Revision: 10047

U   trunk/UPGRADE.txt
U   trunk/doc/enum.txt
U   trunk/funcs/func_enum.c

------------------------------------------------------------------------
r10047 | kpfleming | 2008-01-15 16:46:31 -0600 (Tue, 15 Jan 2008) | 2 lines

don't force a default zone for ENUM() lookups, use the configuration file (issue ASTERISK-5877, with update to UPGRADE.txt)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=10047