| Summary: | ASTERISK-05876: [patch] Asterisk sends 403 instead of 401 after receiving auth data with incorrect password | ||
| Reporter: | maik (maik) | Labels: | |
| Date Opened: | 2005-12-20 13:54:48.000-0600 | Date Closed: | 2008-01-15 16:30:31.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Interoperability |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) sip-auth-401.patch | |
| Description: | I found this bug after trying to get the logon wizzard of the snom phones working. The phone will not ask directly for a password. It will try to authenticate with an empty password first and if it receives a 401 it will ask the user. But if a 403 is received the phone will stop trying to authenticate for a while. According to RFC3261 a 403 means: "The server understood the request, but is refusing to fulfill it. Authorization will not help, and the request SHOULD NOT be repeated." So the phone obviously does what it is told to do. :) Unfortunately the RFC3261 does not say what to do when an incorrect password was used (at least I couldn't find anything about it) so I had a look at RFC2616 (HTTP 1.1) which is mentioned in the reference section of RFC3261. There I found the following sentence (section 10.4.2): "... If the request already included Authorization credentials, then the 401 response indicates that authorization has been refused for those credentials. ..." So 401 should be the right thing to send in this situtaion. ****** ADDITIONAL INFORMATION ****** Patch works for HEAD and 1.2.1 | ||
| Comments: | By: Olle Johansson (oej) 2005-12-21 02:43:20.000-0600 Interesting. I believe you are right in this. I kind of change my opinion on how to handle bad authentications... Let me look at this. By: delvar (delvar) 2006-01-09 07:09:24.000-0600 hi, i backported this patch to 1.0.10 and it seems to work very well. its prety simple and helps us a lot with hotdesking at this customers site, thanks. will this make it into asterisk propper? By: Olle Johansson (oej) 2006-01-30 04:34:19.000-0600 Still on my todo-list. /Olle By: Olle Johansson (oej) 2006-01-30 12:10:21.000-0600 Change committed to svn trunk, revision 8925. Will not change 1.2. Used something similar to your patch. Thank you for your contribution to Asterisk and a good bug report! /Olle By: Olle Johansson (oej) 2006-01-30 12:12:59.000-0600 Implementing the 403 was originally my code. You are right, it's not easy to understand all the intertwined RFCs in regards to SIP/HTTP digest authentication... By: Digium Subversion (svnbot) 2008-01-15 16:29:02.000-0600 Repository: asterisk Revision: 8925 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r8925 | oej | 2008-01-15 16:29:02 -0600 (Tue, 15 Jan 2008) | 3 lines Issue ASTERISK-5876 - Don't send 403 on bad auth (correcting one of my old mistakes...) Reported by maik. Patch inspired by, but not the patch in the bug tracker. ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8925 By: Digium Subversion (svnbot) 2008-01-15 16:29:46.000-0600 Repository: asterisk Revision: 8971 _U team/oej/multiparking/ U team/oej/multiparking/.cleancount U team/oej/multiparking/UPGRADE.txt U team/oej/multiparking/apps/app_meetme.c U team/oej/multiparking/channels/chan_sip.c U team/oej/multiparking/channels/chan_zap.c U team/oej/multiparking/configs/sip.conf.sample U team/oej/multiparking/include/asterisk/channel.h ------------------------------------------------------------------------ r8971 | oej | 2008-01-15 16:29:45 -0600 (Tue, 15 Jan 2008) | 76 lines Merged revisions 8896,8906,8919,8925-8926,8932,8938,8948-8949,8961 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8896 | oej | 2006-01-30 15:12:39 +0100 (Mon, 30 Jan 2006) | 2 lines Document installation changes for BSD users. ................ r8906 | kpfleming | 2006-01-30 18:09:55 +0100 (Mon, 30 Jan 2006) | 10 lines Merged revisions 8905 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8905 | kpfleming | 2006-01-30 11:08:28 -0600 (Mon, 30 Jan 2006) | 2 lines disable buggy PRI user-user code until it can be fixed ........ ................ r8919 | oej | 2006-01-30 19:51:02 +0100 (Mon, 30 Jan 2006) | 6 lines Issue ASTERISK-5643 - simplification of check_auth - constifications - whitespace changes Rizzo's patch with some changes ................ r8925 | oej | 2006-01-30 20:09:08 +0100 (Mon, 30 Jan 2006) | 3 lines Issue ASTERISK-5876 - Don't send 403 on bad auth (correcting one of my old mistakes...) Reported by maik. Patch inspired by, but not the patch in the bug tracker. ................ r8926 | oej | 2006-01-30 20:50:39 +0100 (Mon, 30 Jan 2006) | 2 lines Issue 5892: Set a minimum T1 timer for calls. Reporter: twisted ................ r8932 | oej | 2006-01-30 21:36:38 +0100 (Mon, 30 Jan 2006) | 8 lines - Doxygen and comments updates - Moving structure declarations to top of file with the rest - Adding some forward declarations for RTP interface functions (All these changes to position in file are in preparation for splitting chan_sip up into several files at some point in the future) ................ r8938 | mogorman | 2006-01-30 22:16:43 +0100 (Mon, 30 Jan 2006) | 3 lines reverting blocks 9 and 10 from revision 7547 fixes bug 6080 ................ r8948 | kpfleming | 2006-01-31 01:17:43 +0100 (Tue, 31 Jan 2006) | 2 lines increment for recent ast_channel change ................ r8949 | russell | 2006-01-31 01:24:34 +0100 (Tue, 31 Jan 2006) | 3 lines add a note to hopefully decrease the chance that someone forgets to increment .cleancount after changing the ast_channel structure ................ r8961 | kpfleming | 2006-01-31 04:45:09 +0100 (Tue, 31 Jan 2006) | 2 lines Yes Virginia, Zaptel does support native ALAW ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8971 By: Digium Subversion (svnbot) 2008-01-15 16:29:56.000-0600 Repository: asterisk Revision: 8981 _U team/oej/astum/ U team/oej/astum/.cleancount U team/oej/astum/Makefile U team/oej/astum/UPGRADE.txt U team/oej/astum/apps/app_dial.c U team/oej/astum/apps/app_externalivr.c U team/oej/astum/apps/app_meetme.c U team/oej/astum/ast_expr2.c U team/oej/astum/ast_expr2.h U team/oej/astum/ast_expr2f.c U team/oej/astum/channel.c U team/oej/astum/channels/chan_agent.c U team/oej/astum/channels/chan_features.c U team/oej/astum/channels/chan_iax2.c U team/oej/astum/channels/chan_sip.c U team/oej/astum/channels/chan_zap.c U team/oej/astum/configs/sip.conf.sample U team/oej/astum/funcs/func_md5.c U team/oej/astum/include/asterisk/channel.h U team/oej/astum/include/asterisk/frame.h U team/oej/astum/include/asterisk/stringfields.h U team/oej/astum/pbx.c U team/oej/astum/res/Makefile U team/oej/astum/utils.c ------------------------------------------------------------------------ r8981 | oej | 2008-01-15 16:29:55 -0600 (Tue, 15 Jan 2008) | 277 lines Merged revisions 8687,8697,8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883,8896,8906,8919,8925-8926,8932,8938,8948-8949,8961,8976 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8687 | russell | 2006-01-25 21:02:12 +0100 (Wed, 25 Jan 2006) | 2 lines use arg parsing macros for WaitExten and Background (issue ASTERISK-6028) ................ r8697 | kpfleming | 2006-01-26 05:00:05 +0100 (Thu, 26 Jan 2006) | 4 lines string field manager improvements: use multiple memory blocks, instead of realloc(), ensuring that field pointers will never become invalid or change don't run vs(n)printf twice when doing a field build unless required ................ r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines Merged revisions 8710 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines Issue 5898: Registrations does not get deleted if there's an active SIP dialog ........ ................ r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines Add some debugging output when reloading, to be able to follow progress at high debug levels ................ r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines store conference list using linked list macros (issue ASTERISK-6167) ................ r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines Code clean up, inspired by rizzo's comments in issue 5978. - Don't check for ignore if ignore is always negative - Add comments to explain what's going on ................ r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines Merged revisions 8729 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines fix problem with dtmf on e&m (issue ASTERISK-6203) ........ ................ r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines Issue ASTERISK-5799 revisited. Thanks rizzo. ................ r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines Formatting fixes, speling eror fiksd ;-) ................ r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059) ................ r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines - Move two functions to static that wasn't for some reason - Add doxygen comments - Remove un-needed assignment at declaration of variable - Formatting fixes (whitespace) - Add optin_debug in front of complex debugging output - Move forward declarations of functions to top of file - Fix error message for bad allocation in sip registry (Note: Review to line 6050 in this too large file) ................ r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059) ................ r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines Merged revisions 8758 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files ........ ................ r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines add /usr/local/lib to SOLINK (issue ASTERISK-6163) ................ r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines remove some more redundant flags ................ r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines Merged revisions 8785 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines Issue 6362 - Register without Contact: and Expires: fails (reporter: op) ........ ................ r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188) ................ r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines Blocking revision 8808 from trunk. It's already fixed in trunk. ................ r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines Simplify code for building Call ID's, create generic random string function ................ r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines - Moving forward declarations to one block - Moving global variables to one block - Moving global networking variables to one block - Small whitespace changes - Renaming a few more global channel settings to global_ for clarity (No functional changes) ................ r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines Doxygen updates ................ r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines Change booleans to TRUE/FALSE. (At some point we should implement these as enums to simplify debugging) ................ r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines - Remove unused "resetinvite" variable - Use TRUE/FALSE for fastrestart ................ r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines make ast_read() able to handle channel read()/exception() methods that return a chain of frames cleanup code in ast_read() add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate ................ r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines add channel-driver callbacks for variable length DTMF teach ast_write() to call those new callbacks ................ r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events) ................ r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines Merge Rizzo's waitfor update (bug ASTERISK-4468) ................ r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines Bug 6378 - deprecate CHECK_MD5 function ................ r8896 | oej | 2006-01-30 15:12:39 +0100 (Mon, 30 Jan 2006) | 2 lines Document installation changes for BSD users. ................ r8906 | kpfleming | 2006-01-30 18:09:55 +0100 (Mon, 30 Jan 2006) | 10 lines Merged revisions 8905 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8905 | kpfleming | 2006-01-30 11:08:28 -0600 (Mon, 30 Jan 2006) | 2 lines disable buggy PRI user-user code until it can be fixed ........ ................ r8919 | oej | 2006-01-30 19:51:02 +0100 (Mon, 30 Jan 2006) | 6 lines Issue ASTERISK-5643 - simplification of check_auth - constifications - whitespace changes Rizzo's patch with some changes ................ r8925 | oej | 2006-01-30 20:09:08 +0100 (Mon, 30 Jan 2006) | 3 lines Issue ASTERISK-5876 - Don't send 403 on bad auth (correcting one of my old mistakes...) Reported by maik. Patch inspired by, but not the patch in the bug tracker. ................ r8926 | oej | 2006-01-30 20:50:39 +0100 (Mon, 30 Jan 2006) | 2 lines Issue 5892: Set a minimum T1 timer for calls. Reporter: twisted ................ r8932 | oej | 2006-01-30 21:36:38 +0100 (Mon, 30 Jan 2006) | 8 lines - Doxygen and comments updates - Moving structure declarations to top of file with the rest - Adding some forward declarations for RTP interface functions (All these changes to position in file are in preparation for splitting chan_sip up into several files at some point in the future) ................ r8938 | mogorman | 2006-01-30 22:16:43 +0100 (Mon, 30 Jan 2006) | 3 lines reverting blocks 9 and 10 from revision 7547 fixes bug 6080 ................ r8948 | kpfleming | 2006-01-31 01:17:43 +0100 (Tue, 31 Jan 2006) | 2 lines increment for recent ast_channel change ................ r8949 | russell | 2006-01-31 01:24:34 +0100 (Tue, 31 Jan 2006) | 3 lines add a note to hopefully decrease the chance that someone forgets to increment .cleancount after changing the ast_channel structure ................ r8961 | kpfleming | 2006-01-31 04:45:09 +0100 (Tue, 31 Jan 2006) | 2 lines Yes Virginia, Zaptel does support native ALAW ................ r8976 | oej | 2006-01-31 15:30:09 +0100 (Tue, 31 Jan 2006) | 3 lines - Change "prefs" to "default_prefs" and move declaration to "default" group - Add doxygen comments ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8981 By: Digium Subversion (svnbot) 2008-01-15 16:29:58.000-0600 Repository: asterisk Revision: 8982 _U team/oej/sipregister/ U team/oej/sipregister/.cleancount U team/oej/sipregister/UPGRADE.txt U team/oej/sipregister/apps/app_meetme.c U team/oej/sipregister/channel.c U team/oej/sipregister/channels/chan_agent.c U team/oej/sipregister/channels/chan_features.c U team/oej/sipregister/channels/chan_sip.c U team/oej/sipregister/channels/chan_zap.c U team/oej/sipregister/configs/sip.conf.sample U team/oej/sipregister/funcs/func_md5.c U team/oej/sipregister/include/asterisk/channel.h U team/oej/sipregister/include/asterisk/frame.h ------------------------------------------------------------------------ r8982 | oej | 2008-01-15 16:29:57 -0600 (Tue, 15 Jan 2008) | 111 lines Merged revisions 8850-8852,8877,8883,8896,8906,8919,8925-8926,8932,8938,8948-8949,8961,8976 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines make ast_read() able to handle channel read()/exception() methods that return a chain of frames cleanup code in ast_read() add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate ................ r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines add channel-driver callbacks for variable length DTMF teach ast_write() to call those new callbacks ................ r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events) ................ r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines Merge Rizzo's waitfor update (bug ASTERISK-4468) ................ r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines Bug 6378 - deprecate CHECK_MD5 function ................ r8896 | oej | 2006-01-30 15:12:39 +0100 (Mon, 30 Jan 2006) | 2 lines Document installation changes for BSD users. ................ r8906 | kpfleming | 2006-01-30 18:09:55 +0100 (Mon, 30 Jan 2006) | 10 lines Merged revisions 8905 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8905 | kpfleming | 2006-01-30 11:08:28 -0600 (Mon, 30 Jan 2006) | 2 lines disable buggy PRI user-user code until it can be fixed ........ ................ r8919 | oej | 2006-01-30 19:51:02 +0100 (Mon, 30 Jan 2006) | 6 lines Issue ASTERISK-5643 - simplification of check_auth - constifications - whitespace changes Rizzo's patch with some changes ................ r8925 | oej | 2006-01-30 20:09:08 +0100 (Mon, 30 Jan 2006) | 3 lines Issue ASTERISK-5876 - Don't send 403 on bad auth (correcting one of my old mistakes...) Reported by maik. Patch inspired by, but not the patch in the bug tracker. ................ r8926 | oej | 2006-01-30 20:50:39 +0100 (Mon, 30 Jan 2006) | 2 lines Issue 5892: Set a minimum T1 timer for calls. Reporter: twisted ................ r8932 | oej | 2006-01-30 21:36:38 +0100 (Mon, 30 Jan 2006) | 8 lines - Doxygen and comments updates - Moving structure declarations to top of file with the rest - Adding some forward declarations for RTP interface functions (All these changes to position in file are in preparation for splitting chan_sip up into several files at some point in the future) ................ r8938 | mogorman | 2006-01-30 22:16:43 +0100 (Mon, 30 Jan 2006) | 3 lines reverting blocks 9 and 10 from revision 7547 fixes bug 6080 ................ r8948 | kpfleming | 2006-01-31 01:17:43 +0100 (Tue, 31 Jan 2006) | 2 lines increment for recent ast_channel change ................ r8949 | russell | 2006-01-31 01:24:34 +0100 (Tue, 31 Jan 2006) | 3 lines add a note to hopefully decrease the chance that someone forgets to increment .cleancount after changing the ast_channel structure ................ r8961 | kpfleming | 2006-01-31 04:45:09 +0100 (Tue, 31 Jan 2006) | 2 lines Yes Virginia, Zaptel does support native ALAW ................ r8976 | oej | 2006-01-31 15:30:09 +0100 (Tue, 31 Jan 2006) | 3 lines - Change "prefs" to "default_prefs" and move declaration to "default" group - Add doxygen comments ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8982 By: Digium Subversion (svnbot) 2008-01-15 16:30:31.000-0600 Repository: asterisk Revision: 9015 _U team/oej/sipdiversion/ U team/oej/sipdiversion/.cleancount U team/oej/sipdiversion/apps/app_meetme.c U team/oej/sipdiversion/channel.c U team/oej/sipdiversion/channels/chan_agent.c U team/oej/sipdiversion/channels/chan_features.c U team/oej/sipdiversion/channels/chan_h323.c U team/oej/sipdiversion/channels/chan_iax2.c U team/oej/sipdiversion/channels/chan_local.c U team/oej/sipdiversion/channels/chan_mgcp.c U team/oej/sipdiversion/channels/chan_sip.c U team/oej/sipdiversion/channels/chan_zap.c U team/oej/sipdiversion/configs/sip.conf.sample U team/oej/sipdiversion/frame.c U team/oej/sipdiversion/include/asterisk/channel.h U team/oej/sipdiversion/include/asterisk/frame.h U team/oej/sipdiversion/rtp.c U team/oej/sipdiversion/udptl.c ------------------------------------------------------------------------ r9015 | oej | 2008-01-15 16:30:31 -0600 (Tue, 15 Jan 2008) | 101 lines Merged revisions 8906,8919,8925-8926,8932,8938,8948-8949,8961,8976,8991,9001,9004,9013 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8906 | kpfleming | 2006-01-30 18:09:55 +0100 (Mon, 30 Jan 2006) | 10 lines Merged revisions 8905 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8905 | kpfleming | 2006-01-30 11:08:28 -0600 (Mon, 30 Jan 2006) | 2 lines disable buggy PRI user-user code until it can be fixed ........ ................ r8919 | oej | 2006-01-30 19:51:02 +0100 (Mon, 30 Jan 2006) | 6 lines Issue ASTERISK-5643 - simplification of check_auth - constifications - whitespace changes Rizzo's patch with some changes ................ r8925 | oej | 2006-01-30 20:09:08 +0100 (Mon, 30 Jan 2006) | 3 lines Issue ASTERISK-5876 - Don't send 403 on bad auth (correcting one of my old mistakes...) Reported by maik. Patch inspired by, but not the patch in the bug tracker. ................ r8926 | oej | 2006-01-30 20:50:39 +0100 (Mon, 30 Jan 2006) | 2 lines Issue 5892: Set a minimum T1 timer for calls. Reporter: twisted ................ r8932 | oej | 2006-01-30 21:36:38 +0100 (Mon, 30 Jan 2006) | 8 lines - Doxygen and comments updates - Moving structure declarations to top of file with the rest - Adding some forward declarations for RTP interface functions (All these changes to position in file are in preparation for splitting chan_sip up into several files at some point in the future) ................ r8938 | mogorman | 2006-01-30 22:16:43 +0100 (Mon, 30 Jan 2006) | 3 lines reverting blocks 9 and 10 from revision 7547 fixes bug 6080 ................ r8948 | kpfleming | 2006-01-31 01:17:43 +0100 (Tue, 31 Jan 2006) | 2 lines increment for recent ast_channel change ................ r8949 | russell | 2006-01-31 01:24:34 +0100 (Tue, 31 Jan 2006) | 3 lines add a note to hopefully decrease the chance that someone forgets to increment .cleancount after changing the ast_channel structure ................ r8961 | kpfleming | 2006-01-31 04:45:09 +0100 (Tue, 31 Jan 2006) | 2 lines Yes Virginia, Zaptel does support native ALAW ................ r8976 | oej | 2006-01-31 15:30:09 +0100 (Tue, 31 Jan 2006) | 3 lines - Change "prefs" to "default_prefs" and move declaration to "default" group - Add doxygen comments ................ r8991 | oej | 2006-01-31 17:02:35 +0100 (Tue, 31 Jan 2006) | 4 lines - Moving two session (PVT) flags to peer PAGE2 (DYNAMIC and SELFDESTRUCT) to make room for more session-related flags This is needed for integrating patches in the bug tracker - Adding doxygen comments ................ r9001 | russell | 2006-01-31 18:18:58 +0100 (Tue, 31 Jan 2006) | 3 lines define a global null_frame object so when queueing a null frame, you don't have to allocate one on the stack ................ r9004 | russell | 2006-01-31 18:57:12 +0100 (Tue, 31 Jan 2006) | 2 lines remove some more local declarations of null frames ................ r9013 | oej | 2006-01-31 19:40:07 +0100 (Tue, 31 Jan 2006) | 3 lines Optimize settings of defaults for a new peer object and make sure we set the same defaults for autocreated peers and other peers. ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=9015 | ||