Summary: | ASTERISK-05866: [patch] two duplicated statements in chan_sip.c and a comment | ||
Reporter: | Luigi Rizzo (rizzo) | Labels: | |
Date Opened: | 2005-12-18 12:00:52.000-0600 | Date Closed: | 2008-01-15 16:15:24.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | * function sip_new() calls ast_mutex_lock() twice near the beginning. I think the second one (after the comment 'Select our native...') is useless (although probably harmless) and should be removd. * the prototype for sip_read() in the beginning of the file is repeated twice. Again, the second instance is useless and should be removed; * the code handling the array sip_methods[] makes the assumption indicated in the comment below. Since the initializer does not guarantee that the assumption holds, it would be appropriate to add the following comment right before the array. /* XXX note that sip_methods[i].id == i must hold or the code breaks */ | ||
Comments: | By: Russell Bryant (russell) 2005-12-19 16:10:15.000-0600 Would it make more sense to remove the first call to ast_mutex_lock in sip_new since directly after it, we will return immediately without unlocking if the channel allocation failed. See my proposed patch ... By: Luigi Rizzo (rizzo) 2005-12-19 16:30:02.000-0600 Given that the function is called with "i" locked, it must always return with the channel locked, so the first lock must stay. It is the ast_mutex_lock/ast_mutex_unlock pair around the format selection that has to go. Note, this is harmless because the lock is "recursive" (it has a counter associated) so one extra lock/unlock doesn't harm, but it is useless and confusing. Not to mention (not here, but it must be considered elsewhere), that the trick of calling ast_mutex_unlock() to make sure the lock is dropped and prevent deadlock doesn't work if there are extra lock/unlock calls. The first two chunks of your patch are ok. By: Russell Bryant (russell) 2005-12-19 16:46:30.000-0600 thanks :) fixed in 1.2 and the trunk By: Digium Subversion (svnbot) 2008-01-15 16:07:27.000-0600 Repository: asterisk Revision: 7528 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r7528 | russell | 2008-01-15 16:07:27 -0600 (Tue, 15 Jan 2008) | 4 lines - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7528 By: Digium Subversion (svnbot) 2008-01-15 16:07:28.000-0600 Repository: asterisk Revision: 7529 U branches/1.2/channels/chan_sip.c ------------------------------------------------------------------------ r7529 | russell | 2008-01-15 16:07:28 -0600 (Tue, 15 Jan 2008) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7529 By: Digium Subversion (svnbot) 2008-01-15 16:07:49.000-0600 Repository: asterisk Revision: 7553 _U team/russell/agent_function/ U team/russell/agent_function/apps/app_chanspy.c U team/russell/agent_function/apps/app_dial.c U team/russell/agent_function/apps/app_directed_pickup.c U team/russell/agent_function/apps/app_meetme.c U team/russell/agent_function/build_tools/make_svn_branch_name U team/russell/agent_function/cdr.c U team/russell/agent_function/channel.c U team/russell/agent_function/channels/Makefile U team/russell/agent_function/channels/chan_iax2.c U team/russell/agent_function/channels/chan_mgcp.c U team/russell/agent_function/channels/chan_sip.c U team/russell/agent_function/codecs/Makefile U team/russell/agent_function/codecs/codec_gsm.c U team/russell/agent_function/doc/README.ael U team/russell/agent_function/file.c U team/russell/agent_function/frame.c U team/russell/agent_function/include/asterisk/channel.h U team/russell/agent_function/include/asterisk/frame.h U team/russell/agent_function/include/asterisk/linkedlists.h U team/russell/agent_function/include/asterisk/rtp.h U team/russell/agent_function/rtp.c ------------------------------------------------------------------------ r7553 | russell | 2008-01-15 16:07:49 -0600 (Tue, 15 Jan 2008) | 129 lines Merged revisions 7509,7511-7512,7514,7516,7518,7520,7522,7524,7528,7538-7542,7547-7548,7551 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7509 | tilghman | 2005-12-16 20:07:44 -0500 (Fri, 16 Dec 2005) | 3 lines Merged revisions 7508 via svnmerge from /branches/1.2 ................ r7511 | kpfleming | 2005-12-16 21:21:36 -0500 (Fri, 16 Dec 2005) | 2 lines block a commit to a module that no longer exists in trunk ................ r7512 | kpfleming | 2005-12-16 21:22:24 -0500 (Fri, 16 Dec 2005) | 10 lines Merged revision 7510 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7510 | kpfleming | 2005-12-16 20:20:04 -0600 (Fri, 16 Dec 2005) | 2 lines fix some buglet when building team branch version strings ........ ................ r7514 | kpfleming | 2005-12-16 22:45:25 -0500 (Fri, 16 Dec 2005) | 10 lines Merged revisions 7513 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7513 | kpfleming | 2005-12-16 21:44:30 -0600 (Fri, 16 Dec 2005) | 2 lines forcibly expire previous subscriptions from a peer when they resubscribe (keeps them from building up and waiting for expiration, and stops us sending unwanted NOTIFY messages to devices) ........ ................ r7516 | kpfleming | 2005-12-16 22:59:27 -0500 (Fri, 16 Dec 2005) | 10 lines Merged revisions 7515 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7515 | kpfleming | 2005-12-16 21:59:05 -0600 (Fri, 16 Dec 2005) | 2 lines Max-Forwards headers must only be present on requests, not responses ........ ................ r7518 | tilghman | 2005-12-17 12:22:24 -0500 (Sat, 17 Dec 2005) | 3 lines Merged revisions 7517 via svnmerge from /branches/1.2 ................ r7520 | tilghman | 2005-12-17 13:58:57 -0500 (Sat, 17 Dec 2005) | 3 lines Merged revisions 7519 via svnmerge from /branches/1.2 ................ r7522 | tilghman | 2005-12-19 00:42:55 -0500 (Mon, 19 Dec 2005) | 3 lines Merged revisions 7521 via svnmerge from /branches/1.2 ................ r7524 | tilghman | 2005-12-19 14:08:42 -0500 (Mon, 19 Dec 2005) | 3 lines Merged revisions 7523 via svnmerge from /branches/1.2 ................ r7528 | russell | 2005-12-19 18:41:53 -0500 (Mon, 19 Dec 2005) | 4 lines - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ................ r7538 | russell | 2005-12-20 02:45:05 -0500 (Tue, 20 Dec 2005) | 3 lines allow forcing the build to exclude PRI support using WITHOUT_PRI, similar to how we already have WITHOUT_ZAPTEL (issue ASTERISK-5829) ................ r7539 | russell | 2005-12-20 03:16:53 -0500 (Tue, 20 Dec 2005) | 2 lines use the system libgsm if available (issue ASTERISK-5287, modified to still work with builtin libgsm) ................ r7540 | markster | 2005-12-20 04:39:31 -0500 (Tue, 20 Dec 2005) | 2 lines Fix reload of peer contexts (bug ASTERISK-5848) ................ r7541 | markster | 2005-12-20 04:56:55 -0500 (Tue, 20 Dec 2005) | 2 lines Fix segfault on directed pickup when no CDR is available (bug ASTERISK-5839) ................ r7542 | markster | 2005-12-20 05:26:53 -0500 (Tue, 20 Dec 2005) | 2 lines Fix choppy audio with > 20ms audio frames (bug ASTERISK-5548) ................ r7547 | markster | 2005-12-20 08:07:02 -0500 (Tue, 20 Dec 2005) | 3 lines Major peformance improvements to meetme ................ r7548 | markster | 2005-12-20 09:14:01 -0500 (Tue, 20 Dec 2005) | 2 lines Don't bother decode on muted participants ................ r7551 | markster | 2005-12-20 12:52:31 -0500 (Tue, 20 Dec 2005) | 3 lines Major RTP fixes for using inbound SDP on outbound connection, get rid of old local rtp stuff... ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7553 By: Digium Subversion (svnbot) 2008-01-15 16:07:59.000-0600 Repository: asterisk Revision: 7564 _U team/crichter/0.3.0/ U team/crichter/0.3.0/apps/app_chanspy.c U team/crichter/0.3.0/apps/app_dial.c U team/crichter/0.3.0/apps/app_directed_pickup.c U team/crichter/0.3.0/apps/app_meetme.c U team/crichter/0.3.0/build_tools/make_svn_branch_name U team/crichter/0.3.0/cdr.c U team/crichter/0.3.0/channel.c U team/crichter/0.3.0/channels/Makefile U team/crichter/0.3.0/channels/chan_agent.c U team/crichter/0.3.0/channels/chan_iax2.c U team/crichter/0.3.0/channels/chan_mgcp.c U team/crichter/0.3.0/channels/chan_sip.c U team/crichter/0.3.0/cli.c U team/crichter/0.3.0/codecs/Makefile U team/crichter/0.3.0/codecs/codec_gsm.c U team/crichter/0.3.0/doc/README.ael U team/crichter/0.3.0/file.c U team/crichter/0.3.0/frame.c U team/crichter/0.3.0/include/asterisk/channel.h U team/crichter/0.3.0/include/asterisk/frame.h U team/crichter/0.3.0/include/asterisk/linkedlists.h U team/crichter/0.3.0/include/asterisk/rtp.h U team/crichter/0.3.0/include/asterisk/strings.h U team/crichter/0.3.0/res/res_agi.c U team/crichter/0.3.0/rtp.c U team/crichter/0.3.0/utils.c ------------------------------------------------------------------------ r7564 | crichter | 2008-01-15 16:07:58 -0600 (Tue, 15 Jan 2008) | 144 lines Merged revisions 7509,7511-7512,7514,7516,7518,7520,7522,7524,7528,7538-7542,7547-7548,7551,7554,7556 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7509 | tilghman | 2005-12-17 02:07:44 +0100 (Sa, 17 Dez 2005) | 3 lines Merged revisions 7508 via svnmerge from /branches/1.2 ................ r7511 | kpfleming | 2005-12-17 03:21:36 +0100 (Sa, 17 Dez 2005) | 2 lines block a commit to a module that no longer exists in trunk ................ r7512 | kpfleming | 2005-12-17 03:22:24 +0100 (Sa, 17 Dez 2005) | 10 lines Merged revision 7510 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7510 | kpfleming | 2005-12-16 20:20:04 -0600 (Fri, 16 Dec 2005) | 2 lines fix some buglet when building team branch version strings ........ ................ r7514 | kpfleming | 2005-12-17 04:45:25 +0100 (Sa, 17 Dez 2005) | 10 lines Merged revisions 7513 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7513 | kpfleming | 2005-12-16 21:44:30 -0600 (Fri, 16 Dec 2005) | 2 lines forcibly expire previous subscriptions from a peer when they resubscribe (keeps them from building up and waiting for expiration, and stops us sending unwanted NOTIFY messages to devices) ........ ................ r7516 | kpfleming | 2005-12-17 04:59:27 +0100 (Sa, 17 Dez 2005) | 10 lines Merged revisions 7515 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7515 | kpfleming | 2005-12-16 21:59:05 -0600 (Fri, 16 Dec 2005) | 2 lines Max-Forwards headers must only be present on requests, not responses ........ ................ r7518 | tilghman | 2005-12-17 18:22:24 +0100 (Sa, 17 Dez 2005) | 3 lines Merged revisions 7517 via svnmerge from /branches/1.2 ................ r7520 | tilghman | 2005-12-17 19:58:57 +0100 (Sa, 17 Dez 2005) | 3 lines Merged revisions 7519 via svnmerge from /branches/1.2 ................ r7522 | tilghman | 2005-12-19 06:42:55 +0100 (Mo, 19 Dez 2005) | 3 lines Merged revisions 7521 via svnmerge from /branches/1.2 ................ r7524 | tilghman | 2005-12-19 20:08:42 +0100 (Mo, 19 Dez 2005) | 3 lines Merged revisions 7523 via svnmerge from /branches/1.2 ................ r7528 | russell | 2005-12-20 00:41:53 +0100 (Di, 20 Dez 2005) | 4 lines - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ................ r7538 | russell | 2005-12-20 08:45:05 +0100 (Di, 20 Dez 2005) | 3 lines allow forcing the build to exclude PRI support using WITHOUT_PRI, similar to how we already have WITHOUT_ZAPTEL (issue ASTERISK-5829) ................ r7539 | russell | 2005-12-20 09:16:53 +0100 (Di, 20 Dez 2005) | 2 lines use the system libgsm if available (issue ASTERISK-5287, modified to still work with builtin libgsm) ................ r7540 | markster | 2005-12-20 10:39:31 +0100 (Di, 20 Dez 2005) | 2 lines Fix reload of peer contexts (bug ASTERISK-5848) ................ r7541 | markster | 2005-12-20 10:56:55 +0100 (Di, 20 Dez 2005) | 2 lines Fix segfault on directed pickup when no CDR is available (bug ASTERISK-5839) ................ r7542 | markster | 2005-12-20 11:26:53 +0100 (Di, 20 Dez 2005) | 2 lines Fix choppy audio with > 20ms audio frames (bug ASTERISK-5548) ................ r7547 | markster | 2005-12-20 14:07:02 +0100 (Di, 20 Dez 2005) | 3 lines Major peformance improvements to meetme ................ r7548 | markster | 2005-12-20 15:14:01 +0100 (Di, 20 Dez 2005) | 2 lines Don't bother decode on muted participants ................ r7551 | markster | 2005-12-20 18:52:31 +0100 (Di, 20 Dez 2005) | 3 lines Major RTP fixes for using inbound SDP on outbound connection, get rid of old local rtp stuff... ................ r7554 | russell | 2005-12-20 20:56:52 +0100 (Di, 20 Dez 2005) | 2 lines add AGENT function, similar to SIPPEER or IAXPEER (issue ASTERISK-5383) ................ r7556 | russell | 2005-12-20 21:20:04 +0100 (Di, 20 Dez 2005) | 7 lines - move the string join() function to utils.c since it is used in both cli.c and res_agi.c - reimplement ast_join to be of linear effieciency instead of quadratic - remove some useless checks for "if (e)" - reorder checks for strings starting with '_' to avoid a useless call to ast_join() - check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7564 By: Digium Subversion (svnbot) 2008-01-15 16:13:30.000-0600 Repository: asterisk Revision: 7934 _U team/oej/metermaids/ U team/oej/metermaids/apps/app_voicemail.c U team/oej/metermaids/channels/Makefile U team/oej/metermaids/channels/chan_sip.c A team/oej/metermaids/channels/misdn/mISDN.patch A team/oej/metermaids/channels/misdn/mISDNuser.patch U team/oej/metermaids/doc/README.variables U team/oej/metermaids/pbx/pbx_spool.c U team/oej/metermaids/res/res_agi.c ------------------------------------------------------------------------ r7934 | oej | 2008-01-15 16:13:29 -0600 (Tue, 15 Jan 2008) | 145 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812,7870-7871,7898-7900,7904,7908 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Thu, 15 Dec 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sat, 17 Dec 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Tue, 20 Dec 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Tue, 20 Dec 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Wed, 21 Dec 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Wed, 21 Dec 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Thu, 22 Dec 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fri, 23 Dec 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mon, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Tue, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Wed, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Thu, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mon, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mon, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7904 | tilghman | 2006-01-09 19:37:50 +0100 (Mon, 09 Jan 2006) | 2 lines Update variable documentation to match the code ........ r7908 | tilghman | 2006-01-09 21:08:24 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6157 - Memory leak ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7934 By: Digium Subversion (svnbot) 2008-01-15 16:13:35.000-0600 Repository: asterisk Revision: 7938 _U team/oej/managerstuff/ U team/oej/managerstuff/apps/app_voicemail.c U team/oej/managerstuff/channels/chan_iax2.c U team/oej/managerstuff/channels/chan_sip.c A team/oej/managerstuff/channels/misdn/mISDN.patch A team/oej/managerstuff/channels/misdn/mISDNuser.patch U team/oej/managerstuff/doc/README.variables U team/oej/managerstuff/file.c U team/oej/managerstuff/pbx/pbx_spool.c ------------------------------------------------------------------------ r7938 | oej | 2008-01-15 16:13:35 -0600 (Tue, 15 Jan 2008) | 155 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812,7870-7871,7898-7900,7904,7908,7915,7917 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Thu, 15 Dec 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sat, 17 Dec 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Tue, 20 Dec 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Tue, 20 Dec 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Wed, 21 Dec 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Wed, 21 Dec 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Thu, 22 Dec 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fri, 23 Dec 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mon, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Tue, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Wed, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Thu, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mon, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mon, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7904 | tilghman | 2006-01-09 19:37:50 +0100 (Mon, 09 Jan 2006) | 2 lines Update variable documentation to match the code ........ r7908 | tilghman | 2006-01-09 21:08:24 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6157 - Memory leak ........ r7915 | russell | 2006-01-09 23:07:26 +0100 (Mon, 09 Jan 2006) | 2 lines add missing unlock (issue ASTERISK-5954) ........ r7917 | kpfleming | 2006-01-09 23:48:48 +0100 (Mon, 09 Jan 2006) | 2 lines re-initialize _all_ sequence numbers when transfer completes ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7938 By: Digium Subversion (svnbot) 2008-01-15 16:15:22.000-0600 Repository: asterisk Revision: 8054 _U team/crichter/0.3.0/ ------------------------------------------------------------------------ r8054 | crichter | 2008-01-15 16:15:22 -0600 (Tue, 15 Jan 2008) | 110 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Do, 15 Dez 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sa, 17 Dez 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Di, 20 Dez 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Di, 20 Dez 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Mi, 21 Dez 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Mi, 21 Dez 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Do, 22 Dez 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fr, 23 Dez 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Di, 27 Dez 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Di, 27 Dez 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mo, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Di, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Mi, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Mi, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Do, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8054 By: Digium Subversion (svnbot) 2008-01-15 16:15:24.000-0600 Repository: asterisk Revision: 8055 _U team/crichter/frame-data/ U team/crichter/frame-data/apps/app_voicemail.c U team/crichter/frame-data/channel.c U team/crichter/frame-data/channels/chan_agent.c U team/crichter/frame-data/configs/voicemail.conf.sample ------------------------------------------------------------------------ r8055 | crichter | 2008-01-15 16:15:24 -0600 (Tue, 15 Jan 2008) | 246 lines Merged revisions 8053-8054 via svnmerge from https://origsvn.digium.com/svn/asterisk/team/crichter/0.3.0 ................ r8053 | crichter | 2006-01-13 12:03:35 +0100 (Fr, 13 Jan 2006) | 125 lines Merged revisions 7870-7871,7898-7900,7963,7973-7975,7977-8051 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mo, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mo, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mo, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mo, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mo, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7963 | mogorman | 2006-01-11 05:38:07 +0100 (Mi, 11 Jan 2006) | 2 lines Minor typo refrenced in 6191 ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ r7986 | russell | 2006-01-11 20:08:53 +0100 (Mi, 11 Jan 2006) | 2 lines move variable to correct scope (issue ASTERISK-6040) ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ r7999 | tilghman | 2006-01-12 07:14:22 +0100 (Do, 12 Jan 2006) | 2 lines Bug 6211 - Add option deletevoicemail as equivalent to option delete for Realtime ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ r8047 | russell | 2006-01-13 07:07:39 +0100 (Fr, 13 Jan 2006) | 2 lines fix spelling errors (issue ASTERISK-6069) ........ ........ ........ ........ ........ ................ r8054 | crichter | 2006-01-13 14:00:07 +0100 (Fr, 13 Jan 2006) | 110 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Do, 15 Dez 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sa, 17 Dez 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Di, 20 Dez 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Di, 20 Dez 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Mi, 21 Dez 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Mi, 21 Dez 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Do, 22 Dez 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fr, 23 Dez 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Di, 27 Dez 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Di, 27 Dez 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mo, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Di, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Mi, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Mi, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Do, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8055 |