[Home]

Summary:ASTERISK-05863: [patch] Port of codec libs to MSVC, + fix some bugs and warnings in those libs.
Reporter:Michael Jerris (mikej)Labels:
Date Opened:2005-12-17 22:28:29.000-0600Date Closed:2008-01-15 16:37:03.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) AsteriskCodecMSVCPort.diff
Description:This patch include msvc project files for the gsm, lpc10, and ilbc libs, along with fixing all warnings in those libs (mostly casting) and fixing a potential devide by zero bug.
Comments:By: Tilghman Lesher (tilghman) 2005-12-17 23:07:51.000-0600

Could you separate these out into 3 different patches?  One for new project files, one for casting, and one for the bugfix that you identified?

The bugfix can go into 1.2, the others are confined to trunk.
By: Michael Jerris (mikej) 2005-12-17 23:54:19.000-0600

The bug fix is the first hunk of codecs/lpc10/f2clib.c, should be pretty obvious on inspection.  Not really sure the purpose for breaking it up into 3 different patches... If you don't want the project files, feel free to not commit them, the rest is the warnings and a couple small ifdefs to compile on msvc.
By: Russell Bryant (russell) 2005-12-20 12:35:34.000-0600

This at least builds successfully on linux ...
By: Michael Jerris (mikej) 2005-12-20 12:50:47.000-0600

I know.. I have gotten pulled away, I will get back to this this weekend.
By: Olle Johansson (oej) 2006-01-04 05:23:14.000-0600

MikeJ: Which weekend was that ?

:-)
By: Michael Jerris (mikej) 2006-01-04 07:24:58.000-0600

back and looking, not sure what else there was I was going to do on this... as far as I am concerned, this should be good to go.
By: Matthew Fredrickson (mattf) 2006-02-10 16:37:42.000-0600

put in trunk, thanks (I think ;-) )
By: Digium Subversion (svnbot) 2008-01-15 16:37:03.000-0600

Repository: asterisk
Revision: 9450

U   trunk/codecs/gsm/inc/private.h
A   trunk/codecs/gsm/libgsm.vcproj
U   trunk/codecs/gsm/src/add.c
U   trunk/codecs/gsm/src/code.c
U   trunk/codecs/gsm/src/decode.c
U   trunk/codecs/gsm/src/long_term.c
U   trunk/codecs/gsm/src/lpc.c
U   trunk/codecs/gsm/src/preprocess.c
U   trunk/codecs/gsm/src/rpe.c
U   trunk/codecs/gsm/src/short_term.c
A   trunk/codecs/ilbc/libilbc.vcproj
U   trunk/codecs/lpc10/bsynz.c
U   trunk/codecs/lpc10/decode.c
U   trunk/codecs/lpc10/encode.c
U   trunk/codecs/lpc10/energy.c
U   trunk/codecs/lpc10/f2clib.c
U   trunk/codecs/lpc10/irc2pc.c
A   trunk/codecs/lpc10/liblpc10.vcproj
U   trunk/codecs/lpc10/lpc10.h
U   trunk/codecs/lpc10/onset.c
U   trunk/codecs/lpc10/pitsyn.c
U   trunk/codecs/lpc10/tbdm.c
U   trunk/codecs/lpc10/voicin.c
U   trunk/codecs/lpc10/vparms.c

------------------------------------------------------------------------
r9450 | mattf | 2008-01-15 16:37:02 -0600 (Tue, 15 Jan 2008) | 2 lines

Lots of little fixes for doing MSVC compiling codecs in windows (ASTERISK-5863)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=9450