Summary: | ASTERISK-05800: [patch] removal of redundant/repeated code and formatting cleanup | ||
Reporter: | Luigi Rizzo (rizzo) | Labels: | |
Date Opened: | 2005-12-08 01:58:35.000-0600 | Date Closed: | 2011-06-07 14:10:03 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) sip1.diff | |
Description: | as in the summary, the attached patch provides the following: @@ -1078,12 +1079,12 @@ static void sip_destroy(struct sip_pvt * the same (almost) long string is constructed twice through sprintf. with this patch we construct the difference into a string and then call sprintf only once. @@ -1687,9 +1672,8 @@ static struct sip_peer *realtime_peer(co @@ -1697,7 +1681,6 @@ static struct sip_peer *realtime_peer(co @@ -1756,7 +1739,6 @@ static struct sip_peer *find_peer(const @@ -1789,17 +1771,13 @@ static struct sip_user *realtime_user(co normalize the layout of a for() loop and remove blank lines. @@ -2717,6 +2695,7 @@ static struct ast_channel *sip_new(struc @@ -2735,11 +2714,12 @@ static struct ast_channel *sip_new(struc instead of calling 3 times ast_codec_choose(), determine the correct argument and call it only once. @@ -4883,9 +4872,6 @@ static int transmit_invite(struct sip_pv @@ -4899,7 +4885,9 @@ static int transmit_invite(struct sip_pv move 3 variables to their actual scope and remove useless initializers. @@ -8585,8 +8535,9 @@ static void handle_request_info(struct s @@ -8640,7 +8591,7 @@ static void handle_request_info(struct s instead of calling get_header() 3 times, call it only once and store the result in a temporary variable for further use. @@ -11854,11 +11796,9 @@ static struct sip_user *build_user(const @@ -11913,10 +11853,6 @@ static struct sip_user *build_user(const @@ -12307,12 +12241,9 @@ static int reload_config(void) @@ -12493,10 +12424,6 @@ static int reload_config(void) normalize the spelling of two for() loops, allowing for the removal of extra v = v->next; . On passing, also remove commented out code. @@ -12237,7 +12172,6 @@ static int reload_config(void) @@ -12515,31 +12442,42 @@ static int reload_config(void) localize a variable to its actual scope; normalize the spelling of a while loop(), and remove two repeated instances of strcasecmp() by storing previous results. | ||
Comments: | By: Russell Bryant (russell) 2005-12-21 19:21:45.000-0600 merged into the trunk, thanks! By: Luigi Rizzo (rizzo) 2005-12-22 05:49:03.000-0600 watch out - in merging this patch you reintroduced one extra ast_mutex_unlock() that was part of the lock/unlock pair removed in ASTERISK-5866. Please remove it - see the inline patch below, around line 2722 in my version, some 30 lines down in sip_new(): else what = global_capability; tmp->nativeformats = ast_codec_choose(&i->prefs, what, 1); - ast_mutex_unlock(&i->lock); fmt = ast_best_codec(tmp->nativeformats); if (title) By: Russell Bryant (russell) 2005-12-22 09:08:57.000-0600 Well, it was never removed in the first place. I missed that line... Thanks for the catch! +1 for that one :) By: Digium Subversion (svnbot) 2008-01-15 16:08:19.000-0600 Repository: asterisk Revision: 7587 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r7587 | russell | 2008-01-15 16:08:19 -0600 (Tue, 15 Jan 2008) | 7 lines - construct the difference and have only one call to snprintf in build_via - convert some while loops to for loops - localize some variables and remove unneeded initializations - store result of get_header locally so it only has to be called once - remove some duplicate calls to strcasecmp by storing result (issue ASTERISK-5800) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7587 By: Digium Subversion (svnbot) 2008-01-15 16:08:25.000-0600 Repository: asterisk Revision: 7594 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r7594 | russell | 2008-01-15 16:08:24 -0600 (Tue, 15 Jan 2008) | 2 lines remove stray unlock (issue ASTERISK-5800) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7594 By: Digium Subversion (svnbot) 2008-01-15 16:08:26.000-0600 Repository: asterisk Revision: 7595 U branches/1.2/channels/chan_sip.c ------------------------------------------------------------------------ r7595 | russell | 2008-01-15 16:08:25 -0600 (Tue, 15 Jan 2008) | 2 lines remove stray unlock (issue ASTERISK-5800) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7595 By: Digium Subversion (svnbot) 2008-01-15 16:13:30.000-0600 Repository: asterisk Revision: 7934 _U team/oej/metermaids/ U team/oej/metermaids/apps/app_voicemail.c U team/oej/metermaids/channels/Makefile U team/oej/metermaids/channels/chan_sip.c A team/oej/metermaids/channels/misdn/mISDN.patch A team/oej/metermaids/channels/misdn/mISDNuser.patch U team/oej/metermaids/doc/README.variables U team/oej/metermaids/pbx/pbx_spool.c U team/oej/metermaids/res/res_agi.c ------------------------------------------------------------------------ r7934 | oej | 2008-01-15 16:13:29 -0600 (Tue, 15 Jan 2008) | 145 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812,7870-7871,7898-7900,7904,7908 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Thu, 15 Dec 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sat, 17 Dec 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Tue, 20 Dec 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Tue, 20 Dec 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Wed, 21 Dec 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Wed, 21 Dec 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Thu, 22 Dec 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fri, 23 Dec 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mon, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Tue, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Wed, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Thu, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mon, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mon, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7904 | tilghman | 2006-01-09 19:37:50 +0100 (Mon, 09 Jan 2006) | 2 lines Update variable documentation to match the code ........ r7908 | tilghman | 2006-01-09 21:08:24 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6157 - Memory leak ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7934 By: Digium Subversion (svnbot) 2008-01-15 16:13:36.000-0600 Repository: asterisk Revision: 7938 _U team/oej/managerstuff/ U team/oej/managerstuff/apps/app_voicemail.c U team/oej/managerstuff/channels/chan_iax2.c U team/oej/managerstuff/channels/chan_sip.c A team/oej/managerstuff/channels/misdn/mISDN.patch A team/oej/managerstuff/channels/misdn/mISDNuser.patch U team/oej/managerstuff/doc/README.variables U team/oej/managerstuff/file.c U team/oej/managerstuff/pbx/pbx_spool.c ------------------------------------------------------------------------ r7938 | oej | 2008-01-15 16:13:35 -0600 (Tue, 15 Jan 2008) | 155 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812,7870-7871,7898-7900,7904,7908,7915,7917 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Thu, 15 Dec 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sat, 17 Dec 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Tue, 20 Dec 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Tue, 20 Dec 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Tue, 20 Dec 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Wed, 21 Dec 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Wed, 21 Dec 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Thu, 22 Dec 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fri, 23 Dec 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Tue, 27 Dec 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mon, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Tue, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Wed, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Wed, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Thu, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mon, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mon, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mon, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mon, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7904 | tilghman | 2006-01-09 19:37:50 +0100 (Mon, 09 Jan 2006) | 2 lines Update variable documentation to match the code ........ r7908 | tilghman | 2006-01-09 21:08:24 +0100 (Mon, 09 Jan 2006) | 2 lines Bug 6157 - Memory leak ........ r7915 | russell | 2006-01-09 23:07:26 +0100 (Mon, 09 Jan 2006) | 2 lines add missing unlock (issue ASTERISK-5954) ........ r7917 | kpfleming | 2006-01-09 23:48:48 +0100 (Mon, 09 Jan 2006) | 2 lines re-initialize _all_ sequence numbers when transfer completes ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7938 By: Digium Subversion (svnbot) 2008-01-15 16:15:23.000-0600 Repository: asterisk Revision: 8054 _U team/crichter/0.3.0/ ------------------------------------------------------------------------ r8054 | crichter | 2008-01-15 16:15:22 -0600 (Tue, 15 Jan 2008) | 110 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Do, 15 Dez 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sa, 17 Dez 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Di, 20 Dez 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Di, 20 Dez 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Mi, 21 Dez 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Mi, 21 Dez 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Do, 22 Dez 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fr, 23 Dez 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Di, 27 Dez 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Di, 27 Dez 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mo, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Di, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Mi, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Mi, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Do, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8054 By: Digium Subversion (svnbot) 2008-01-15 16:15:25.000-0600 Repository: asterisk Revision: 8055 _U team/crichter/frame-data/ U team/crichter/frame-data/apps/app_voicemail.c U team/crichter/frame-data/channel.c U team/crichter/frame-data/channels/chan_agent.c U team/crichter/frame-data/configs/voicemail.conf.sample ------------------------------------------------------------------------ r8055 | crichter | 2008-01-15 16:15:24 -0600 (Tue, 15 Jan 2008) | 246 lines Merged revisions 8053-8054 via svnmerge from https://origsvn.digium.com/svn/asterisk/team/crichter/0.3.0 ................ r8053 | crichter | 2006-01-13 12:03:35 +0100 (Fr, 13 Jan 2006) | 125 lines Merged revisions 7870-7871,7898-7900,7963,7973-7975,7977-8051 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7870 | russell | 2006-01-09 05:52:16 +0100 (Mo, 09 Jan 2006) | 2 lines backport fix for unnecessary unlock (issue ASTERISK-6014) ........ r7871 | russell | 2006-01-09 06:11:44 +0100 (Mo, 09 Jan 2006) | 2 lines fix seg fault when using greek syntax in VoicemMailMain (issue ASTERISK-5878) ........ r7898 | kpfleming | 2006-01-09 19:08:07 +0100 (Mo, 09 Jan 2006) | 2 lines fix breakage introduced in revision 7871 ........ r7899 | kpfleming | 2006-01-09 19:09:53 +0100 (Mo, 09 Jan 2006) | 2 lines backport fix from revision 7856 of trunk ........ r7900 | kpfleming | 2006-01-09 19:11:23 +0100 (Mo, 09 Jan 2006) | 2 lines commit user/group-related changes from trunk ........ r7963 | mogorman | 2006-01-11 05:38:07 +0100 (Mi, 11 Jan 2006) | 2 lines Minor typo refrenced in 6191 ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ r7986 | russell | 2006-01-11 20:08:53 +0100 (Mi, 11 Jan 2006) | 2 lines move variable to correct scope (issue ASTERISK-6040) ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ r7999 | tilghman | 2006-01-12 07:14:22 +0100 (Do, 12 Jan 2006) | 2 lines Bug 6211 - Add option deletevoicemail as equivalent to option delete for Realtime ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ ........ r8047 | russell | 2006-01-13 07:07:39 +0100 (Fr, 13 Jan 2006) | 2 lines fix spelling errors (issue ASTERISK-6069) ........ ........ ........ ........ ........ ................ r8054 | crichter | 2006-01-13 14:00:07 +0100 (Fr, 13 Jan 2006) | 110 lines Merged revisions 7490,7517,7529,7546,7550,7552,7557,7580,7586,7595,7605,7641,7663,7706,7738,7771,7792,7812 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7490 | crichter | 2005-12-15 11:52:30 +0100 (Do, 15 Dez 2005) | 9 lines * Added mISDN/mISDNuser Echo cancel Patch * Fixed Makefiles so that chan_misdn can be compiled again * added some hints, that mISDN cannot be compiled against gcc-4, SMP, Spinlock Debug * fixed some Minor issues in chan_misdn, regarding Type Of Number and Presentation ........ r7517 | tilghman | 2005-12-17 18:19:32 +0100 (Sa, 17 Dez 2005) | 2 lines Bug 6009 - off by one error ........ r7529 | russell | 2005-12-20 00:47:23 +0100 (Di, 20 Dez 2005) | 5 lines I messed up and accidently committed this to the trunk first ... - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ........ r7546 | kpfleming | 2005-12-20 13:58:37 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for larger-than-20ms-frames from trunk (bug ASTERISK-5548) ........ r7550 | russell | 2005-12-20 18:34:00 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for segfault on directed pickup when no CDR is available (issue ASTERISK-5839) ........ r7552 | russell | 2005-12-20 19:05:45 +0100 (Di, 20 Dez 2005) | 2 lines backport fix for reloading peer context (issue ASTERISK-5848) ........ r7557 | russell | 2005-12-20 21:21:26 +0100 (Di, 20 Dez 2005) | 2 lines check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ........ r7580 | bweschke | 2005-12-21 20:53:49 +0100 (Mi, 21 Dez 2005) | 3 lines Bug ASTERISK-5882 - Documentation correction ........ r7586 | twisted | 2005-12-21 23:23:39 +0100 (Mi, 21 Dez 2005) | 3 lines Actually put in the per-peer settings for sip video, as they didn't make it in at astricon somehow, and I've been too busy up until now to redo it. ........ r7595 | russell | 2005-12-22 17:17:43 +0100 (Do, 22 Dez 2005) | 2 lines remove stray unlock (issue ASTERISK-5800) ........ r7605 | bweschke | 2005-12-23 01:00:11 +0100 (Fr, 23 Dez 2005) | 3 lines Another app documentation tweak. ........ r7641 | kpfleming | 2005-12-27 01:07:45 +0100 (Di, 27 Dez 2005) | 2 lines backport fix to ensure that DSP is never enabled on pseudo channels ........ r7663 | russell | 2005-12-27 22:07:08 +0100 (Di, 27 Dez 2005) | 2 lines backport fix for permissions of created recordings (issue ASTERISK-5909) ........ r7706 | bweschke | 2006-01-02 03:04:14 +0100 (Mo, 02 Jan 2006) | 3 lines Fix compiler warnings. ........ r7738 | kpfleming | 2006-01-03 18:00:01 +0100 (Di, 03 Jan 2006) | 2 lines backport rport scanning fix from trunk (bug ASTERISK-5913) ........ r7771 | bweschke | 2006-01-04 06:27:38 +0100 (Mi, 04 Jan 2006) | 3 lines Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969 ........ r7792 | oej | 2006-01-04 22:43:14 +0100 (Mi, 04 Jan 2006) | 2 lines Fixing typo in XML for video updates. ........ r7812 | oej | 2006-01-05 10:13:21 +0100 (Do, 05 Jan 2006) | 2 lines Fix copyright of changed file ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8055 |