[Home]

Summary:ASTERISK-05799: [patch] printf-like append_history and use a tailq to store records
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2005-12-08 01:39:17.000-0600Date Closed:2008-01-15 16:29:55.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sip_history.diff
( 1) sip_history.v2.diff
Description:the attached patch supplies a printf-like version of append_history(),
so one is not forced to use intermediate buffers and sprintf() to prepare
the arguments for the function.
Also store the history records in a tailq, thus reducing the insertion
time to O(1) instead of O(N).

Once this patch is in, i plan to improve memory usage a lot more by:
- replacing the two history pointers in sip_pvt with only one to a
 struct sip_history_head
- replacing the fixed-size history record with a variable size one,
 by printing into a local buffer and then copying it once we know the
 required size. Given that we already scan the buffer twice (in the
 sprintf and the newline trimming), the copy comes essentially for free.
 to the
Comments:By: Tilghman Lesher (tilghman) 2005-12-12 09:42:03.000-0600

If we're going to be implementing tailq's at all, why not use the existing list management interface, as defined by "asterisk/linkedlists.h"?

By: Luigi Rizzo (rizzo) 2005-12-12 09:47:04.000-0600

that's a good suggestion, thanks for the pointer.

By: Luigi Rizzo (rizzo) 2005-12-17 07:36:00.000-0600

modified according to corydon's suggestions to use AST_LIST macros.
While at it, optimized memory usage as described in the original comment,
by using only a single pointer in the sip_pvt structure
(so there is no waste if history is not recorded) and using variable-sized
records according to the needs (strings are generally very short here, so
the saving is sensible). The patch is against rev.7516

By: Olle Johansson (oej) 2006-01-03 05:26:10.000-0600

Committed to svn trunk, revision 7734

Thank you for your contribution, rizzo!

/O

By: Luigi Rizzo (rizzo) 2006-01-03 05:37:41.000-0600

note the chunk
+ ast_log(LOG_DEBUG, "  %d. %s\n", x++, hist->event);
has become
+ ast_log(LOG_DEBUG, "  %d. %s\n", ++x, hist->event);

in the meantime...

By: Olle Johansson (oej) 2006-01-03 11:31:56.000-0600

Where?

By: Luigi Rizzo (rizzo) 2006-01-03 11:45:25.000-0600

it's in sip show history.
I can't find when it was committed but it was a recent change to
sip_show history so that the record count starts from 1 instead of 0.
the patch was created before that change, but i had it
updated in my local copy and in fact svn update gave me
a conflict on this one.

By: Olle Johansson (oej) 2006-01-26 12:48:03.000-0600

Resolved again in rev 8731.

By: Digium Subversion (svnbot) 2008-01-15 16:10:37.000-0600

Repository: asterisk
Revision: 7734

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r7734 | oej | 2008-01-15 16:10:37 -0600 (Tue, 15 Jan 2008) | 2 lines

Issue ASTERISK-5799: Implement printf-like append_history and implement AST_LIST for SIP history (rizzo)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=7734

By: Digium Subversion (svnbot) 2008-01-15 16:11:19.000-0600

Repository: asterisk
Revision: 7781

_U  team/oej/aum-trunk/
U   team/oej/aum-trunk/UPGRADE.txt
U   team/oej/aum-trunk/apps/app_chanspy.c
U   team/oej/aum-trunk/apps/app_mixmonitor.c
U   team/oej/aum-trunk/apps/app_privacy.c
U   team/oej/aum-trunk/apps/app_stack.c
D   team/oej/aum-trunk/ast_expr.y
U   team/oej/aum-trunk/ast_expr2.fl
U   team/oej/aum-trunk/ast_expr2f.c
U   team/oej/aum-trunk/autoservice.c
U   team/oej/aum-trunk/cdr.c
U   team/oej/aum-trunk/channel.c
U   team/oej/aum-trunk/channels/chan_iax2.c
U   team/oej/aum-trunk/channels/chan_sip.c
U   team/oej/aum-trunk/configs/manager.conf.sample
U   team/oej/aum-trunk/configs/sip.conf.sample
A   team/oej/aum-trunk/contrib/scripts/safe_asterisk_restart
U   team/oej/aum-trunk/file.c
U   team/oej/aum-trunk/funcs/func_moh.c
U   team/oej/aum-trunk/image.c
U   team/oej/aum-trunk/include/asterisk/chanspy.h
U   team/oej/aum-trunk/include/asterisk/image.h
U   team/oej/aum-trunk/include/asterisk/rtp.h
U   team/oej/aum-trunk/manager.c
U   team/oej/aum-trunk/pbx.c
U   team/oej/aum-trunk/res/Makefile
U   team/oej/aum-trunk/res/res_osp.c
U   team/oej/aum-trunk/rtp.c

------------------------------------------------------------------------
r7781 | oej | 2008-01-15 16:11:18 -0600 (Tue, 15 Jan 2008) | 171 lines

Merged revisions 7720,7725,7728-7734,7737,7739,7741,7744-7745,7747-7748,7750-7751,7770,7774-7779 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r7720 | russell | 2006-01-02 19:54:34 +0100 (Mon, 02 Jan 2006) | 2 lines

doxygen updates

................
r7725 | russell | 2006-01-03 00:52:33 +0100 (Tue, 03 Jan 2006) | 2 lines

initialize sip_auth list

................
r7728 | oej | 2006-01-03 09:40:55 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5960: Clean up list handling in image.c (drumkilla)

................
r7729 | oej | 2006-01-03 09:54:19 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5958: Use list macros in autoservice.c (drumkilla)

................
r7730 | oej | 2006-01-03 10:30:19 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5951: Fix unprotected list in RTP, implement AST_LIST macros, update doxygen docs

................
r7731 | oej | 2006-01-03 12:21:48 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug 5345; Add configuration option for minimum registration time. (folsson)

................
r7732 | oej | 2006-01-03 12:31:56 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5088: Add caller ID and CallerIDname to OriginateSuccess/Failure manager events (outtolunc)

................
r7733 | oej | 2006-01-03 12:58:10 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5913: Broken rport match in check_via(). (rizzo)

................
r7734 | oej | 2006-01-03 13:25:32 +0100 (Tue, 03 Jan 2006) | 2 lines

Issue ASTERISK-5799: Implement printf-like append_history and implement AST_LIST for SIP history (rizzo)

................
r7737 | kpfleming | 2006-01-03 17:39:37 +0100 (Tue, 03 Jan 2006) | 10 lines

Merged revisions 7736 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r7736 | kpfleming | 2006-01-03 10:34:12 -0600 (Tue, 03 Jan 2006) | 2 lines

don't leak memory for (most) expression evaluations

........

................
r7739 | kpfleming | 2006-01-03 18:08:35 +0100 (Tue, 03 Jan 2006) | 3 lines

fix breakage from rev 7730 (failure to unlock list in get_proto)
minor cleanups and simpler usage of list macros

................
r7741 | kpfleming | 2006-01-03 18:25:39 +0100 (Tue, 03 Jan 2006) | 12 lines

Merged revisions 7740 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r7740 | kpfleming | 2006-01-03 11:24:56 -0600 (Tue, 03 Jan 2006) | 4 lines

revert incorrect fix for bug ASTERISK-5890 from revision 7709
put in correct (simpler) fix
add doxygen docs for channel spy 'state' values

........

................
r7744 | tilghman | 2006-01-03 19:17:42 +0100 (Tue, 03 Jan 2006) | 3 lines

Merged revisions 7743 via svnmerge from
/branches/1.2

................
r7745 | oej | 2006-01-03 20:12:50 +0100 (Tue, 03 Jan 2006) | 2 lines

Don't check user call limits for outbound calls.

................
r7747 | kpfleming | 2006-01-03 21:23:23 +0100 (Tue, 03 Jan 2006) | 10 lines

Merged revisions 7746 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r7746 | kpfleming | 2006-01-03 14:22:18 -0600 (Tue, 03 Jan 2006) | 2 lines

remove unused 'old' expression parser

........

................
r7748 | kpfleming | 2006-01-03 21:33:28 +0100 (Tue, 03 Jan 2006) | 2 lines

add script for simple 'no-brainer' restarts of safe_asterisk (issue ASTERISK-5004)

................
r7750 | kpfleming | 2006-01-03 23:07:12 +0100 (Tue, 03 Jan 2006) | 2 lines

add optional timestamps to manager events (issue ASTERISK-5387, simplified)

................
r7751 | kpfleming | 2006-01-03 23:16:23 +0100 (Tue, 03 Jan 2006) | 2 lines

update copyright headers for files changed this year

................
r7770 | bweschke | 2006-01-04 06:26:03 +0100 (Wed, 04 Jan 2006) | 3 lines

Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969


................
r7774 | russell | 2006-01-04 08:08:08 +0100 (Wed, 04 Jan 2006) | 10 lines

Merged revisions 7773 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r7773 | russell | 2006-01-04 02:06:50 -0500 (Wed, 04 Jan 2006) | 2 lines

use a more correct way of determining the size of the destination buffer

........

................
r7775 | oej | 2006-01-04 10:10:56 +0100 (Wed, 04 Jan 2006) | 6 lines

- Remove "incominglimit" as a configuration option in sip.conf
- Add documentation on call-limit, explaining that there's two counters
 for a type="friend".
- Document the removval of "incominglimit" in UPGRADE.txt


................
r7776 | oej | 2006-01-04 10:22:45 +0100 (Wed, 04 Jan 2006) | 2 lines

Issue ASTERISK-5970: Count in show channeltypes (junky)

................
r7777 | oej | 2006-01-04 11:16:53 +0100 (Wed, 04 Jan 2006) | 2 lines

Missing ">" in XML. Thanks, fenlander, for reporting this on IRC.

................
r7778 | russell | 2006-01-04 13:11:11 +0100 (Wed, 04 Jan 2006) | 2 lines

doxygen tweak

................
r7779 | oej | 2006-01-04 13:16:30 +0100 (Wed, 04 Jan 2006) | 2 lines

Issue ASTERISK-5797: Add destination protocol information to res_osp (homesick)

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=7781

By: Digium Subversion (svnbot) 2008-01-15 16:11:25.000-0600

Repository: asterisk
Revision: 7787

_U  team/oej/multiparking/
U   team/oej/multiparking/UPGRADE.txt
U   team/oej/multiparking/apps/app_chanspy.c
U   team/oej/multiparking/apps/app_disa.c
U   team/oej/multiparking/apps/app_mixmonitor.c
U   team/oej/multiparking/apps/app_privacy.c
U   team/oej/multiparking/apps/app_stack.c
D   team/oej/multiparking/ast_expr.y
U   team/oej/multiparking/ast_expr2.fl
U   team/oej/multiparking/ast_expr2f.c
U   team/oej/multiparking/autoservice.c
U   team/oej/multiparking/cdr.c
U   team/oej/multiparking/channel.c
U   team/oej/multiparking/channels/chan_iax2.c
U   team/oej/multiparking/channels/chan_sip.c
U   team/oej/multiparking/channels/chan_zap.c
U   team/oej/multiparking/configs/manager.conf.sample
U   team/oej/multiparking/configs/sip.conf.sample
U   team/oej/multiparking/contrib/scripts/managerproxy.pl
A   team/oej/multiparking/contrib/scripts/safe_asterisk_restart
U   team/oej/multiparking/file.c
U   team/oej/multiparking/funcs/func_moh.c
U   team/oej/multiparking/image.c
U   team/oej/multiparking/include/asterisk/chanspy.h
U   team/oej/multiparking/include/asterisk/image.h
U   team/oej/multiparking/include/asterisk/rtp.h
U   team/oej/multiparking/manager.c
U   team/oej/multiparking/pbx.c
U   team/oej/multiparking/res/res_osp.c
U   team/oej/multiparking/rtp.c

------------------------------------------------------------------------
r7787 | oej | 2008-01-15 16:11:24 -0600 (Tue, 15 Jan 2008) | 186 lines

Merged revisions 7725,7728-7734,7737,7739,7741,7744-7745,7747-7748,7750-7751,7770,7774-7779,7783-7786 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r7725 | russell | 2006-01-03 00:52:33 +0100 (Tue, 03 Jan 2006) | 2 lines

initialize sip_auth list

................
r7728 | oej | 2006-01-03 09:40:55 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5960: Clean up list handling in image.c (drumkilla)

................
r7729 | oej | 2006-01-03 09:54:19 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5958: Use list macros in autoservice.c (drumkilla)

................
r7730 | oej | 2006-01-03 10:30:19 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5951: Fix unprotected list in RTP, implement AST_LIST macros, update doxygen docs

................
r7731 | oej | 2006-01-03 12:21:48 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug 5345; Add configuration option for minimum registration time. (folsson)

................
r7732 | oej | 2006-01-03 12:31:56 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5088: Add caller ID and CallerIDname to OriginateSuccess/Failure manager events (outtolunc)

................
r7733 | oej | 2006-01-03 12:58:10 +0100 (Tue, 03 Jan 2006) | 2 lines

Bug ASTERISK-5913: Broken rport match in check_via(). (rizzo)

................
r7734 | oej | 2006-01-03 13:25:32 +0100 (Tue, 03 Jan 2006) | 2 lines

Issue ASTERISK-5799: Implement printf-like append_history and implement AST_LIST for SIP history (rizzo)

................
r7737 | kpfleming | 2006-01-03 17:39:37 +0100 (Tue, 03 Jan 2006) | 10 lines

Merged revisions 7736 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r7736 | kpfleming | 2006-01-03 10:34:12 -0600 (Tue, 03 Jan 2006) | 2 lines

don't leak memory for (most) expression evaluations

........

................
r7739 | kpfleming | 2006-01-03 18:08:35 +0100 (Tue, 03 Jan 2006) | 3 lines

fix breakage from rev 7730 (failure to unlock list in get_proto)
minor cleanups and simpler usage of list macros

................
r7741 | kpfleming | 2006-01-03 18:25:39 +0100 (Tue, 03 Jan 2006) | 12 lines

Merged revisions 7740 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r7740 | kpfleming | 2006-01-03 11:24:56 -0600 (Tue, 03 Jan 2006) | 4 lines

revert incorrect fix for bug ASTERISK-5890 from revision 7709
put in correct (simpler) fix
add doxygen docs for channel spy 'state' values

........

................
r7744 | tilghman | 2006-01-03 19:17:42 +0100 (Tue, 03 Jan 2006) | 3 lines

Merged revisions 7743 via svnmerge from
/branches/1.2

................
r7745 | oej | 2006-01-03 20:12:50 +0100 (Tue, 03 Jan 2006) | 2 lines

Don't check user call limits for outbound calls.

................
r7747 | kpfleming | 2006-01-03 21:23:23 +0100 (Tue, 03 Jan 2006) | 10 lines

Merged revisions 7746 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r7746 | kpfleming | 2006-01-03 14:22:18 -0600 (Tue, 03 Jan 2006) | 2 lines

remove unused 'old' expression parser

........

................
r7748 | kpfleming | 2006-01-03 21:33:28 +0100 (Tue, 03 Jan 2006) | 2 lines

add script for simple 'no-brainer' restarts of safe_asterisk (issue ASTERISK-5004)

................
r7750 | kpfleming | 2006-01-03 23:07:12 +0100 (Tue, 03 Jan 2006) | 2 lines

add optional timestamps to manager events (issue ASTERISK-5387, simplified)

................
r7751 | kpfleming | 2006-01-03 23:16:23 +0100 (Tue, 03 Jan 2006) | 2 lines

update copyright headers for files changed this year

................
r7770 | bweschke | 2006-01-04 06:26:03 +0100 (Wed, 04 Jan 2006) | 3 lines

Fix the 'if' clause to be true under the right conditions. Bug ASTERISK-5969


................
r7774 | russell | 2006-01-04 08:08:08 +0100 (Wed, 04 Jan 2006) | 10 lines

Merged revisions 7773 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r7773 | russell | 2006-01-04 02:06:50 -0500 (Wed, 04 Jan 2006) | 2 lines

use a more correct way of determining the size of the destination buffer

........

................
r7775 | oej | 2006-01-04 10:10:56 +0100 (Wed, 04 Jan 2006) | 6 lines

- Remove "incominglimit" as a configuration option in sip.conf
- Add documentation on call-limit, explaining that there's two counters
 for a type="friend".
- Document the removval of "incominglimit" in UPGRADE.txt


................
r7776 | oej | 2006-01-04 10:22:45 +0100 (Wed, 04 Jan 2006) | 2 lines

Issue ASTERISK-5970: Count in show channeltypes (junky)

................
r7777 | oej | 2006-01-04 11:16:53 +0100 (Wed, 04 Jan 2006) | 2 lines

Missing ">" in XML. Thanks, fenlander, for reporting this on IRC.

................
r7778 | russell | 2006-01-04 13:11:11 +0100 (Wed, 04 Jan 2006) | 2 lines

doxygen tweak

................
r7779 | oej | 2006-01-04 13:16:30 +0100 (Wed, 04 Jan 2006) | 2 lines

Issue ASTERISK-5797: Add destination protocol information to res_osp (homesick)

................
r7783 | oej | 2006-01-04 14:07:34 +0100 (Wed, 04 Jan 2006) | 2 lines

Issue ASTERISK-5673: Adding more SIP to ISDN Cause code conversions. Thanks mguesdon!

................
r7784 | oej | 2006-01-04 14:49:25 +0100 (Wed, 04 Jan 2006) | 2 lines

Whitespace and formatting changes. /Housekeeping

................
r7785 | oej | 2006-01-04 14:56:11 +0100 (Wed, 04 Jan 2006) | 2 lines

Small typo fix

................
r7786 | mattf | 2006-01-04 15:46:41 +0100 (Wed, 04 Jan 2006) | 2 lines

Fixes for bug ASTERISK-5968

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=7787

By: Digium Subversion (svnbot) 2008-01-15 16:26:05.000-0600

Repository: asterisk
Revision: 8731

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r8731 | oej | 2008-01-15 16:26:05 -0600 (Tue, 15 Jan 2008) | 2 lines

Issue ASTERISK-5799 revisited. Thanks rizzo.

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8731

By: Digium Subversion (svnbot) 2008-01-15 16:28:22.000-0600

Repository: asterisk
Revision: 8890

_U  team/oej/jitterbuffer/
U   team/oej/jitterbuffer/Makefile
U   team/oej/jitterbuffer/UPGRADE.txt
U   team/oej/jitterbuffer/apps/app_dial.c
U   team/oej/jitterbuffer/apps/app_externalivr.c
U   team/oej/jitterbuffer/apps/app_meetme.c
U   team/oej/jitterbuffer/ast_expr2.c
U   team/oej/jitterbuffer/ast_expr2.h
U   team/oej/jitterbuffer/ast_expr2f.c
U   team/oej/jitterbuffer/channel.c
U   team/oej/jitterbuffer/channels/chan_agent.c
U   team/oej/jitterbuffer/channels/chan_features.c
U   team/oej/jitterbuffer/channels/chan_iax2.c
U   team/oej/jitterbuffer/channels/chan_sip.c
U   team/oej/jitterbuffer/channels/chan_zap.c
U   team/oej/jitterbuffer/funcs/func_md5.c
U   team/oej/jitterbuffer/include/asterisk/channel.h
U   team/oej/jitterbuffer/include/asterisk/frame.h
U   team/oej/jitterbuffer/res/Makefile

------------------------------------------------------------------------
r8890 | oej | 2008-01-15 16:28:22 -0600 (Tue, 15 Jan 2008) | 188 lines

Merged revisions 8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue 5898: Registrations does not get deleted if there's an active SIP dialog

........

................
r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines

Add some debugging output when reloading, to be able to follow progress at high debug levels

................
r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines

store conference list using linked list macros (issue ASTERISK-6167)

................
r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines

Code clean up, inspired by rizzo's comments in issue 5978.
- Don't check for ignore if ignore is always negative
- Add comments to explain what's going on

................
r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8729 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

........

................
r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue ASTERISK-5799 revisited. Thanks rizzo.

................
r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines

Formatting fixes, speling eror fiksd ;-)

................
r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines

don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059)

................
r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines

- Move two functions to static that wasn't for some reason
- Add doxygen comments
- Remove un-needed assignment at declaration of variable
- Formatting fixes (whitespace)
- Add optin_debug in front of complex debugging output
- Move forward declarations of functions to top of file
- Fix error message for bad allocation in sip registry
(Note: Review to line 6050 in this too large file)

................
r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines

don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059)

................
r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines


Merged revisions 8758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines

Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files

........

................
r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines

add /usr/local/lib to SOLINK (issue ASTERISK-6163)

................
r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines

remove some more redundant flags

................
r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines

Merged revisions 8785 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines

Issue 6362 - Register without Contact: and Expires: fails (reporter: op)

........

................
r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines

Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188)

................
r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines

Blocking revision 8808 from trunk. It's already fixed in trunk.

................
r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines

Simplify code for building Call ID's, create generic random string function

................
r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines

- Moving forward declarations to one block
- Moving global variables to one block
- Moving global networking variables to one block
- Small whitespace changes
- Renaming a few more global channel settings to global_ for clarity
(No functional changes)

................
r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines

Doxygen updates

................
r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines

Change booleans to TRUE/FALSE.
(At some point we should implement these as enums to simplify debugging)

................
r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines

- Remove unused "resetinvite" variable
- Use TRUE/FALSE for fastrestart

................
r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines

make ast_read() able to handle channel read()/exception() methods that return a chain of frames
cleanup code in ast_read()
add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported
teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate

................
r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines

add channel-driver callbacks for variable length DTMF
teach ast_write() to call those new callbacks

................
r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines

don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events)

................
r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines

Merge Rizzo's waitfor update (bug ASTERISK-4468)

................
r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines

Bug 6378 - deprecate CHECK_MD5 function

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8890

By: Digium Subversion (svnbot) 2008-01-15 16:28:29.000-0600

Repository: asterisk
Revision: 8893

_U  team/oej/multiparking/
U   team/oej/multiparking/Makefile
U   team/oej/multiparking/UPGRADE.txt
U   team/oej/multiparking/apps/app_dial.c
U   team/oej/multiparking/apps/app_externalivr.c
U   team/oej/multiparking/apps/app_meetme.c
U   team/oej/multiparking/ast_expr2.c
U   team/oej/multiparking/ast_expr2.h
U   team/oej/multiparking/ast_expr2f.c
U   team/oej/multiparking/channel.c
U   team/oej/multiparking/channels/chan_agent.c
U   team/oej/multiparking/channels/chan_features.c
U   team/oej/multiparking/channels/chan_iax2.c
U   team/oej/multiparking/channels/chan_sip.c
U   team/oej/multiparking/channels/chan_zap.c
U   team/oej/multiparking/funcs/func_md5.c
U   team/oej/multiparking/include/asterisk/channel.h
U   team/oej/multiparking/include/asterisk/frame.h
U   team/oej/multiparking/res/Makefile

------------------------------------------------------------------------
r8893 | oej | 2008-01-15 16:28:28 -0600 (Tue, 15 Jan 2008) | 188 lines

Merged revisions 8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue 5898: Registrations does not get deleted if there's an active SIP dialog

........

................
r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines

Add some debugging output when reloading, to be able to follow progress at high debug levels

................
r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines

store conference list using linked list macros (issue ASTERISK-6167)

................
r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines

Code clean up, inspired by rizzo's comments in issue 5978.
- Don't check for ignore if ignore is always negative
- Add comments to explain what's going on

................
r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8729 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

........

................
r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue ASTERISK-5799 revisited. Thanks rizzo.

................
r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines

Formatting fixes, speling eror fiksd ;-)

................
r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines

don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059)

................
r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines

- Move two functions to static that wasn't for some reason
- Add doxygen comments
- Remove un-needed assignment at declaration of variable
- Formatting fixes (whitespace)
- Add optin_debug in front of complex debugging output
- Move forward declarations of functions to top of file
- Fix error message for bad allocation in sip registry
(Note: Review to line 6050 in this too large file)

................
r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines

don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059)

................
r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines


Merged revisions 8758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines

Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files

........

................
r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines

add /usr/local/lib to SOLINK (issue ASTERISK-6163)

................
r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines

remove some more redundant flags

................
r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines

Merged revisions 8785 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines

Issue 6362 - Register without Contact: and Expires: fails (reporter: op)

........

................
r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines

Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188)

................
r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines

Blocking revision 8808 from trunk. It's already fixed in trunk.

................
r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines

Simplify code for building Call ID's, create generic random string function

................
r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines

- Moving forward declarations to one block
- Moving global variables to one block
- Moving global networking variables to one block
- Small whitespace changes
- Renaming a few more global channel settings to global_ for clarity
(No functional changes)

................
r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines

Doxygen updates

................
r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines

Change booleans to TRUE/FALSE.
(At some point we should implement these as enums to simplify debugging)

................
r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines

- Remove unused "resetinvite" variable
- Use TRUE/FALSE for fastrestart

................
r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines

make ast_read() able to handle channel read()/exception() methods that return a chain of frames
cleanup code in ast_read()
add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported
teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate

................
r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines

add channel-driver callbacks for variable length DTMF
teach ast_write() to call those new callbacks

................
r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines

don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events)

................
r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines

Merge Rizzo's waitfor update (bug ASTERISK-4468)

................
r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines

Bug 6378 - deprecate CHECK_MD5 function

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8893

By: Digium Subversion (svnbot) 2008-01-15 16:29:55.000-0600

Repository: asterisk
Revision: 8981

_U  team/oej/astum/
U   team/oej/astum/.cleancount
U   team/oej/astum/Makefile
U   team/oej/astum/UPGRADE.txt
U   team/oej/astum/apps/app_dial.c
U   team/oej/astum/apps/app_externalivr.c
U   team/oej/astum/apps/app_meetme.c
U   team/oej/astum/ast_expr2.c
U   team/oej/astum/ast_expr2.h
U   team/oej/astum/ast_expr2f.c
U   team/oej/astum/channel.c
U   team/oej/astum/channels/chan_agent.c
U   team/oej/astum/channels/chan_features.c
U   team/oej/astum/channels/chan_iax2.c
U   team/oej/astum/channels/chan_sip.c
U   team/oej/astum/channels/chan_zap.c
U   team/oej/astum/configs/sip.conf.sample
U   team/oej/astum/funcs/func_md5.c
U   team/oej/astum/include/asterisk/channel.h
U   team/oej/astum/include/asterisk/frame.h
U   team/oej/astum/include/asterisk/stringfields.h
U   team/oej/astum/pbx.c
U   team/oej/astum/res/Makefile
U   team/oej/astum/utils.c

------------------------------------------------------------------------
r8981 | oej | 2008-01-15 16:29:55 -0600 (Tue, 15 Jan 2008) | 277 lines

Merged revisions 8687,8697,8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883,8896,8906,8919,8925-8926,8932,8938,8948-8949,8961,8976 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8687 | russell | 2006-01-25 21:02:12 +0100 (Wed, 25 Jan 2006) | 2 lines

use arg parsing macros for WaitExten and Background (issue ASTERISK-6028)

................
r8697 | kpfleming | 2006-01-26 05:00:05 +0100 (Thu, 26 Jan 2006) | 4 lines

string field manager improvements:
use multiple memory blocks, instead of realloc(), ensuring that field pointers will never become invalid or change
don't run vs(n)printf twice when doing a field build unless required

................
r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue 5898: Registrations does not get deleted if there's an active SIP dialog

........

................
r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines

Add some debugging output when reloading, to be able to follow progress at high debug levels

................
r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines

store conference list using linked list macros (issue ASTERISK-6167)

................
r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines

Code clean up, inspired by rizzo's comments in issue 5978.
- Don't check for ignore if ignore is always negative
- Add comments to explain what's going on

................
r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines

Merged revisions 8729 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines

fix problem with dtmf on e&m (issue ASTERISK-6203)

........

................
r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines

Issue ASTERISK-5799 revisited. Thanks rizzo.

................
r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines

Formatting fixes, speling eror fiksd ;-)

................
r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines

don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059)

................
r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines

- Move two functions to static that wasn't for some reason
- Add doxygen comments
- Remove un-needed assignment at declaration of variable
- Formatting fixes (whitespace)
- Add optin_debug in front of complex debugging output
- Move forward declarations of functions to top of file
- Fix error message for bad allocation in sip registry
(Note: Review to line 6050 in this too large file)

................
r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines

don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059)

................
r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines


Merged revisions 8758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines

Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files

........

................
r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines

add /usr/local/lib to SOLINK (issue ASTERISK-6163)

................
r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines

remove some more redundant flags

................
r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines

Merged revisions 8785 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines

Issue 6362 - Register without Contact: and Expires: fails (reporter: op)

........

................
r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines

Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188)

................
r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines

Blocking revision 8808 from trunk. It's already fixed in trunk.

................
r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines

Simplify code for building Call ID's, create generic random string function

................
r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines

- Moving forward declarations to one block
- Moving global variables to one block
- Moving global networking variables to one block
- Small whitespace changes
- Renaming a few more global channel settings to global_ for clarity
(No functional changes)

................
r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines

Doxygen updates

................
r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines

Change booleans to TRUE/FALSE.
(At some point we should implement these as enums to simplify debugging)

................
r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines

- Remove unused "resetinvite" variable
- Use TRUE/FALSE for fastrestart

................
r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines

make ast_read() able to handle channel read()/exception() methods that return a chain of frames
cleanup code in ast_read()
add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported
teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate

................
r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines

add channel-driver callbacks for variable length DTMF
teach ast_write() to call those new callbacks

................
r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines

don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events)

................
r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines

Merge Rizzo's waitfor update (bug ASTERISK-4468)

................
r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines

Bug 6378 - deprecate CHECK_MD5 function

................
r8896 | oej | 2006-01-30 15:12:39 +0100 (Mon, 30 Jan 2006) | 2 lines

Document installation changes for BSD users.

................
r8906 | kpfleming | 2006-01-30 18:09:55 +0100 (Mon, 30 Jan 2006) | 10 lines

Merged revisions 8905 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8905 | kpfleming | 2006-01-30 11:08:28 -0600 (Mon, 30 Jan 2006) | 2 lines

disable buggy PRI user-user code until it can be fixed

........

................
r8919 | oej | 2006-01-30 19:51:02 +0100 (Mon, 30 Jan 2006) | 6 lines

Issue ASTERISK-5643
- simplification of check_auth
- constifications
- whitespace changes
Rizzo's patch with some changes

................
r8925 | oej | 2006-01-30 20:09:08 +0100 (Mon, 30 Jan 2006) | 3 lines

Issue ASTERISK-5876 - Don't send 403 on bad auth (correcting one of my old mistakes...) Reported by maik.
Patch inspired by, but not the patch in the bug tracker.

................
r8926 | oej | 2006-01-30 20:50:39 +0100 (Mon, 30 Jan 2006) | 2 lines

Issue 5892: Set a minimum T1 timer for calls. Reporter: twisted

................
r8932 | oej | 2006-01-30 21:36:38 +0100 (Mon, 30 Jan 2006) | 8 lines

- Doxygen and comments updates
- Moving structure declarations to top of file with the rest
- Adding some forward declarations for RTP interface functions

(All these changes to position in file are in preparation for splitting chan_sip up
into several files at some point in the future)


................
r8938 | mogorman | 2006-01-30 22:16:43 +0100 (Mon, 30 Jan 2006) | 3 lines

reverting  blocks 9 and 10 from revision 7547
fixes bug 6080

................
r8948 | kpfleming | 2006-01-31 01:17:43 +0100 (Tue, 31 Jan 2006) | 2 lines

increment for recent ast_channel change

................
r8949 | russell | 2006-01-31 01:24:34 +0100 (Tue, 31 Jan 2006) | 3 lines

add a note to hopefully decrease the chance that someone forgets to increment
.cleancount after changing the ast_channel structure

................
r8961 | kpfleming | 2006-01-31 04:45:09 +0100 (Tue, 31 Jan 2006) | 2 lines

Yes Virginia, Zaptel does support native ALAW

................
r8976 | oej | 2006-01-31 15:30:09 +0100 (Tue, 31 Jan 2006) | 3 lines

- Change "prefs" to "default_prefs" and move declaration to "default" group
- Add doxygen comments

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8981