Summary:	ASTERISK-05795: [patch] "logger rotate" does not rotate out queue_log.
Reporter:	Chris Hozian (chozian)	Labels:
Date Opened:	2005-12-07 09:33:16.000-0600	Date Closed:	2006-02-26 09:41:18.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 20051211__bug5950.diff.txt
Description:	Running "logger rotate" does not rotate out queue_log.  It only rotates out messages and event_log.
Comments:	By: Tilghman Lesher (tilghman) 2005-12-11 09:52:00.000-0600 Please test this patch to ensure that it fixes your issue. By: Chris Hozian (chozian) 2005-12-27 11:53:39.000-0600 I have tested this patch.  It works great! By: Matt O'Gorman (mogorman) 2006-01-13 15:22:48.000-0600 hey russell, should this go into 1.2 as well as trunk, or just into trunk as its not really a bug. By: Chris Hozian (chozian) 2006-01-14 06:51:44.000-0600 The queue_log used to get rotated.  At some point it quit working.  I would consider it a bug personally since it is not functioning the way it is supposed to be. By: Tilghman Lesher (tilghman) 2006-01-14 09:42:30.000-0600 I believe you're mistaken or you used some system process to rotate out the queue_log.  There has never before been code in Asterisk to rotate out the queue_log (until this patch). However, I can see where it could be considered a bug, given that every other type of logfile has a rotating capability. By: Johann Hoehn (johann) 2006-01-17 08:50:17.000-0600 In at least 1.0.x branch it was being rotated with a simple line in logger.conf. queue_log => This would cause the file to be rotated, however recent changes to the logger.c have removed this.  This was documented somewhere on voip-info.org, but I can't seem to find it right now.  With some changes to logger.c this loop hole so to speak was removed.  It was a rather nice feature that many have become use to having. By: Matt O'Gorman (mogorman) 2006-01-17 09:02:56.000-0600 I think this patch should go both into 1.2 and trunk but not till post 1.2.2 By: Tilghman Lesher (tilghman) 2006-02-23 16:39:26.000-0600 Need your feedback on this one. By: Russell Bryant (russell) 2006-02-25 15:18:10.000-0600 This is acceptable to be put into 1.2.  I'm planning to release 1.2.5 this week, so feel free to go ahead and merge it in time for that.  Thanks! By: Tilghman Lesher (tilghman) 2006-02-26 09:41:18.000-0600 Committed to 1.2, merged to trunk.