Summary:	ASTERISK-05767: [patch] dynamic members gets lost with realtime queues
Reporter:	Jason Parker (jparker)	Labels:
Date Opened:	2005-12-02 19:43:07.000-0600	Date Closed:	2008-01-15 16:04:05.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_queue-r7314-20051203-1545.diff
Description:	If you have realtime queues, and no static members defined (I'll have to wait until Monday to test what happens when there are static members defined.), dynamic members seem to get lost. ****** ADDITIONAL INFORMATION ****** I have an extension that calls AddQueueMember, and when I run that, I can see the member in show queue blah. If I then call the extension I setup for Queue(blah), it tells me it can't join it (I have joinempty set to no).  If I check show queue blah again, the member is gone. I think I've pinpointed this to approx line 871 of app_queue.c.  It iterates through all members, sets them dead, then updates the members from realtime, and removes all members that are still dead - under the guise of removing members that have been deleted from the database. It *should* check whether the member is dynamic, and adding that check solves the problem for me. Disclaimer on file.
Comments:	By: Jason Parker (jparker) 2005-12-02 19:44:19.000-0600 Oops, I wasn't planning on adding a patch right away when I started this report...  Can a bug marshall please fix the summary to include [patch]? By: Jason Parker (jparker) 2005-12-02 21:25:52.000-0600 I was thinking about this a little more on the way home, and I decided I didn't like my patch. I'll try to post a new patch tonight or tomorrow. By: Jason Parker (jparker) 2005-12-03 16:46:06.000-0600 New patch uploaded. Discussed fix with Russell, he agreed that it should be in the first loop, instead of the second. By: Russell Bryant (russell) 2005-12-04 17:11:20.000-0600 fixed in the trunk and 1.2 branch.  Thanks! By: Digium Subversion (svnbot) 2008-01-15 16:04:04.000-0600 Repository: asterisk Revision: 7337 U   branches/1.2/apps/app_queue.c ------------------------------------------------------------------------ r7337 | russell | 2008-01-15 16:04:04 -0600 (Tue, 15 Jan 2008) | 2 lines don't delete dynamic queue members when reloading the static members from a realtime database (issue ASTERISK-5767) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7337 By: Digium Subversion (svnbot) 2008-01-15 16:04:05.000-0600 Repository: asterisk Revision: 7338 _U  trunk/ U   trunk/apps/app_queue.c ------------------------------------------------------------------------ r7338 | russell | 2008-01-15 16:04:04 -0600 (Tue, 15 Jan 2008) | 10 lines Merged revisions 7337 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7337 | russell | 2005-12-04 19:09:12 -0500 (Sun, 04 Dec 2005) | 2 lines don't delete dynamic queue members when reloading the static members from a realtime database (issue ASTERISK-5767) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7338