Summary:ASTERISK-05761: [patch][post 1.4] support for a better manager output in action iax show peers
Reporter:Matteo Brancaleoni (mbrancaleoni)Labels:
Date Opened:2005-12-02 10:26:50.000-0600Date Closed:2011-06-07 14:10:34
Versions:Frequency of
Environment:Attachments:( 0) chan_iax2-updated.patch
Description:as in chan_sip manager action "sippeers", I've added the same
formatted output to chan_iax2.c for manager action iaxpeers.

Hope can be useful.
(already disclaimed years ago...)
Comments:By: Olle Johansson (oej) 2005-12-02 10:34:13.000-0600

You need to check the formatting.

Thanks for this patch, it was really needed.


By: Matteo Brancaleoni (mbrancaleoni) 2005-12-02 10:42:10.000-0600

can you point me to the exact point?
I mean formatting the code ? or the output ?
the code should be formatted as in chan_sip,
but I'll check.

By: Olle Johansson (oej) 2006-01-03 12:19:15.000-0600


+ char username[256] = "";
+        char idtext[256] = "";
Remove indentation

+ char *term = s ? "\r\n" : "\n";
+        if (s) {        /* Manager - get ActionID */
+                id = astman_get_header(m,"ActionID");
+                if (!ast_strlen_zero(id))
+                        snprintf(idtext,256,"ActionID: %s\r\n",id);
+        }

...and other similar places where formatting does not follow the guidelines. It's easy to fix, so please check the whole patch. Thank you!

My apologies for the delay in answering.

By: Matt O'Gorman (mogorman) 2006-01-18 15:35:13.000-0600

this is now syntax updated. can someone verify it is good before commit

By: Olle Johansson (oej) 2006-03-08 02:25:30.000-0600

Please - no new use of the "Channel:" keyword. Peers does not have any associated channels.

By: Olle Johansson (oej) 2006-03-29 19:53:55.000-0600

Any updates on the horizon? We need to move forward with this upgrade to manager... Thanks. /O

By: Serge Vecher (serge-v) 2006-05-03 13:03:34

mbrancaleoni: please update the patch....

By: Serge Vecher (serge-v) 2006-05-26 11:11:27

mbrancaleoni: last try, please update the patch to latest trunk. THANK YOU!

By: Matteo Brancaleoni (mbrancaleoni) 2006-05-29 03:52:29

Hi. sorry but I'm overhelmed... so very slow to read/response.

I'll try to fix it for trunk and for oej review, but I cannot promise to be able to do it today. Maybe for the end of the week, if is ok.

By: Serge Vecher (serge-v) 2006-06-05 20:16:02

that's fine, but please do submit a patch this week (the sooner the better) for it to make it into 1.4 beta.

By: Tilghman Lesher (tilghman) 2006-06-22 11:39:54

Reminder:  we need an update

By: jmls (jmls) 2006-10-31 12:11:20.000-0600

Reminder: we need an update: Can we have a patch for trunk please ?

By: Jason Parker (jparker) 2006-11-21 13:30:14.000-0600

Reporter seems to have lost interest, and there is also a duplicate of this issue, at 8254.

Suspending this for now.