| Summary: | ASTERISK-05745: [patch] Restore context searching via a config file option | ||
| Reporter: | Tilghman Lesher (tilghman) | Labels: | |
| Date Opened: | 2005-11-30 11:41:29.000-0600 | Date Closed: | 2008-01-15 16:03:18.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_voicemail |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 20051130__restore_vm_behavior.diff.txt | |
| Description: | Recent change to app_voicemail changed the behavior of the application to search only the default context, if none was specified, instead of search all contexts. This patch restores the old behavior, through the specification of a flag in voicemail.conf. ****** ADDITIONAL INFORMATION ****** Because the previous patch instituted a behavior (and a design) change, this patch needs to be applied to both HEAD and the 1.2 tree. | ||
| Comments: | By: twisted (twisted) 2005-11-30 13:23:55.000-0600 The previous patch did not institute a design change - the design was for it to only search default, as was documented since it's inception. It was simply a behaviour change to fix the fact that we didnt' do what we said we should be doing properly. I do not have a problem with this patch, but I won't be able to put it in until later, unless someone else wants to. By: Tilghman Lesher (tilghman) 2005-11-30 16:22:26.000-0600 Given that it was intentionally designed to search all contexts, it is a design change. The fact that the documentation didn't match the functionality is a different matter altogether. By: Kevin P. Fleming (kpfleming) 2005-12-01 18:43:22.000-0600 OK, I'll take the blame for letting this one go in without thinking more deeply about it... obviously some people are going to want the old behavior. Committed to branch 1.2, will auto-merge to trunk. Thanks! By: Digium Subversion (svnbot) 2008-01-15 16:03:08.000-0600 Repository: asterisk Revision: 7273 U branches/1.2/UPGRADE.txt U branches/1.2/apps/app_voicemail.c U branches/1.2/configs/voicemail.conf.sample ------------------------------------------------------------------------ r7273 | kpfleming | 2008-01-15 16:03:08 -0600 (Tue, 15 Jan 2008) | 2 lines allow previous context-searching behavior to be used if desired (issue ASTERISK-5745) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7273 By: Digium Subversion (svnbot) 2008-01-15 16:03:11.000-0600 Repository: asterisk Revision: 7276 _U trunk/ U trunk/Makefile U trunk/UPGRADE.txt U trunk/apps/app_festival.c U trunk/apps/app_page.c U trunk/apps/app_voicemail.c U trunk/channel.c U trunk/channels/chan_agent.c U trunk/channels/chan_local.c U trunk/channels/chan_sip.c U trunk/configs/voicemail.conf.sample U trunk/doc/README.misdn D trunk/patches/ U trunk/pbx.c ------------------------------------------------------------------------ r7276 | kpfleming | 2008-01-15 16:03:10 -0600 (Tue, 15 Jan 2008) | 57 lines Merged revisions 7265-7266,7268-7275 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7265 | oej | 2005-12-01 17:18:14 -0600 (Thu, 01 Dec 2005) | 2 lines Changing bug report address to the Asterisk issue tracker ........ r7266 | kpfleming | 2005-12-01 17:18:29 -0600 (Thu, 01 Dec 2005) | 3 lines Makefile 'update' target now supports updating from Subversion repositories (issue ASTERISK-5722) remove support for 'patches' subdirectory, it's no longer useful ........ r7268 | kpfleming | 2005-12-01 17:34:58 -0600 (Thu, 01 Dec 2005) | 2 lines ensure channel's scheduling context is freed (issue ASTERISK-5638) ........ r7269 | kpfleming | 2005-12-01 17:49:44 -0600 (Thu, 01 Dec 2005) | 2 lines don't block waiting for the Festival server forever when it goes away (issue ASTERISK-5729) ........ r7270 | kpfleming | 2005-12-01 18:26:12 -0600 (Thu, 01 Dec 2005) | 2 lines allow variables to exist on both 'halves' of the Local channel (issue ASTERISK-5659) ........ r7271 | kpfleming | 2005-12-01 18:28:48 -0600 (Thu, 01 Dec 2005) | 2 lines protect agent_bridgedchannel() from segfaulting when there is no bridged channel (issue ASTERISK-5726) ........ r7272 | kpfleming | 2005-12-01 18:39:00 -0600 (Thu, 01 Dec 2005) | 3 lines properly handle password changes when mailbox is last line of config file and not followed by a newline (issue ASTERISK-5717) reformat password changing code to conform to coding guidelines (issue ASTERISK-5717) ........ r7273 | kpfleming | 2005-12-01 18:42:40 -0600 (Thu, 01 Dec 2005) | 2 lines allow previous context-searching behavior to be used if desired (issue ASTERISK-5745) ........ r7274 | kpfleming | 2005-12-01 18:51:15 -0600 (Thu, 01 Dec 2005) | 2 lines inherit channel variables into channels created by Page() application (issue ASTERISK-5736) ........ r7275 | oej | 2005-12-01 18:52:13 -0600 (Thu, 01 Dec 2005) | 2 lines Bug ASTERISK-5753. Improve SIP INFO DTMF debugging output. (1.2 & Trunk) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7276 By: Digium Subversion (svnbot) 2008-01-15 16:03:18.000-0600 Repository: asterisk Revision: 7284 _U team/kpfleming/test-for-merging/ U team/kpfleming/test-for-merging/Makefile U team/kpfleming/test-for-merging/UPGRADE.txt U team/kpfleming/test-for-merging/apps/app_festival.c U team/kpfleming/test-for-merging/apps/app_page.c U team/kpfleming/test-for-merging/apps/app_voicemail.c U team/kpfleming/test-for-merging/build_tools/make_svn_branch_name U team/kpfleming/test-for-merging/channel.c U team/kpfleming/test-for-merging/channels/chan_agent.c U team/kpfleming/test-for-merging/channels/chan_local.c U team/kpfleming/test-for-merging/channels/chan_sip.c U team/kpfleming/test-for-merging/configs/voicemail.conf.sample U team/kpfleming/test-for-merging/doc/README.jitterbuffer U team/kpfleming/test-for-merging/doc/README.misdn U team/kpfleming/test-for-merging/doc/README.realtime D team/kpfleming/test-for-merging/patches/ U team/kpfleming/test-for-merging/pbx.c ------------------------------------------------------------------------ r7284 | kpfleming | 2008-01-15 16:03:17 -0600 (Tue, 15 Jan 2008) | 72 lines Merged revisions 7257,7261,7263,7265-7266,7268-7275 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7257 | kpfleming | 2005-12-01 13:25:06 -0600 (Thu, 01 Dec 2005) | 2 lines ensure that 'svn info' output is in the expected language for the script to parse (issue ASTERISK-5727) ........ r7261 | oej | 2005-12-01 15:38:38 -0600 (Thu, 01 Dec 2005) | 2 lines Fixing some spelling errors, as well as changing "cvs" to "subversion" in misdn documentation. ........ r7263 | oej | 2005-12-01 16:21:13 -0600 (Thu, 01 Dec 2005) | 2 lines Removing references to 1.1dev, replacing with 1.2, in documentation files. ........ r7265 | oej | 2005-12-01 17:18:14 -0600 (Thu, 01 Dec 2005) | 2 lines Changing bug report address to the Asterisk issue tracker ........ r7266 | kpfleming | 2005-12-01 17:18:29 -0600 (Thu, 01 Dec 2005) | 3 lines Makefile 'update' target now supports updating from Subversion repositories (issue ASTERISK-5722) remove support for 'patches' subdirectory, it's no longer useful ........ r7268 | kpfleming | 2005-12-01 17:34:58 -0600 (Thu, 01 Dec 2005) | 2 lines ensure channel's scheduling context is freed (issue ASTERISK-5638) ........ r7269 | kpfleming | 2005-12-01 17:49:44 -0600 (Thu, 01 Dec 2005) | 2 lines don't block waiting for the Festival server forever when it goes away (issue ASTERISK-5729) ........ r7270 | kpfleming | 2005-12-01 18:26:12 -0600 (Thu, 01 Dec 2005) | 2 lines allow variables to exist on both 'halves' of the Local channel (issue ASTERISK-5659) ........ r7271 | kpfleming | 2005-12-01 18:28:48 -0600 (Thu, 01 Dec 2005) | 2 lines protect agent_bridgedchannel() from segfaulting when there is no bridged channel (issue ASTERISK-5726) ........ r7272 | kpfleming | 2005-12-01 18:39:00 -0600 (Thu, 01 Dec 2005) | 3 lines properly handle password changes when mailbox is last line of config file and not followed by a newline (issue ASTERISK-5717) reformat password changing code to conform to coding guidelines (issue ASTERISK-5717) ........ r7273 | kpfleming | 2005-12-01 18:42:40 -0600 (Thu, 01 Dec 2005) | 2 lines allow previous context-searching behavior to be used if desired (issue ASTERISK-5745) ........ r7274 | kpfleming | 2005-12-01 18:51:15 -0600 (Thu, 01 Dec 2005) | 2 lines inherit channel variables into channels created by Page() application (issue ASTERISK-5736) ........ r7275 | oej | 2005-12-01 18:52:13 -0600 (Thu, 01 Dec 2005) | 2 lines Bug ASTERISK-5753. Improve SIP INFO DTMF debugging output. (1.2 & Trunk) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7284 | ||