Summary:	ASTERISK-05736: [patch] Page() does not support passing ALERT_INFO variable.
Reporter:	Ted Ritchie (tritchie)	Labels:
Date Opened:	2005-11-29 12:53:55.000-0600	Date Closed:	2008-01-15 16:03:18.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_page
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 20051129__page_inherit_vars__2.diff.txt ( 1) 20051129__page_inherit_vars.diff.txt
Description:	The page application does not pass the Alert_Info variable to the receiving SIP phone(s). Since this variable is often used to set the phone for autoanswer when paging it would be very valuable to have. In fact I would go as far as to say that it is almost a bug not to have this functionality.
Comments:	By: Tilghman Lesher (tilghman) 2005-11-29 13:56:29.000-0600 Try this patch. By: Ted Ritchie (tritchie) 2005-11-29 17:29:45.000-0600 I have applied the patch and recompiled, but still no joy. The SIP invite still does not include the ALERT_INFO variable. By: Tilghman Lesher (tilghman) 2005-11-29 18:12:10.000-0600 Did you remember to prefix your variable with an _ so that it gets inherited? Set(_ALERT_INFO=whatever) By: Ted Ritchie (tritchie) 2005-11-29 18:16:35.000-0600 I do have the _ALERT_INFO, in fact I just replace Dial(SIP/206) with Page(SIP/206) in my dial plan to test. I have also tried ALERT_INFO and __ALERT_INFO with the patch just incase. By: Tilghman Lesher (tilghman) 2005-11-29 19:00:40.000-0600 Aha.  Try this new patch. By: Ted Ritchie (tritchie) 2005-11-29 19:45:14.000-0600 That's got it. Thanks very much. I think that will be a valuable addition to the paging app. By: Andrew Lindh (andrew) 2005-11-29 21:11:28.000-0600 I'll say it's a bug, it should have always been there to make page work. I would like to see it as a bug fix in 1.2 rather than a new feature for 1.3 It seems to be working for me with 1.2 CVS. Thanks for the patch. By: Tilghman Lesher (tilghman) 2005-11-30 23:35:12.000-0600 andrew:  I'm reticent to make that change to the frozen branch, because it changes behavior in pbx_spool, which is where call files are processed.  I agree that it should go into HEAD, but I'm not convinced that it needs to go into the frozen branch. Make a better case for it, and you might convince me.  ;-) By: Kevin P. Fleming (kpfleming) 2005-12-01 18:52:02.000-0600 I would agree, BJ and I had already talked about this problem, and concluded that there was no "pretty" solution. This patch properly implements the "ugly" solution, which is certaintly fine for now. Committed to branch 1.2, will auto-merge to trunk. Thanks! By: Digium Subversion (svnbot) 2008-01-15 16:03:09.000-0600 Repository: asterisk Revision: 7274 U   branches/1.2/apps/app_page.c U   branches/1.2/pbx.c ------------------------------------------------------------------------ r7274 | kpfleming | 2008-01-15 16:03:08 -0600 (Tue, 15 Jan 2008) | 2 lines inherit channel variables into channels created by Page() application (issue ASTERISK-5736) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7274 By: Digium Subversion (svnbot) 2008-01-15 16:03:11.000-0600 Repository: asterisk Revision: 7276 _U  trunk/ U   trunk/Makefile U   trunk/UPGRADE.txt U   trunk/apps/app_festival.c U   trunk/apps/app_page.c U   trunk/apps/app_voicemail.c U   trunk/channel.c U   trunk/channels/chan_agent.c U   trunk/channels/chan_local.c U   trunk/channels/chan_sip.c U   trunk/configs/voicemail.conf.sample U   trunk/doc/README.misdn D   trunk/patches/ U   trunk/pbx.c ------------------------------------------------------------------------ r7276 | kpfleming | 2008-01-15 16:03:10 -0600 (Tue, 15 Jan 2008) | 57 lines Merged revisions 7265-7266,7268-7275 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7265 | oej | 2005-12-01 17:18:14 -0600 (Thu, 01 Dec 2005) | 2 lines Changing bug report address to the Asterisk issue tracker ........ r7266 | kpfleming | 2005-12-01 17:18:29 -0600 (Thu, 01 Dec 2005) | 3 lines Makefile 'update' target now supports updating from Subversion repositories (issue ASTERISK-5722) remove support for 'patches' subdirectory, it's no longer useful ........ r7268 | kpfleming | 2005-12-01 17:34:58 -0600 (Thu, 01 Dec 2005) | 2 lines ensure channel's scheduling context is freed (issue ASTERISK-5638) ........ r7269 | kpfleming | 2005-12-01 17:49:44 -0600 (Thu, 01 Dec 2005) | 2 lines don't block waiting for the Festival server forever when it goes away (issue ASTERISK-5729) ........ r7270 | kpfleming | 2005-12-01 18:26:12 -0600 (Thu, 01 Dec 2005) | 2 lines allow variables to exist on both 'halves' of the Local channel (issue ASTERISK-5659) ........ r7271 | kpfleming | 2005-12-01 18:28:48 -0600 (Thu, 01 Dec 2005) | 2 lines protect agent_bridgedchannel() from segfaulting when there is no bridged channel (issue ASTERISK-5726) ........ r7272 | kpfleming | 2005-12-01 18:39:00 -0600 (Thu, 01 Dec 2005) | 3 lines properly handle password changes when mailbox is last line of config file and not followed by a newline (issue ASTERISK-5717) reformat password changing code to conform to coding guidelines (issue ASTERISK-5717) ........ r7273 | kpfleming | 2005-12-01 18:42:40 -0600 (Thu, 01 Dec 2005) | 2 lines allow previous context-searching behavior to be used if desired (issue ASTERISK-5745) ........ r7274 | kpfleming | 2005-12-01 18:51:15 -0600 (Thu, 01 Dec 2005) | 2 lines inherit channel variables into channels created by Page() application (issue ASTERISK-5736) ........ r7275 | oej | 2005-12-01 18:52:13 -0600 (Thu, 01 Dec 2005) | 2 lines Bug ASTERISK-5753. Improve SIP INFO DTMF debugging output. (1.2 & Trunk) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7276 By: Digium Subversion (svnbot) 2008-01-15 16:03:18.000-0600 Repository: asterisk Revision: 7284 _U  team/kpfleming/test-for-merging/ U   team/kpfleming/test-for-merging/Makefile U   team/kpfleming/test-for-merging/UPGRADE.txt U   team/kpfleming/test-for-merging/apps/app_festival.c U   team/kpfleming/test-for-merging/apps/app_page.c U   team/kpfleming/test-for-merging/apps/app_voicemail.c U   team/kpfleming/test-for-merging/build_tools/make_svn_branch_name U   team/kpfleming/test-for-merging/channel.c U   team/kpfleming/test-for-merging/channels/chan_agent.c U   team/kpfleming/test-for-merging/channels/chan_local.c U   team/kpfleming/test-for-merging/channels/chan_sip.c U   team/kpfleming/test-for-merging/configs/voicemail.conf.sample U   team/kpfleming/test-for-merging/doc/README.jitterbuffer U   team/kpfleming/test-for-merging/doc/README.misdn U   team/kpfleming/test-for-merging/doc/README.realtime D   team/kpfleming/test-for-merging/patches/ U   team/kpfleming/test-for-merging/pbx.c ------------------------------------------------------------------------ r7284 | kpfleming | 2008-01-15 16:03:17 -0600 (Tue, 15 Jan 2008) | 72 lines Merged revisions 7257,7261,7263,7265-7266,7268-7275 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7257 | kpfleming | 2005-12-01 13:25:06 -0600 (Thu, 01 Dec 2005) | 2 lines ensure that 'svn info' output is in the expected language for the script to parse (issue ASTERISK-5727) ........ r7261 | oej | 2005-12-01 15:38:38 -0600 (Thu, 01 Dec 2005) | 2 lines Fixing some spelling errors, as well as changing "cvs" to "subversion" in misdn documentation. ........ r7263 | oej | 2005-12-01 16:21:13 -0600 (Thu, 01 Dec 2005) | 2 lines Removing references to 1.1dev, replacing with 1.2, in documentation files. ........ r7265 | oej | 2005-12-01 17:18:14 -0600 (Thu, 01 Dec 2005) | 2 lines Changing bug report address to the Asterisk issue tracker ........ r7266 | kpfleming | 2005-12-01 17:18:29 -0600 (Thu, 01 Dec 2005) | 3 lines Makefile 'update' target now supports updating from Subversion repositories (issue ASTERISK-5722) remove support for 'patches' subdirectory, it's no longer useful ........ r7268 | kpfleming | 2005-12-01 17:34:58 -0600 (Thu, 01 Dec 2005) | 2 lines ensure channel's scheduling context is freed (issue ASTERISK-5638) ........ r7269 | kpfleming | 2005-12-01 17:49:44 -0600 (Thu, 01 Dec 2005) | 2 lines don't block waiting for the Festival server forever when it goes away (issue ASTERISK-5729) ........ r7270 | kpfleming | 2005-12-01 18:26:12 -0600 (Thu, 01 Dec 2005) | 2 lines allow variables to exist on both 'halves' of the Local channel (issue ASTERISK-5659) ........ r7271 | kpfleming | 2005-12-01 18:28:48 -0600 (Thu, 01 Dec 2005) | 2 lines protect agent_bridgedchannel() from segfaulting when there is no bridged channel (issue ASTERISK-5726) ........ r7272 | kpfleming | 2005-12-01 18:39:00 -0600 (Thu, 01 Dec 2005) | 3 lines properly handle password changes when mailbox is last line of config file and not followed by a newline (issue ASTERISK-5717) reformat password changing code to conform to coding guidelines (issue ASTERISK-5717) ........ r7273 | kpfleming | 2005-12-01 18:42:40 -0600 (Thu, 01 Dec 2005) | 2 lines allow previous context-searching behavior to be used if desired (issue ASTERISK-5745) ........ r7274 | kpfleming | 2005-12-01 18:51:15 -0600 (Thu, 01 Dec 2005) | 2 lines inherit channel variables into channels created by Page() application (issue ASTERISK-5736) ........ r7275 | oej | 2005-12-01 18:52:13 -0600 (Thu, 01 Dec 2005) | 2 lines Bug ASTERISK-5753. Improve SIP INFO DTMF debugging output. (1.2 & Trunk) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7284