Summary:ASTERISK-05731: [patch] Add 'From:' field to manager ParkedCalls command
Reporter:Christopher L. Wade (clwade)Labels:
Date Opened:2005-11-28 17:47:54.000-0600Date Closed:2008-01-15 16:08:04.000-0600
Versions:Frequency of
Environment:Attachments:( 0) parkedcalls.patch
Description:Event: ParkedCall
Exten: 701
Channel: OSS/dsp
From: SCCP/824-00000002
Timeout: 118
CallerID: ###
CallerIDName: Console


Using this to replace database storage of parked calls that was implemented to create an XML display for Cisco phones.  Once I figure out a way to get the CallerID and CallerIDName from the parked extension (701, 702, etc.) in extensions.conf I'll completely drop the database for parked calls.
Comments:By: Christopher L. Wade (clwade) 2005-11-28 17:49:36.000-0600

Stupid request I know, but could this be ported back to 1.2?  I know it is technically a new feature and therefore should be 1.3+ material, but from my point of view, it is actually just an oversight and should have been there since the last time I touched the Parking related manager events.

Also, summary should include [patch], sorry.

By: Christopher L. Wade (clwade) 2005-12-02 11:42:11.000-0600

Does the access to cur->peername need to be protected by a NULL check?  My C is so rusty I can't remember if this is an issue or not.  Regardless, I've got another patch that I can upload tonight that fixes all references to cur->peername (et. al.) to check for NULL if this is needed.

... and this patch is now against SVN trunk.

By: Olle Johansson (oej) 2005-12-02 13:51:41.000-0600

I agree with this patch and recommend it for commit.

By: Russell Bryant (russell) 2005-12-20 01:06:52.000-0600

Would you be opposed to changing "From:" to "ParkedBy:" ?  I like the idea of this patch, but I just want to make sure we use the best name.  Is there any other place in Asterisk that would set a naming precedent for this?

By: Olle Johansson (oej) 2005-12-20 01:32:18.000-0600

Agree that it is stupid, I checked that as well. It's already in there. Anyone that still believes manager 1.0 syntax makes any sense?

/signed "the campaign for manager 2.0"

By: Olle Johansson (oej) 2005-12-20 01:32:19.000-0600

Agree that it is stupid, I checked that as well. It's already in there. Anyone that still believes manager 1.0 syntax makes any sense?

/signed "the campaign for manager 2.0"

By: Russell Bryant (russell) 2005-12-20 11:18:29.000-0600

This is really weird ...

I don't know what version you made this patch against, but the "From:" header to the ParkedCalls action is already there, and has been for quite a while.

I'm closing this out, but please re-open or let me know on IRC if i am missing something here.

By: Christopher L. Wade (clwade) 2005-12-20 21:10:19.000-0600

drumkilla: Yes you missed something.  You checked the ParkedCall event that is fired off for every newly parked call.  My patch adds the From field to the ParkedCall response message fired off in the manager_parking_status function.

oej: The reason I used the 'From:' header is that all the other existing manager events related to parking use the 'From:' header.  This is a hold-over from the original ParkedCall event that drumkilla found by accident which has always had the 'From:' header.  Check mantis for the previous bug I submitted which added the UnParkedCall event among others, it actually discusses this to some degree.

By: Russell Bryant (russell) 2005-12-20 21:51:07.000-0600

I appologize for the accidental oversight.  This all sounds good - I'll merge it here shortly ...

By: Russell Bryant (russell) 2005-12-21 01:52:08.000-0600

added to the trunk, thanks!

By: Digium Subversion (svnbot) 2008-01-15 16:08:04.000-0600

Repository: asterisk
Revision: 7569

U   trunk/res/res_features.c

r7569 | russell | 2008-01-15 16:08:03 -0600 (Tue, 15 Jan 2008) | 4 lines

add a header to indicate who the call was parked by to the ParkedCall manager
events generated when parking status is requested.  This header was already
in the events that are generated when the call is first parked. (issue ASTERISK-5731)