[Home]

Summary:ASTERISK-05704: [patch] dialplan hint system is case sentive
Reporter:cherso (cherso)Labels:
Date Opened:2005-11-25 08:58:25.000-0600Date Closed:2011-06-07 14:10:31
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Functions/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) hint_case_fix.diff
Description:I noticed that the hint was not working when I write the channel name upcase for zap channel
for example
exten = 1,hint,zap/1
does not work
exten = 1,hint,ZAP/1
does not work

exten = 1,hint,Zap/1
work because the zt_requst create the channel with this name.

Every channel type match in the code is done with strcasecmp except in the ast_hint_state_changed and this could a problem


so this is the patch for the CVS v1-2 but it could be manually applied to all asterisk versions
Comments:By: Russell Bryant (russell) 2005-11-25 09:12:03.000-0600

Well, I agree that the channel type is not supposed to be case sensitive.  However, the information that comes after the channel type *is* case sensitive.  That is going to make this fix a little bit more complicated.
By: cherso (cherso) 2005-11-25 09:17:06.000-0600

nope, this patch is ok for me.
All the type and channel checks are done in the rest of the code.

Anyway, I found the bug place
By: cherso (cherso) 2005-11-25 09:43:47.000-0600

looking to the sip code, the information that comes after the channel type look not case sensitive.
chan_sip.c goses thru ASTOBJ_CONTAINER_FIND with strcasecmp
By: Mark Spencer (markster) 2005-11-25 15:03:57.000-0600

Fixed in CVS head.  Thanks!
By: Russell Bryant (russell) 2005-11-30 01:22:50.000-0600

fixed in 1.2 as well
By: Digium Subversion (svnbot) 2008-01-15 15:57:50.000-0600

Repository: asterisk
Revision: 7197

U   trunk/pbx.c

------------------------------------------------------------------------
r7197 | markster | 2008-01-15 15:57:50 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix hint case sensitivity (bug ASTERISK-5704)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=7197
By: Digium Subversion (svnbot) 2008-01-15 16:02:30.000-0600

Repository: asterisk
Revision: 7231

U   branches/1.2/pbx.c

------------------------------------------------------------------------
r7231 | russell | 2008-01-15 16:02:29 -0600 (Tue, 15 Jan 2008) | 2 lines

fix hint case sensitivity (issue ASTERISK-5704)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=7231