Summary:	ASTERISK-05688: Indicating H option does not accept * to hangup if call is not connected
Reporter:	Sebastian Nocetti (snocetti)	Labels:
Date Opened:	2005-11-23 14:33:55.000-0600	Date Closed:	2008-01-15 16:07:26.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_dial
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	In versin 1.2 Final when I make a call using Dial app with H option, and call start ringing, I press * but call still ringing... it supposes to hangup call on all moments of the call (include ringing and connecting) Whe call ins answered, if I press *, call is hunged up OK. I version 1.2beta1 it worked OK (H option hunged up call during ring, connecting or answered). Grettings.
Comments:	By: twisted (twisted) 2005-11-23 23:12:39.000-0600 it looks like betwen 1.2b1 and 1.2b2 we changed where we set the options for the call.  It was a fairly large adjustment, so I'm going to assign this to kpfleming, since he more than likely actually did the code for it ;) By: Mark Spencer (markster) 2005-11-25 14:13:52.000-0600 Is this still the case with CVS head?  If so, can you find me on IRC so I can login and take a look?  Thanks! By: Sebastian Nocetti (snocetti) 2005-11-25 14:33:57.000-0600 I downloaded lastes CVS HEAD, and problem is still there... how I can find you??, what IRC channel? By: Clod Patry (junky) 2005-11-25 21:12:36.000-0600 its kram on freenode. Here's my feel about this bug, its look like ast_waitfor_n() ignoring all peerflags. could that be possible? By: Sebastian Nocetti (snocetti) 2005-11-30 08:49:26.000-0600 well, I think just checking 1.2-beta1 and 1.2.0 final, because beta1 works ok. By: Sebastian Nocetti (snocetti) 2005-12-02 06:52:45.000-0600 It can be because accepting DTMF's is only doing when call is answered?.- By: Clod Patry (junky) 2005-12-02 11:30:02.000-0600 It looks like its like that and it shouldn't be like that, im correct. in the desc:    H    - Allow the calling party to hang up by hitting the '*' DTMF digit. is that option include when it ringing or not? im not sure. By: twisted (twisted) 2005-12-02 16:16:36.000-0600 my first note (36971) looks to be the main reason.  DTMF is detected throughout the call, else early media calls like to UPS and things that require dtmf input before the call is answered wouldn't work.  The problem appears to be that we set our options for the channel/peer AFTER the call is answered instead of when the outgoing leg is created, like we used to. By: Tusar Ahmed (tusar) 2005-12-08 11:54:55.000-0600 At third world country GSM network congestion is a regular thing.So for making a call to the third world country we have to call more than two times as If we get  the busy tone from GSM network we have to re-dial,PIN,Tel No again from the begining. But before v.1.2b1 , if we get like that we just hit " * " and get chance again to put ONLY telephone number using DTMF. So that we get 3 times chance by only one call to asterisk. But right now it is not working . Is there any possiblity with this great feature (At least for me) to act like before ? By: Kevin P. Fleming (kpfleming) 2005-12-12 22:53:28.000-0600 Fixed in branch-1.2, will merge over to trunk shortly. By: Digium Subversion (svnbot) 2008-01-15 16:06:21.000-0600 Repository: asterisk Revision: 7453 U   branches/1.2/apps/app_dial.c ------------------------------------------------------------------------ r7453 | kpfleming | 2008-01-15 16:06:21 -0600 (Tue, 15 Jan 2008) | 2 lines restore ability of caller to hangup calls that are still ringing (issue ASTERISK-5688) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7453 By: Digium Subversion (svnbot) 2008-01-15 16:06:25.000-0600 Repository: asterisk Revision: 7457 _U  trunk/ U   trunk/app.c U   trunk/apps/app_dial.c U   trunk/channels/chan_agent.c U   trunk/channels/chan_sip.c U   trunk/pbx.c ------------------------------------------------------------------------ r7457 | kpfleming | 2008-01-15 16:06:24 -0600 (Tue, 15 Jan 2008) | 25 lines Merged revisions 7448-7449,7451,7453 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7448 | kpfleming | 2005-12-12 22:25:14 -0600 (Mon, 12 Dec 2005) | 2 lines use the stream's current point when pausing/unpausing, instead of elapsed time (which doesn't work when the stream has been skipped forward or backward) (issue ASTERISK-5743) ........ r7449 | kpfleming | 2005-12-12 22:43:38 -0600 (Mon, 12 Dec 2005) | 2 lines only report AGENT_IDLE for callback mode agents when they are actually idle (issue ASTERISK-5748) ........ r7451 | kpfleming | 2005-12-12 23:14:27 -0600 (Mon, 12 Dec 2005) | 2 lines ensure that hangups while incoming calls are in early state are handled properly (issue ASTERISK-5764) ........ r7453 | kpfleming | 2005-12-12 23:53:00 -0600 (Mon, 12 Dec 2005) | 2 lines restore ability of caller to hangup calls that are still ringing (issue ASTERISK-5688) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7457 By: Digium Subversion (svnbot) 2008-01-15 16:07:05.000-0600 Repository: asterisk Revision: 7501 _U  team/russell/make_menuconfig/ U   team/russell/make_menuconfig/app.c D   team/russell/make_menuconfig/apps/app_cut.c U   team/russell/make_menuconfig/apps/app_dial.c U   team/russell/make_menuconfig/apps/app_macro.c U   team/russell/make_menuconfig/channel.c U   team/russell/make_menuconfig/channels/chan_agent.c U   team/russell/make_menuconfig/channels/chan_sip.c U   team/russell/make_menuconfig/configs/misdn.conf.sample U   team/russell/make_menuconfig/doc/README.misdn U   team/russell/make_menuconfig/doc/README.variables A   team/russell/make_menuconfig/funcs/func_cut.c U   team/russell/make_menuconfig/pbx.c U   team/russell/make_menuconfig/utils.c ------------------------------------------------------------------------ r7501 | russell | 2008-01-15 16:07:04 -0600 (Tue, 15 Jan 2008) | 90 lines Merged revisions 7446,7457,7469,7471-7472,7481,7494,7496,7498 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7446 | crichter | 2005-12-12 17:26:35 -0500 (Mon, 12 Dec 2005) | 1 line updated the documentation and the sample config to meet the present ................ r7457 | kpfleming | 2005-12-13 01:00:17 -0500 (Tue, 13 Dec 2005) | 25 lines Merged revisions 7448-7449,7451,7453 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7448 | kpfleming | 2005-12-12 22:25:14 -0600 (Mon, 12 Dec 2005) | 2 lines use the stream's current point when pausing/unpausing, instead of elapsed time (which doesn't work when the stream has been skipped forward or backward) (issue ASTERISK-5743) ........ r7449 | kpfleming | 2005-12-12 22:43:38 -0600 (Mon, 12 Dec 2005) | 2 lines only report AGENT_IDLE for callback mode agents when they are actually idle (issue ASTERISK-5748) ........ r7451 | kpfleming | 2005-12-12 23:14:27 -0600 (Mon, 12 Dec 2005) | 2 lines ensure that hangups while incoming calls are in early state are handled properly (issue ASTERISK-5764) ........ r7453 | kpfleming | 2005-12-12 23:53:00 -0600 (Mon, 12 Dec 2005) | 2 lines restore ability of caller to hangup calls that are still ringing (issue ASTERISK-5688) ........ ................ r7469 | kpfleming | 2005-12-13 11:07:19 -0500 (Tue, 13 Dec 2005) | 10 lines Merged revisions 7468 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7468 | kpfleming | 2005-12-13 10:06:27 -0600 (Tue, 13 Dec 2005) | 2 lines correct broken math in tvfix() for timestamp values over one million ........ ................ r7471 | kpfleming | 2005-12-13 13:54:41 -0500 (Tue, 13 Dec 2005) | 10 lines Merged revisions 7470 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7470 | kpfleming | 2005-12-13 12:54:22 -0600 (Tue, 13 Dec 2005) | 2 lines clarify substring documentation ........ ................ r7472 | russell | 2005-12-13 17:03:06 -0500 (Tue, 13 Dec 2005) | 2 lines reduce some duplicated code when doing a strdup (issue ASTERISK-5830) ................ r7481 | bweschke | 2005-12-14 21:49:17 -0500 (Wed, 14 Dec 2005) | 3 lines Bug ASTERISK-5844 - Don't free the channel structure until after having sent the manager event. ................ r7494 | tilghman | 2005-12-15 12:31:52 -0500 (Thu, 15 Dec 2005) | 2 lines Make sure the functions CUT and SORT are built. ................ r7496 | tilghman | 2005-12-15 14:05:41 -0500 (Thu, 15 Dec 2005) | 2 lines Properly move these functions over to the funcs directory (since they no longer contain apps) ................ r7498 | tilghman | 2005-12-15 19:55:39 -0500 (Thu, 15 Dec 2005) | 3 lines First field was truncated. (Don't kill me; this attempted merge didn't work because the paths changed.) ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7501 By: Digium Subversion (svnbot) 2008-01-15 16:07:08.000-0600 Repository: asterisk Revision: 7504 _U  team/russell/cli_originate/ U   team/russell/cli_originate/app.c D   team/russell/cli_originate/apps/app_cut.c U   team/russell/cli_originate/apps/app_dial.c U   team/russell/cli_originate/apps/app_macro.c U   team/russell/cli_originate/channel.c U   team/russell/cli_originate/channels/chan_agent.c U   team/russell/cli_originate/channels/chan_sip.c U   team/russell/cli_originate/doc/README.variables A   team/russell/cli_originate/funcs/func_cut.c U   team/russell/cli_originate/pbx.c U   team/russell/cli_originate/utils.c ------------------------------------------------------------------------ r7504 | russell | 2008-01-15 16:07:07 -0600 (Tue, 15 Jan 2008) | 86 lines Merged revisions 7457,7469,7471-7472,7481,7494,7496,7498 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7457 | kpfleming | 2005-12-13 01:00:17 -0500 (Tue, 13 Dec 2005) | 25 lines Merged revisions 7448-7449,7451,7453 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7448 | kpfleming | 2005-12-12 22:25:14 -0600 (Mon, 12 Dec 2005) | 2 lines use the stream's current point when pausing/unpausing, instead of elapsed time (which doesn't work when the stream has been skipped forward or backward) (issue ASTERISK-5743) ........ r7449 | kpfleming | 2005-12-12 22:43:38 -0600 (Mon, 12 Dec 2005) | 2 lines only report AGENT_IDLE for callback mode agents when they are actually idle (issue ASTERISK-5748) ........ r7451 | kpfleming | 2005-12-12 23:14:27 -0600 (Mon, 12 Dec 2005) | 2 lines ensure that hangups while incoming calls are in early state are handled properly (issue ASTERISK-5764) ........ r7453 | kpfleming | 2005-12-12 23:53:00 -0600 (Mon, 12 Dec 2005) | 2 lines restore ability of caller to hangup calls that are still ringing (issue ASTERISK-5688) ........ ................ r7469 | kpfleming | 2005-12-13 11:07:19 -0500 (Tue, 13 Dec 2005) | 10 lines Merged revisions 7468 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7468 | kpfleming | 2005-12-13 10:06:27 -0600 (Tue, 13 Dec 2005) | 2 lines correct broken math in tvfix() for timestamp values over one million ........ ................ r7471 | kpfleming | 2005-12-13 13:54:41 -0500 (Tue, 13 Dec 2005) | 10 lines Merged revisions 7470 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7470 | kpfleming | 2005-12-13 12:54:22 -0600 (Tue, 13 Dec 2005) | 2 lines clarify substring documentation ........ ................ r7472 | russell | 2005-12-13 17:03:06 -0500 (Tue, 13 Dec 2005) | 2 lines reduce some duplicated code when doing a strdup (issue ASTERISK-5830) ................ r7481 | bweschke | 2005-12-14 21:49:17 -0500 (Wed, 14 Dec 2005) | 3 lines Bug ASTERISK-5844 - Don't free the channel structure until after having sent the manager event. ................ r7494 | tilghman | 2005-12-15 12:31:52 -0500 (Thu, 15 Dec 2005) | 2 lines Make sure the functions CUT and SORT are built. ................ r7496 | tilghman | 2005-12-15 14:05:41 -0500 (Thu, 15 Dec 2005) | 2 lines Properly move these functions over to the funcs directory (since they no longer contain apps) ................ r7498 | tilghman | 2005-12-15 19:55:39 -0500 (Thu, 15 Dec 2005) | 3 lines First field was truncated. (Don't kill me; this attempted merge didn't work because the paths changed.) ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7504 By: Digium Subversion (svnbot) 2008-01-15 16:07:26.000-0600 Repository: asterisk Revision: 7527 _U  team/russell/ast_malloc/ U   team/russell/ast_malloc/app.c U   team/russell/ast_malloc/apps/app_chanspy.c D   team/russell/ast_malloc/apps/app_cut.c U   team/russell/ast_malloc/apps/app_dial.c U   team/russell/ast_malloc/apps/app_macro.c U   team/russell/ast_malloc/build_tools/make_svn_branch_name U   team/russell/ast_malloc/cdr.c U   team/russell/ast_malloc/channel.c U   team/russell/ast_malloc/channels/chan_agent.c U   team/russell/ast_malloc/channels/chan_sip.c U   team/russell/ast_malloc/doc/README.ael U   team/russell/ast_malloc/doc/README.variables U   team/russell/ast_malloc/file.c A   team/russell/ast_malloc/funcs/func_cut.c U   team/russell/ast_malloc/include/asterisk/linkedlists.h U   team/russell/ast_malloc/pbx.c U   team/russell/ast_malloc/utils.c ------------------------------------------------------------------------ r7527 | russell | 2008-01-15 16:07:25 -0600 (Tue, 15 Jan 2008) | 160 lines Merged revisions 7457,7469,7471-7472,7481,7494,7496,7498,7509,7511-7512,7514,7516,7518,7520,7522,7524 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7457 | kpfleming | 2005-12-13 01:00:17 -0500 (Tue, 13 Dec 2005) | 25 lines Merged revisions 7448-7449,7451,7453 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7448 | kpfleming | 2005-12-12 22:25:14 -0600 (Mon, 12 Dec 2005) | 2 lines use the stream's current point when pausing/unpausing, instead of elapsed time (which doesn't work when the stream has been skipped forward or backward) (issue ASTERISK-5743) ........ r7449 | kpfleming | 2005-12-12 22:43:38 -0600 (Mon, 12 Dec 2005) | 2 lines only report AGENT_IDLE for callback mode agents when they are actually idle (issue ASTERISK-5748) ........ r7451 | kpfleming | 2005-12-12 23:14:27 -0600 (Mon, 12 Dec 2005) | 2 lines ensure that hangups while incoming calls are in early state are handled properly (issue ASTERISK-5764) ........ r7453 | kpfleming | 2005-12-12 23:53:00 -0600 (Mon, 12 Dec 2005) | 2 lines restore ability of caller to hangup calls that are still ringing (issue ASTERISK-5688) ........ ................ r7469 | kpfleming | 2005-12-13 11:07:19 -0500 (Tue, 13 Dec 2005) | 10 lines Merged revisions 7468 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7468 | kpfleming | 2005-12-13 10:06:27 -0600 (Tue, 13 Dec 2005) | 2 lines correct broken math in tvfix() for timestamp values over one million ........ ................ r7471 | kpfleming | 2005-12-13 13:54:41 -0500 (Tue, 13 Dec 2005) | 10 lines Merged revisions 7470 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7470 | kpfleming | 2005-12-13 12:54:22 -0600 (Tue, 13 Dec 2005) | 2 lines clarify substring documentation ........ ................ r7472 | russell | 2005-12-13 17:03:06 -0500 (Tue, 13 Dec 2005) | 2 lines reduce some duplicated code when doing a strdup (issue ASTERISK-5830) ................ r7481 | bweschke | 2005-12-14 21:49:17 -0500 (Wed, 14 Dec 2005) | 3 lines Bug ASTERISK-5844 - Don't free the channel structure until after having sent the manager event. ................ r7494 | tilghman | 2005-12-15 12:31:52 -0500 (Thu, 15 Dec 2005) | 2 lines Make sure the functions CUT and SORT are built. ................ r7496 | tilghman | 2005-12-15 14:05:41 -0500 (Thu, 15 Dec 2005) | 2 lines Properly move these functions over to the funcs directory (since they no longer contain apps) ................ r7498 | tilghman | 2005-12-15 19:55:39 -0500 (Thu, 15 Dec 2005) | 3 lines First field was truncated. (Don't kill me; this attempted merge didn't work because the paths changed.) ................ r7509 | tilghman | 2005-12-16 20:07:44 -0500 (Fri, 16 Dec 2005) | 3 lines Merged revisions 7508 via svnmerge from /branches/1.2 ................ r7511 | kpfleming | 2005-12-16 21:21:36 -0500 (Fri, 16 Dec 2005) | 2 lines block a commit to a module that no longer exists in trunk ................ r7512 | kpfleming | 2005-12-16 21:22:24 -0500 (Fri, 16 Dec 2005) | 10 lines Merged revision 7510 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7510 | kpfleming | 2005-12-16 20:20:04 -0600 (Fri, 16 Dec 2005) | 2 lines fix some buglet when building team branch version strings ........ ................ r7514 | kpfleming | 2005-12-16 22:45:25 -0500 (Fri, 16 Dec 2005) | 10 lines Merged revisions 7513 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7513 | kpfleming | 2005-12-16 21:44:30 -0600 (Fri, 16 Dec 2005) | 2 lines forcibly expire previous subscriptions from a peer when they resubscribe (keeps them from building up and waiting for expiration, and stops us sending unwanted NOTIFY messages to devices) ........ ................ r7516 | kpfleming | 2005-12-16 22:59:27 -0500 (Fri, 16 Dec 2005) | 10 lines Merged revisions 7515 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7515 | kpfleming | 2005-12-16 21:59:05 -0600 (Fri, 16 Dec 2005) | 2 lines Max-Forwards headers must only be present on requests, not responses ........ ................ r7518 | tilghman | 2005-12-17 12:22:24 -0500 (Sat, 17 Dec 2005) | 3 lines Merged revisions 7517 via svnmerge from /branches/1.2 ................ r7520 | tilghman | 2005-12-17 13:58:57 -0500 (Sat, 17 Dec 2005) | 3 lines Merged revisions 7519 via svnmerge from /branches/1.2 ................ r7522 | tilghman | 2005-12-19 00:42:55 -0500 (Mon, 19 Dec 2005) | 3 lines Merged revisions 7521 via svnmerge from /branches/1.2 ................ r7524 | tilghman | 2005-12-19 14:08:42 -0500 (Mon, 19 Dec 2005) | 3 lines Merged revisions 7523 via svnmerge from /branches/1.2 ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7527