Summary:ASTERISK-05655: Malformed callfile crashes server
Reporter:capouch (capouch)Labels:
Date Opened:2005-11-20 01:00:36.000-0600Date Closed:2011-06-07 14:00:49
Versions:Frequency of
Environment:Attachments:( 0) error.call.crash
( 1) pbx_spool-head-20051119-1135.diff
( 2) pbx_spool-head-20051119-1145.diff
Description:While playing around trying to tweak a callfile to get some variables set, I inadvertently discovered a way to crash out my server.  It dies silently the instant it parses the file.

I'm sure it must be the Set: syntax I tried.
Comments:By: twisted (twisted) 2005-11-20 01:17:19.000-0600

can you get a backtrace on this?

By: Jason Parker (jparker) 2005-11-20 01:32:30.000-0600

I'm sitting on a patch for this, but there appear to be issues with the cvs server currently.  Will post a patch soon.

By: Jason Parker (jparker) 2005-11-20 01:36:20.000-0600

capouch, can you test this patch?

I was able to reproduce using the call file you posted.

I decided to use %s in the warning instead of "set" or "setvar".

New patch uploaded...  1135 is the good one.

By: capouch (capouch) 2005-11-20 01:45:57.000-0600

That patch seems to take care of it.

ast_log isn't providing a NL at end of the message?

-- Saved useragent "Grandstream BT100" for peer btel
Nov 20 02:22:24 WARNING[1489]: pbx_spool.c:214 apply_outgoing: Malformed "Set" argument.  Should be "Set: variable=value"    -- Attempting call on local/s@bell2 for s@testWarn:1 (Retry 1)

By: Jason Parker (jparker) 2005-11-20 01:47:56.000-0600

My bad.  Try that.  1145

By: capouch (capouch) 2005-11-20 01:59:19.000-0600

We're good to go!!

By: Jason Parker (jparker) 2005-11-20 02:08:18.000-0600

Let's get the obvious out of the way, shall we?

Disclaimer on file.

By: twisted (twisted) 2005-11-20 02:11:49.000-0600

Fixed in CVS Head, not sure if problem exists in "stable" branch, drumkilla can close if it doesn't.

By: Russell Bryant (russell) 2005-11-20 19:32:51.000-0600

fixed in v1-2 as well

By: Digium Subversion (svnbot) 2008-01-15 15:56:50.000-0600

Repository: asterisk
Revision: 7143

U   trunk/ChangeLog
U   trunk/pbx/pbx_spool.c

r7143 | twisted | 2008-01-15 15:56:49 -0600 (Tue, 15 Jan 2008) | 2 lines

issue ASTERISK-5655



By: Digium Subversion (svnbot) 2008-01-15 15:57:04.000-0600

Repository: asterisk
Revision: 7155

U   branches/v1-2/ChangeLog
U   branches/v1-2/pbx/pbx_spool.c

r7155 | russell | 2008-01-15 15:57:04 -0600 (Tue, 15 Jan 2008) | 2 lines

issue ASTERISK-5655