| Summary: | ASTERISK-05653: [patch] cli.c - remove some useless calls to ast_strlen_zero | ||
| Reporter: | Luigi Rizzo (rizzo) | Labels: | |
| Date Opened: | 2005-11-19 18:05:33.000-0600 | Date Closed: | 2008-01-15 15:57:09.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) cli.patch | |
| Description: | there are a few useless calls to ast_strlen_zero() in cli.c:handle_chanlist() ****** ADDITIONAL INFORMATION ****** There are a lot of places where we have the construct some->long->identifier ? some->long->identifier : "" which could be probably made a lot more readable by using some simple macro STR(some->long->identifier) #define STR(x) ((x) ? (x) : "") | ||
| Comments: | By: Russell Bryant (russell) 2005-11-20 20:34:35.000-0600 I have committed the patch to cvs head. I like the idea of a macro for simplification here. The only problem is that we don't always want to show "" if it's not defined. A lot of places is "<none>" or "<unused>" or something like that. If you would like to propose something, drop it in a new bug report. Thanks! By: Digium Subversion (svnbot) 2008-01-15 15:57:09.000-0600 Repository: asterisk Revision: 7159 U trunk/ChangeLog U trunk/cli.c ------------------------------------------------------------------------ r7159 | russell | 2008-01-15 15:57:09 -0600 (Tue, 15 Jan 2008) | 2 lines issue ASTERISK-5653 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7159 | ||