Summary:	ASTERISK-05631: Asterisk sends invalid SDP, causes RFC2833 not to work.
Reporter:	Justin Unger (justinu)	Labels:
Date Opened:	2005-11-17 14:10:12.000-0600	Date Closed:	2008-01-15 15:56:36.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/CodecHandling
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) annexb-patch.txt
Description:	Asterisk responds to an incoming invite with an invalid SDP. Asterisk sends: a=fmtp:18 annexb=noa=rtpmap:101 telephone-event/8000 There should be a newline between annexb=no and a=rtpmap:101. Correct SDP would be: a=fmtp:18 annexb=no a=rtpmap:101 telephone-event/8000 ****** ADDITIONAL INFORMATION ****** Easily fixable by adding \r\n to the line of code that adds annexb=no to the SDP in chan_sip.c, add_codec_to_sdp().
Comments:	By: Olle Johansson (oej) 2005-11-17 14:28:36.000-0600 Needs to be fixed in 1.2.1 By: Andrew Lindh (andrew) 2005-11-17 14:31:13.000-0600 I agree...it causes problems with G.729 to my cisco AS5300 (it fails). With the change it now works correctly for the first time ever!!! Cisco AS5300 wants the annexb=no or it won't use G.729 correctly. Patch uploaded...disclaimer on file.... By: Ryan Courtnage (rcourtna) 2005-11-17 15:10:33.000-0600 I can verify that this is a problem.   Using g729 in conjunction with rfc2833 will cause DTMF to break on both polycom 501 and uniden uip200 phones. By: Russell Bryant (russell) 2005-11-17 15:38:03.000-0600 fixed in cvs head and the v1-2 branch By: Digium Subversion (svnbot) 2008-01-15 15:56:35.000-0600 Repository: asterisk Revision: 7130 U   trunk/ChangeLog U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r7130 | russell | 2008-01-15 15:56:35 -0600 (Tue, 15 Jan 2008) | 2 lines Add missing carriage return and line feed to the SDP line indicating that we don't support VAD (issue ASTERISK-5631) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7130 By: Digium Subversion (svnbot) 2008-01-15 15:56:36.000-0600 Repository: asterisk Revision: 7131 U   branches/v1-2/ChangeLog U   branches/v1-2/channels/chan_sip.c ------------------------------------------------------------------------ r7131 | russell | 2008-01-15 15:56:36 -0600 (Tue, 15 Jan 2008) | 2 lines Add missing carriage return and line feed to the SDP line indicating that we don't support VAD (issue ASTERISK-5631) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7131