| Summary: | ASTERISK-05624: [patch] X option of MeeMe doesn't work | ||
| Reporter: | Chih-Wei Huang (cwhuang) | Labels: | |
| Date Opened: | 2005-11-16 22:28:17.000-0600 | Date Closed: | 2011-06-07 14:10:45 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_meetme |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) app_meetme_goto_if_exists.diff | |
| Description: | A one line patch (plus a debug message) fixes the problem. BTW, I do think the return value of ast_goto_if_exists() is misleading... | ||
| Comments: | By: Chih-Wei Huang (cwhuang) 2005-11-16 22:30:01.000-0600 I disclaim the patch, of course. Sorry to forgot that. By: BJ Weschke (bweschke) 2005-11-17 00:34:35.000-0600 have you tried your patch ? does it actually fix your problem? By: Chih-Wei Huang (cwhuang) 2005-11-17 01:31:30.000-0600 bweschke, why did you ask that? Isn't my patch simple enough to be self-explanatory? Any problem or concern? And yes, I have tested it, of course. By: BJ Weschke (bweschke) 2005-11-17 08:46:15.000-0600 Ok. Yes. Your patch is correct for this bug. However, in order for that patch to be committed into CVS-HEAD, you must fax or mail your disclaimer to Digium. You cannot just say in a note that your patch is disclaimed. Please advise once you've done this and your disclaimer is on file. Thanks. By: Chih-Wei Huang (cwhuang) 2005-11-17 19:34:01.000-0600 Hmm.. I remember kpleming has said, if the patch is small (a few lines), then there isn't even a need for a disclaimer... I believe this patch is trivial enough that doesn't need a disclaimer. Please just commit it. Please... By: twisted (twisted) 2005-11-20 01:09:38.000-0600 Fixed in CVS Head, with minor mod to debug message. By: twisted (twisted) 2005-11-20 01:10:21.000-0600 also, that is correct. Something this small does not require a disclaimer, although, anything larger probably would. By: Russell Bryant (russell) 2005-11-20 19:07:37.000-0600 fixed in v1-2 as well By: Digium Subversion (svnbot) 2008-01-15 15:56:48.000-0600 Repository: asterisk Revision: 7142 U trunk/ChangeLog U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r7142 | twisted | 2008-01-15 15:56:48 -0600 (Tue, 15 Jan 2008) | 2 lines issue ASTERISK-5624, with minor modification to log message ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7142 By: Digium Subversion (svnbot) 2008-01-15 15:57:03.000-0600 Repository: asterisk Revision: 7154 U branches/v1-2/ChangeLog U branches/v1-2/apps/app_meetme.c ------------------------------------------------------------------------ r7154 | russell | 2008-01-15 15:57:02 -0600 (Tue, 15 Jan 2008) | 2 lines issue ASTERISK-5624 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7154 | ||