[Home]

Summary:ASTERISK-05588: [patch] app_disa broken in 1.2rc2
Reporter:Kristopher Lalletti (kris2k)Labels:
Date Opened:2005-11-13 20:50:17.000-0600Date Closed:2008-01-15 15:56:07.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_disa
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_disa.patch
Description:This used to work flawlessly in HEAD, I even confirmed the app usage line just to make sure I didn't forget anything.

Using 1.2rc2 from CVS (CVS-Nv1-2-0-rc2-11/12/05-10:28:50)

****** ADDITIONAL INFORMATION ******

-- Executing Goto("SIP/tmc-cisco-602-dae2", "tmcApplications|899|1") in new stack
-- Goto (tmcApplications,899,1)
-- Executing Answer("SIP/tmc-cisco-602-dae2", "") in new stack
-- Executing Wait("SIP/tmc-cisco-602-dae2", "1") in new stack
-- Executing DISA("SIP/tmc-cisco-602-dae2", "1234|tmcUsers") in new stack
Nov 13 21:42:40 WARNING[15206]: app_disa.c:300 disa_exec: DISA on chan SIP/tmc-cisco-602-dae2 got bad password 1234

Over the phone, I entered 1234#


Show diaplan shows this:
 '899' =>          1. Answer()                                   [pbx_config]
                   2. Wait(1)                                    [pbx_config]
                   3. Disa(1234|tmcUsers)                        [pbx_config]
Comments:By: Kristopher Lalletti (kris2k) 2005-11-13 20:53:13.000-0600

D'oh, wrong category; should be in applications.
By: BJ Weschke (bweschke) 2005-11-14 07:24:53.000-0600

a recent patch introduced last week broke this functionality to correct other functionality with passwords contained in a file.
By: BJ Weschke (bweschke) 2005-11-14 07:47:03.000-0600

try this new patch.
By: Sergey Okhapkin (sokhapkin) 2005-11-14 11:51:48.000-0600

The patch works for me.
By: Kristopher Lalletti (kris2k) 2005-11-14 12:01:44.000-0600

Yep, patch works here.
By: twisted (twisted) 2005-11-14 20:31:11.000-0600

We labbed this up at IP4IT and I can confirm this is working, with both the old, and new file based behaviour.
By: Matt O'Gorman (mogorman) 2005-11-15 14:05:01.000-0600

so if it works can some one close it?
By: Kevin P. Fleming (kpfleming) 2005-11-15 14:37:29.000-0600

Committed to CVS HEAD, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:56:07.000-0600

Repository: asterisk
Revision: 7101

U   trunk/ChangeLog
U   trunk/apps/app_disa.c

------------------------------------------------------------------------
r7101 | kpfleming | 2008-01-15 15:56:07 -0600 (Tue, 15 Jan 2008) | 2 lines

issue ASTERISK-5588

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=7101