ASTERISK-05581: only noise is received over chan_modem

[Home]

Summary: ASTERISK-05581: only noise is received over chan_modem_i4l

Reporter: David Arendt (dream-lx) Labels:

Date Opened: 2005-11-12 16:40:21.000-0600 Date Closed: 2008-01-15 15:55:59.000-0600

Priority: Major Regression? No

Status: Closed/Complete Components: Core/General

Versions: Frequency of
Occurrence

Related
Issues:

Environment: Attachments:

Description: I had the problem with recent asterisk versions that chan_modem_i4l is only receiving noise.
I decided to examine what leads to this problems an found the reason.
This patch was applied in cvs in order to fix some gcc4 compiler warnings and has broken receiving.

--- asterisk/channels/chan_modem_i4l.c 2005/06/24 02:15:04 1.29
+++ asterisk/channels/chan_modem_i4l.c 2005/08/05 16:29:30 1.30
@@ -21,7 +21,7 @@

#include "asterisk.h"

-ASTERISK_FILE_VERSION(__FILE__, "$Revision: 1.29 $")
+ASTERISK_FILE_VERSION(__FILE__, "$Revision: 1.30 $")

#include "asterisk/lock.h"
#include "asterisk/vmodem.h"
@@ -316,7 +316,7 @@ static struct ast_frame *i4l_handle_esca

static struct ast_frame *i4l_read(struct ast_modem_pvt *p)
{
- unsigned char result[256];
+ char result[256];
short *b;
struct ast_frame *f=NULL;
int res;
@@ -426,7 +426,7 @@ static struct ast_frame *i4l_read(struct
if (!f)
return NULL;
} else {
- *(b++) = AST_MULAW(result[x]);
+ *(b++) = AST_MULAW((int)result[x]);
p->obuflen += 2;
}
}

Comments: By: Mark Spencer (markster) 2005-11-12 20:02:44.000-0600

Fixed in CVS head, thanks for locating the source of the problem!
By: Digium Subversion (svnbot) 2008-01-15 15:55:59.000-0600

Repository: asterisk
Revision: 7092

U trunk/channels/chan_modem_i4l.c

------------------------------------------------------------------------
r7092 | markster | 2008-01-15 15:55:59 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix i4l breakage (bug ASTERISK-5581)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=7092