[Home]

Summary:ASTERISK-05579: [patch] [post 1.2] remove a bit of duplicated code and fix some indentation.
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2005-11-12 13:30:38.000-0600Date Closed:2005-12-24 17:26:42.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) vm.diff
Description:1. the functions sendmail() and sendpage() have large cut&pasted blocks.
  Here we remove one of them and put it into a function.
2. vm_tempgreeting() had broken indentation of the form
      if (foo) {
           xxx
      } if (bar) {
           yyy
      } if (baz) {
           zzz
      }
  We fix this, and on passing also point out a possibly useless function
  call (given the path we already know the result).

****** ADDITIONAL INFORMATION ******

Apart from a large number of indentation bugs,
this code requires *a lot* of cleanup, much like the one done
on say.c, to make language support more modular.
Comments:By: Tilghman Lesher (tilghman) 2005-12-24 17:26:28.000-0600

Ignore the previous bugnote.  Committed to trunk.  Thank you.