Summary:ASTERISK-05553: [patch] [post 1.2] adding realtime to MeetMe
Reporter:hauke (hauke)Labels:
Date Opened:2005-11-10 09:24:10.000-0600Date Closed:2006-03-06 19:12:22.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_meetme-5702.diff
( 1) asterisk-app_meetme.2.patch
Description:The following patch add realtime functionality to MeetMe.

Table "meetme" will be created in MySQL with the following SQL command:
CREATE TABLE `meetme` (
 `confno` int(11) NOT NULL default '0',
 `pin` int(11) default NULL,
 `adminpin` int(11) default NULL,
 `members` int(11) NOT NULL default '0',
 PRIMARY KEY  (`confno`)


Disclaimer was faxed.
Comments:By: dea (dea) 2005-11-10 12:30:33.000-0600

Slick.  I've been maintaining an out of tree module that provides pseudo-realtime support for MeetMe conferences.  

A feature that I support that I'd be interested in porting to this is schedule checking for start and end times.  I've also been planning to add database support for user and admin flags.

One suggestion would to not set the primary key to confno, unless time checking
is also added.

By: BJ Weschke (bweschke) 2005-11-10 12:46:27.000-0600

You really want to do a realtime_update every time the number of members in the conference changes? Other than that, nice work, and I agree with DEA's comments about how it'd be cool to work some kind of scheduling in.

By: hauke (hauke) 2005-11-11 00:43:09.000-0600

Sorry, but in the first file is a little error because of a missing closing bracket.
So please use  asterisk-app_meetme.2.patch

By: Olle Johansson (oej) 2005-11-17 13:32:02.000-0600

Does this patch still apply to cvs head?

By: hauke (hauke) 2005-12-01 01:02:20.000-0600

Well, I checked out CVS on 11-28-05 around Noon (CET) and the patched app_meetme.c compiled and loaded without errors. But it will be nice if someone else runs some tests on the patched file.

By: Russell Bryant (russell) 2005-12-01 01:05:29.000-0600

There appears to be a tab vs. spaces issue toward the end of find_conf_realtime.  All lines should be indented with tabs.

By: blankman06 (blankman06) 2005-12-26 22:25:03.000-0600

So, I have applied this patch, but I seem to be getting a strange error where the pin and admin pin are only the first three "digits" that I put in the db. I am using odbc with a postgres backend. Here is my table create/insert:

 confno serial PRIMARY KEY,
 pin integer default NULL,
 adminpin integer default NULL,
 members integer NOT NULL default 0
insert into meetme values (999001,12321,1234321,5);

I added some debuging to the app and this is what it is getting back from the call:
Dec 27 00:35:21 DEBUG[14975]: app_meetme.c:1747 find_conf: 999001 isn't a valid conference
Dec 27 00:35:21 DEBUG[14975]: app_meetme.c:1646 find_conf_realtime: Building realtime conference '999001'
Dec 27 00:35:21 DEBUG[14975]: app_meetme.c:1648 find_conf_realtime: In while loop '999001 999001'
Dec 27 00:35:21 DEBUG[14975]: app_meetme.c:1648 find_conf_realtime: In while loop '999001 12321'
Dec 27 00:35:21 DEBUG[14975]: app_meetme.c:1655 find_conf_realtime: Here are the two values for pin:  '123 12321'
Dec 27 00:35:21 DEBUG[14975]: app_meetme.c:1648 find_conf_realtime: In while loop '999001 1234321'
Dec 27 00:35:21 DEBUG[14975]: app_meetme.c:1661 find_conf_realtime: Here are the two values for pinadmin:  '123 1234321'
Dec 27 00:35:21 DEBUG[14975]: app_meetme.c:1648 find_conf_realtime: In while loop '999001 1'
Dec 27 00:35:21 DEBUG[14975]: app_meetme.c:1666 find_conf_realtime:  Out of while loop '999001 123 123'

As you can see there is something in the ast_copy_string call that is causing it not to get the whole pin.

It has been to long since I coded in C to know how/if to fix this ... but the lines are around 1646 :-)

Additional note: I also made a table that use varchars and it has the same errors.

By: ckruetze (ckruetze) 2005-12-27 06:53:02.000-0600

I'm not 100% sure, but I think int(11) is not a good choice for confno, pin and adminpin. I'm away from any Asterisk system so I can't test it right now.
Being int 001 and 01 would be the same confno - is that wanted?

Also will the pin check work correctly if the pin is 00010? Won't it also allow 010 and will it at all check for the leading three 0?


By: Clod Patry (junky) 2006-01-03 20:55:07.000-0600

Could you provide an updated patch for current trunk please?

By: Matthew Fredrickson (mattf) 2006-01-17 11:34:22.000-0600

Yeah, this probably won't apply anymore with all the changes to meetme over the holidays.  Can you put an updated version up?

By: Jason Parker (jparker) 2006-01-17 11:52:38.000-0600

Submitter hasn't responded in a month and a half...has he lost interest in this?

Anyways, patch applies to latest svn trunk if you change &conflock to &conf->playlock on line 24.

Here is an updated patch with the lock change, and spaces changed to tabs.

edit: Take 2 - no more fuzz.

By: hauke (hauke) 2006-02-03 04:30:28.000-0600

Sorry, guys, have a lot of work to do at the moment :(
Will work on MeetMe later...

By: Tilghman Lesher (tilghman) 2006-03-06 19:12:22.000-0600

Committing north's patch to trunk.