| Summary: | ASTERISK-05515: [patch] Voicemails marked for deletion are not deleted | ||
| Reporter: | bdolljr (bdolljr) | Labels: | |
| Date Opened: | 2005-11-08 18:58:52.000-0600 | Date Closed: | 2008-01-15 15:55:46.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_voicemail |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) app_voicemail.c.diff | |
| Description: | A user processing their mailbox marks messages for deletion to find out the next time they login they were not deleted. ****** ADDITIONAL INFORMATION ****** A way to reproduce this is to have 10 messages in your 'Old' folder. Call in and process your 'Old' messages as follows: msg 1 - skip ; msg 2 - skip ; msg 3 - delete ; msg 4 - skip ; msg 5 - delete ; msg 6 - delete ; msg 7 - skip ; msg 8 - delete ; msg 9 - delete ; msg 10 - skip. Then hangup of logoff with '#'. What you end up with in your Old folder is: msg 1 ; msg 2 ; msg 3 (old msg 4) ; msg 4 (old msg 7) ; msg 5 (old msg 10) ; msg 8 (shouldn't be here) ; msg 9 (shouldn't be here) ...so on disk this means you have: msg0000.wav ; msg0001.wav ; msg0002.wav ; msg0003.wav ; msg0004.wav ; msg0007.wav ; msg0008.wav. Not only is the mailbox out of sequence msg0007.wav and msg0008.wav should not be there. This patch fixes this bug in the close_mailbox() function. *diff -u attached - disclaimer on file. | ||
| Comments: | By: bdolljr (bdolljr) 2005-11-08 19:19:37.000-0600 sorry... i should have prefixed the summary with [patch] By: BJ Weschke (bweschke) 2005-11-11 12:09:35.000-0600 confirmed behavior with rc1 / CVS-HEAD By: Kevin P. Fleming (kpfleming) 2005-11-11 16:13:43.000-0600 Committed to CVS HEAD, thanks! By: bdolljr (bdolljr) 2005-11-11 18:28:52.000-0600 Sorry, after reviewing the patch I think there was a bug in what i submitted. We are going through the loop one to many times. It should read: nummsg = x-1 instead of nummsg = x By: Kevin P. Fleming (kpfleming) 2005-11-11 19:19:14.000-0600 Fixed in CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:55:43.000-0600 Repository: asterisk Revision: 7078 U trunk/ChangeLog U trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r7078 | kpfleming | 2008-01-15 15:55:43 -0600 (Tue, 15 Jan 2008) | 2 lines issue ASTERISK-5515 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7078 By: Digium Subversion (svnbot) 2008-01-15 15:55:46.000-0600 Repository: asterisk Revision: 7080 U trunk/ChangeLog U trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r7080 | kpfleming | 2008-01-15 15:55:45 -0600 (Tue, 15 Jan 2008) | 2 lines issue ASTERISK-5515 again ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7080 | ||