[Home]

Summary:ASTERISK-05500: ast_strlen_zero - Janitor project
Reporter:Jason Parker (jparker)Labels:
Date Opened:2005-11-07 18:32:48.000-0600Date Closed:2008-01-15 15:54:40.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) janitor-ast_strlen_zero-head-20051107-1800.patch
Description:Per http://www.asterisk.org/developers/Janitor_Projects, somebody needs to change all of the places that use ast_strlen_zero, to remove the (now) unneeded string==null checks.

As of cvs head on 11/01 (latest code I have avail at work), I see nobody has done this yet.

I'll try to do this tonight.  I just wanted to open a bug in advance, so that other people don't spend their time on this as well.

****** ADDITIONAL INFORMATION ******

If anybody is already doing this, please let me know, and I'll either stop, or we can each take half or something.


Patch to follow.
Comments:By: BJ Weschke (bweschke) 2005-11-07 19:15:45.000-0600

I did do some of this work early last week. You may want to update to the latest CVS-HEAD to make certain you're not redoing stuff that's already been done.
By: Jason Parker (jparker) 2005-11-07 20:08:03.000-0600

Patch against current cvs head uploaded as promised.

24 files modified.

cli.c has a few instances of this happening, but I didn't want to really screw with it and break something...it's "messy".
By: Kevin P. Fleming (kpfleming) 2005-11-07 21:04:45.000-0600

Committed to CVS HEAD, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:54:40.000-0600

Repository: asterisk
Revision: 7011

U   trunk/ChangeLog
U   trunk/apps/app_queue.c
U   trunk/apps/app_voicemail.c
U   trunk/apps/app_zapscan.c
U   trunk/channels/chan_misdn.c
U   trunk/channels/chan_sip.c
U   trunk/funcs/func_cdr.c
U   trunk/funcs/func_db.c
U   trunk/funcs/func_enum.c
U   trunk/funcs/func_env.c
U   trunk/funcs/func_groupcount.c
U   trunk/funcs/func_logic.c
U   trunk/funcs/func_math.c
U   trunk/funcs/func_md5.c
U   trunk/funcs/func_strings.c
U   trunk/funcs/func_uri.c
U   trunk/pbx/pbx_ael.c
U   trunk/pbx/pbx_dundi.c
U   trunk/pbx/pbx_loopback.c
U   trunk/pbx/pbx_realtime.c
U   trunk/res/res_agi.c
U   trunk/res/res_config_odbc.c
U   trunk/res/res_features.c
U   trunk/res/res_monitor.c
U   trunk/res/res_musiconhold.c

------------------------------------------------------------------------
r7011 | kpfleming | 2008-01-15 15:54:40 -0600 (Tue, 15 Jan 2008) | 2 lines

issue ASTERISK-5500

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=7011