Summary:ASTERISK-05470: chan_oss: misinitialized variables cause audio to be blocked
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2005-11-05 12:07:48.000-0600Date Closed:2008-01-15 15:53:56.000-0600
Versions:Frequency of
Environment:Attachments:( 0) chan_oss.patch
Description:This patch fixes two bugs that in some cases cause audio to be blocked:
+  o->lastopen is initialized to 0 when a channel is created, which is
  too far in the past now and causes a comparison to fail due to
  integer wraps.
  Now set it to the current time so we have a reasonable window.
+  in the current code, o->nosound should almost always be (o->cursound != -1)
  but in a couple of places i forgot to update o->nosound.
  A proper fix should actually change the (internal) logic for handling
  the two variables, but for the time being this will do.  
Comments:By: Mark Spencer (markster) 2005-11-05 23:52:25.000-0600

Fixed in CVS head, thanks for the patch!

By: Digium Subversion (svnbot) 2008-01-15 15:53:56.000-0600

Repository: asterisk
Revision: 6967

U   trunk/channels/chan_oss.c

r6967 | markster | 2008-01-15 15:53:56 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix chan_oss buglets (bug ASTERISK-5470)