Summary: | ASTERISK-05469: extra trailing ; in AST_DECLARE_APP_ARGS | ||
Reporter: | Luigi Rizzo (rizzo) | Labels: | |
Date Opened: | 2005-11-05 11:51:40.000-0600 | Date Closed: | 2008-01-15 15:53:55.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | include/asterisk/app.h declares the macro AST_DECLARE_APP_ARGS with a trailing semicolon. The two places that use this macro (app_dial.c and app_mixmonitor.c) also put a semicolon at the end, which the compiler interprets as an empty statement. The net result is that you must put AST_DECLARE_APP_ARGS as the last declaration or some compilers might complain because you have code in the middle of a declaration block. Fix is to remove the trailing ; in the macro declaration. This is consistent with other macros defined in the same file. ****** ADDITIONAL INFORMATION ****** (i am not sure if the category of this bug is "general asterisk" or "general application") | ||
Comments: | By: Mark Spencer (markster) 2005-11-05 23:48:52.000-0600 Fixed in CVS head, thank you for pointing this out. By: Digium Subversion (svnbot) 2008-01-15 15:53:55.000-0600 Repository: asterisk Revision: 6966 U trunk/include/asterisk/app.h ------------------------------------------------------------------------ r6966 | markster | 2008-01-15 15:53:55 -0600 (Tue, 15 Jan 2008) | 2 lines Fix extra semicolon (bug ASTERISK-5469) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6966 |