Summary: | ASTERISK-05435: Internal HINT state is becoming corrupt/invalid. | ||
Reporter: | xrobau (xrobau) | Labels: | |
Date Opened: | 2005-11-03 05:25:56.000-0600 | Date Closed: | 2008-01-15 15:54:39.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | I have a reasonable number of phone's that are now implementing subscriptions and HINT's, and it all seems to be working well from a phone's standpoint. However, after upgrading to todays CVS, I noticed that there are some issues with the CLI display of HINT's. I also noticed that, whilst debugging, a normal sip packet has CR/LF on every line, but the NOTIFY packets don't have ^M on the end of every line - is this deliberate (because it's XML)? ****** ADDITIONAL INFORMATION ****** 'show hints' produces [snipped] 399 : SIP/399 State:Unknown Watchers 0 326 : SIP/326 State:Invalid Watchers 1 322 : SIP/322 State:Unknown Watchers 3 321 : SIP/321 State:Unknown Watchers 2 When a device is ringing, the state changes to garbage: 322 : SIP/322 State:U1ÒWVSìD$<èÄ Watchers 3 And the device that is actually dialling changes to: 399 : SIP/399 State:Not in use Watchers 0 As mentioned above, whilst checking to see what was actually being sent to the phones, I noticed that ^M's are missing: Nov 3 21:21:28 VERBOSE[23029] logger.c: Reliably Transmitting (no NAT) to 192.168.210.128:2051: NOTIFY sip:321@192.168.207.67 SIP/2.0^M Via: SIP/2.0/UDP 192.168.207.67:5060;branch=z9hG4bK4dcc924f^M From: <sip:336@202.173.178.224;user=phone>;tag=as27836a37^M To: <sip:321@192.168.207.67>;tag=hn1eomwg9c^M Contact: <sip:336@192.168.207.67>^M Call-ID: 3c26701c94ed-rcplb23vkj9i@snom360^M CSeq: 102 NOTIFY^M User-Agent: Asterisk PBX^M Max-Forwards: 70^M Event: dialog^M Content-Type: application/dialog-info+xml^M Subscription-State: active^M Content-Length: 206^M ^M <?xml version="1.0"?> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="0" state="full" entity="sip:336@202.173.178.224"> <dialog id="336"> <state>terminated</state> </dialog> </dialog-info> --- It's probably a xylome/oej question as to wether that's a mistake or not! --Rob | ||
Comments: | By: xrobau (xrobau) 2005-11-03 05:27:02.000-0600 Argh. Sorry. Somehow this managed to fall into 'Code Formatting/Comments'. Please feel free to relocate this to the correct area. By: xrobau (xrobau) 2005-11-03 05:31:37.000-0600 Possibly a continuation of ASTERISK-5138 too.. By: Kevin P. Fleming (kpfleming) 2005-11-07 21:00:58.000-0600 Fixed in CVS HEAD. The wrong function was being used to translate from numeric to textual state representation. The XML embedded in the SIP packets has no need for extra characters like that to be added; XML does not care about whitespace between elements. By: Digium Subversion (svnbot) 2008-01-15 15:54:39.000-0600 Repository: asterisk Revision: 7010 U trunk/ChangeLog U trunk/pbx.c ------------------------------------------------------------------------ r7010 | kpfleming | 2008-01-15 15:54:38 -0600 (Tue, 15 Jan 2008) | 2 lines issue ASTERISK-5435 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7010 |