|Summary:||ASTERISK-05432: janitor project - priority jumping and APP_ARGS conversions for pqm,upqm,aqm,and rqm|
|Reporter:||BJ Weschke (bweschke)||Labels:|
|Date Opened:||2005-11-02 16:08:29.000-0600||Date Closed:||2008-01-15 15:54:54.000-0600|
|Environment:||Attachments:||( 0) app_queue_janitor.patch|
|Description:||I think I've done everything the way it should be done here, but would certainly appreciate some peer review/comments.|
|Comments:||By: Russell Bryant (russell) 2005-11-03 15:21:22.000-0600|
Can you update the descriptions of the applications to reflect the new status variable?
By: BJ Weschke (bweschke) 2005-11-03 15:47:39.000-0600
good call. done.
By: Russell Bryant (russell) 2005-11-06 14:04:22.000-0600
It looks good at first glance, except for some weirdness with tabs vs. spaces in some of your changes
By: BJ Weschke (bweschke) 2005-11-06 14:14:51.000-0600
whitespace cleanups / space vs. tab cleanups from putty copy+paste mistakes.
By: Russell Bryant (russell) 2005-11-06 14:57:17.000-0600
I don't know how I feel about using "MEMORYERROR" as one of the exit status values. We don't do that for any of the other applications, and just about all of them could exit because of a memory error.
By: BJ Weschke (bweschke) 2005-11-06 18:14:03.000-0600
k. fair enough. MEMORYERROR is now gone in the latest patch.
By: Tilghman Lesher (tilghman) 2005-11-07 08:18:57.000-0600
1. You've stripped out the removal of the -XXXX portion of the channel name. That code needs to remain.
2. Do not embed tabs in the help text.
3. Help text should wrap at 80 columns, given that Asterisk should always be running on a text screen without either X or framebuffer running.
By: BJ Weschke (bweschke) 2005-11-07 08:26:34.000-0600
1) I'll add it back in, but it's not clear to me what it does. Can you tell me so I can document this somewhere?
2) Will fix.
3) Will fix.
By: BJ Weschke (bweschke) 2005-11-07 08:57:57.000-0600
formatting changes made to help texts and added back in removal of the -XXX portion. Are we doing removal because when we need to inherit the interface param from chan->name, the chan->name can sometimes have the unique ID after the '-' and we don't want that for the interface?
By: Tilghman Lesher (tilghman) 2005-11-07 10:25:28.000-0600
That's correct. The main problem with the unique identifier is that it's unlikely to have the same suffix the second time you call it, so while you might be able to add an interface with a suffix, you won't be able to remove it.
By: BJ Weschke (bweschke) 2005-11-07 10:28:46.000-0600
drumkilla - I think this one is rdy for you now.
By: Tilghman Lesher (tilghman) 2005-11-07 13:29:08.000-0600
You still have tabs in the help text of Add, Remove, and Pause
By: BJ Weschke (bweschke) 2005-11-07 13:44:07.000-0600
you're right. there was still 1 tab existing after the channel var names. It's supressed now. those weren't so easy to find with vi. sorry.
By: Russell Bryant (russell) 2005-11-07 23:52:56.000-0600
added to cvs head, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:54:54.000-0600
r7026 | russell | 2008-01-15 15:54:54 -0600 (Tue, 15 Jan 2008) | 4 lines
make app_queue 1.2 jump compliant (issue ASTERISK-5432)
add missing includes of stdio.h
remove some unused and duplicate headers