| Summary: | ASTERISK-05424: [patch] Recent Cygwin portability patches broke cross-compilation | ||
| Reporter: | Wojtek Kaniewski (wojtekka) | Labels: | |
| Date Opened: | 2005-11-02 05:59:07.000-0600 | Date Closed: | 2008-01-15 15:54:46.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/CodecInterface |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) asterisk-head-cross-gsm.patch ( 1) CrossCompileFix.diff.txt | |
| Description: | Patches for bug ASTERISK-4558 broke cross-compilation of codecs/gsm/libgsm with the line: PROC=$(shell uname -m) in codecs/gsm/libgsm/Makefile which shadows user-defined $(PROC). In my case (cross-compilation on x86 for PowerPC), ppc-linux-gcc complained about unknown -march=i686. Removing the line fixes the problem, at least for PowerPC. I don't have Cygwin to test, so someone should test the fix before commiting to CVS. ****** ADDITIONAL INFORMATION ****** No disclaimer on file, the fix is trivial. | ||
| Comments: | By: Michael Jerris (mikej) 2005-11-02 07:41:01.000-0600 When I do that change on cygwin, I get the following: make[1]: Entering directory `/usr/src/asterisk/codecs' make -C gsm lib/libgsm.a make[2]: Entering directory `/usr/src/asterisk/codecs/gsm' gcc -pipe -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declaration s -g -Iinclude -I../include -D_REENTRANT -D_GNU_SOURCE -O6 -fomit-fr ame-pointer -c -DNeedFunctionPrototypes=1 -funroll-loops -O6 -march= -DSASR -D NDEBUG -DWAV49 -I./inc src/add.c src/add.c:1: error: bad value () for -march= switch src/add.c:1: error: bad value () for -mtune= switch make[2]: *** [src/add.o] Error 1 make[2]: Leaving directory `/usr/src/asterisk/codecs/gsm' make[1]: *** [gsm/lib/libgsm.a] Error 2 make[1]: Leaving directory `/usr/src/asterisk/codecs' make: *** [subdirs] Error 1 Which was the original reason for this change. It makes no sense as that var should be set from the main makefile, but for some reason, it just isn't there. Anyone have any ideas why? By: Michael Jerris (mikej) 2005-11-02 07:51:42.000-0600 Uploaded the complete fix that doesn't break cygwin... sorry about that. By: Kevin P. Fleming (kpfleming) 2005-11-07 22:40:51.000-0600 Committed to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:54:46.000-0600 Repository: asterisk Revision: 7018 U trunk/ChangeLog U trunk/Makefile U trunk/codecs/gsm/Makefile ------------------------------------------------------------------------ r7018 | kpfleming | 2008-01-15 15:54:46 -0600 (Tue, 15 Jan 2008) | 2 lines issue ASTERISK-5424 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7018 | ||