| Summary: | ASTERISK-05413: [patch] janitor project - app_mixmonitor - ast_strlen_zero now checks for the string to be defined | ||
| Reporter: | BJ Weschke (bweschke) | Labels: | |
| Date Opened: | 2005-11-01 10:20:41.000-0600 | Date Closed: | 2008-01-15 15:53:23.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) app_mixmonitor.patch | |
| Description: | Previously, the function ast_strlen_zero only checked for the first character of the string to be equal to '\0'. Now, ast_strlen_zero also checks for the string to be defined. This means that all of the conditional statements that check for the char * to be NULL before calling ast_strlen_zero need to be changed so that they don't make this unnecessary check. For example, "if (!s || ast_strlen_zero(s))" can now safely be "if (ast_strlen_zero(s))". | ||
| Comments: | By: Kevin P. Fleming (kpfleming) 2005-11-01 16:05:54.000-0600 Committed to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:53:23.000-0600 Repository: asterisk Revision: 6933 U trunk/ChangeLog U trunk/apps/app_mixmonitor.c ------------------------------------------------------------------------ r6933 | kpfleming | 2008-01-15 15:53:23 -0600 (Tue, 15 Jan 2008) | 2 lines issue ASTERISK-5413 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6933 | ||