[Home]

Summary:ASTERISK-05411: Syntax Error in Makefile triggered when user doesn't have kernel sources
Reporter:Tony Mountifield (softins)Labels:
Date Opened:2005-11-01 08:53:40.000-0600Date Closed:2008-06-07 11:08:00
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:On line 125 of zaptel/Makefile, there is the following:

@if [ -z "$(KSRC)" -o ! -d $(KSRC) ]; then echo "You do not appear to have the sources for the $(KVERS) kernel installed."; exit 1 ; fi

If $(KSRC) is undefined or empty, this results in a syntax error being reported by the "[" program (test), and the make fails to exit. Instead, the user gets some confusing error messages.

The $(KSRC) after -d should be "$(KSRC)"
Comments:By: Kevin P. Fleming (kpfleming) 2005-11-01 16:14:14.000-0600

What, no patch? Geez, all this work do to :-)

Fixed in CVS HEAD, thanks!
By: Digium Subversion (svnbot) 2008-06-07 11:08:00

Repository: dahdi
Revision: 804

U   trunk/Makefile

------------------------------------------------------------------------
r804 | kpfleming | 2008-06-07 11:07:58 -0500 (Sat, 07 Jun 2008) | 2 lines

properly quote variable reference so the test won't fail (issue ASTERISK-5411)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=804