[Home]

Summary:ASTERISK-05399: ast_app_getvoice is not writing frames
Reporter:Michael Cramer (micc)Labels:
Date Opened:2005-10-30 01:50:58.000-0600Date Closed:2008-01-15 15:53:11.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:In app.c around line 200 there should be a call like:
res = ast_writestream(writer, f);

and then to be consistent with other similar functions should also have this at the end of the AST_FRAME_VOICE else if block:

/* Exit on any error */
if (res) {
   ast_log(LOG_WARNING, "Error writing frame\n");
   ast_frfree(f);
   break;
}


****** ADDITIONAL INFORMATION ******

I'm not sure who else uses this but I have been using it with this modification for a few months now. When I upgraded to the latest version I started to notice problems again and needed to patch it all over again, so I figured it was time to submit for inclusing into the tree.
Comments:By: Mark Spencer (markster) 2005-10-30 02:06:01.000-0600

Fixed in CVS head.  Thanks for the pointer.
By: Russell Bryant (russell) 2005-10-31 20:36:49.000-0600

fixed in 1.0 as well
By: Digium Subversion (svnbot) 2008-01-15 15:52:48.000-0600

Repository: asterisk
Revision: 6894

U   trunk/app.c

------------------------------------------------------------------------
r6894 | markster | 2008-01-15 15:52:47 -0600 (Tue, 15 Jan 2008) | 2 lines

Actually write audio to file in get_voice (bug ASTERISK-5399)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6894
By: Digium Subversion (svnbot) 2008-01-15 15:53:11.000-0600

Repository: asterisk
Revision: 6920

U   branches/v1-0/app.c

------------------------------------------------------------------------
r6920 | russell | 2008-01-15 15:53:11 -0600 (Tue, 15 Jan 2008) | 2 lines

Actually write audio to file in get_voice (issue ASTERISK-5399)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6920