[Home]

Summary:ASTERISK-05397: call-limit not reset on closed channels
Reporter:apignard (apignard)Labels:
Date Opened:2005-10-29 23:17:45Date Closed:2008-01-15 15:52:59.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I try use call-limit for a peer. Limit is not decrease on a channel exit.

****** STEPS TO REPRODUCE ******

Set limit to 5 for example, try make several call and see that's limit is reach even without active channel.
Only try in incoming call.

****** ADDITIONAL INFORMATION ******

[account]            
host=<REMOVED IP>
type=peer
context=customer
disallow=all
allow=ulaw        
call-limit=5
dtmfmode=rfc2833
videosupport=no
silenceSuppression=no
canreinvite=no  
insecure=port,invite
Comments:By: paradise (paradise) 2005-10-30 00:13:58

"silenceSuppression=no" really this option exists in sip.conf?
By: Mark Spencer (markster) 2005-10-30 02:08:35.000-0600

Please supply a sip debug of the call as per the bug guidelines.
By: Olle Johansson (oej) 2005-10-30 03:00:47.000-0600

Remember to set debug to 4, verbose to 4 and turn on sip debugging when taking a call trace. Thank you.
By: apignard (apignard) 2005-10-30 05:31:28.000-0600

here is what i have in full log :

Oct 30 12:19:36 DEBUG[20904] chan_sip.c: update_call_counter() - decrement call limit counter
Oct 30 12:19:36 DEBUG[20904] chan_sip.c: Updating call counter for incoming call
Oct 30 12:19:36 DEBUG[20904] chan_sip.c: Call from peer 'xxxxxxx' removed from call limit 5

...

Oct 30 12:29:46 DEBUG[21989] chan_sip.c: Checking SIP call limits for device
Oct 30 12:29:46 DEBUG[21989] chan_sip.c: Updating call counter for incoming call
Oct 30 12:29:46 ERROR[21989] chan_sip.c: Call from peer 'xxxxxxx' rejected due to usage limit of 5
Oct 30 12:29:46 NOTICE[21989] chan_sip.c: Failed to place call for user , too many calls

When counter don't reach limit, seems decrease and increase is correctly handle.
Only when reach limit, counter seems not decrease.
By: Kevin P. Fleming (kpfleming) 2005-10-31 17:16:49.000-0600

Fixed in CVS HEAD, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:52:59.000-0600

Repository: asterisk
Revision: 6907

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r6907 | kpfleming | 2008-01-15 15:52:58 -0600 (Tue, 15 Jan 2008) | 2 lines

don't increment 'inuse' counter when call is being failed because of limit (issue ASTERISK-5397)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6907